* [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" @ 2018-08-28 15:47 Ian W MORRISON 2018-08-28 15:48 ` Jens Axboe 0 siblings, 1 reply; 11+ messages in thread From: Ian W MORRISON @ 2018-08-28 15:47 UTC (permalink / raw) To: axboe Cc: linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei, ianwmorrison Kernel oops when booting on Bay and Cherry Trail devices such as Intel Compute Stick. Bisected as: commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't busy in case of 'none'") This patch reverts the above commit. Signed-off-by: Ian W MORRISON <ianwmorrison@gmail.com> --- block/blk-mq-sched.c | 13 +------------ block/blk-mq.c | 27 +-------------------------- block/blk-mq.h | 2 -- 3 files changed, 2 insertions(+), 40 deletions(-) diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c index 29bfe8017a2d..3204c39cb39f 100644 --- a/block/blk-mq-sched.c +++ b/block/blk-mq-sched.c @@ -405,19 +405,8 @@ void blk_mq_sched_insert_requests(struct request_queue *q, if (e && e->type->ops.mq.insert_requests) e->type->ops.mq.insert_requests(hctx, list, false); - else { - /* - * try to issue requests directly if the hw queue isn't - * busy in case of 'none' scheduler, and this way may save - * us one extra enqueue & dequeue to sw queue. - */ - if (!hctx->dispatch_busy && !e && !run_queue_async) { - blk_mq_try_issue_list_directly(hctx, list); - if (list_empty(list)) - return; - } + else blk_mq_insert_requests(hctx, ctx, list); - } blk_mq_run_hw_queue(hctx, run_queue_async); } diff --git a/block/blk-mq.c b/block/blk-mq.c index 85a1c1a59c72..09e4611d330d 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1693,16 +1693,13 @@ static blk_status_t __blk_mq_issue_directly(struct blk_mq_hw_ctx *hctx, ret = q->mq_ops->queue_rq(hctx, &bd); switch (ret) { case BLK_STS_OK: - blk_mq_update_dispatch_busy(hctx, false); *cookie = new_cookie; break; case BLK_STS_RESOURCE: case BLK_STS_DEV_RESOURCE: - blk_mq_update_dispatch_busy(hctx, true); __blk_mq_requeue_request(rq); break; default: - blk_mq_update_dispatch_busy(hctx, false); *cookie = BLK_QC_T_NONE; break; } @@ -1785,27 +1782,6 @@ blk_status_t blk_mq_request_issue_directly(struct request *rq) return ret; } -void blk_mq_try_issue_list_directly(struct blk_mq_hw_ctx *hctx, - struct list_head *list) -{ - while (!list_empty(list)) { - blk_status_t ret; - struct request *rq = list_first_entry(list, struct request, - queuelist); - - list_del_init(&rq->queuelist); - ret = blk_mq_request_issue_directly(rq); - if (ret != BLK_STS_OK) { - if (ret == BLK_STS_RESOURCE || - ret == BLK_STS_DEV_RESOURCE) { - list_add(&rq->queuelist, list); - break; - } - blk_mq_end_request(rq, ret); - } - } -} - static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio) { const int is_sync = op_is_sync(bio->bi_opf); @@ -1906,8 +1882,7 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio) blk_mq_try_issue_directly(data.hctx, same_queue_rq, &cookie); } - } else if ((q->nr_hw_queues > 1 && is_sync) || (!q->elevator && - !data.hctx->dispatch_busy)) { + } else if (q->nr_hw_queues > 1 && is_sync) { blk_mq_put_ctx(data.ctx); blk_mq_bio_to_request(rq, bio); blk_mq_try_issue_directly(data.hctx, rq, &cookie); diff --git a/block/blk-mq.h b/block/blk-mq.h index 9497b47e2526..bc2b24735ed4 100644 --- a/block/blk-mq.h +++ b/block/blk-mq.h @@ -64,8 +64,6 @@ void blk_mq_insert_requests(struct blk_mq_hw_ctx *hctx, struct blk_mq_ctx *ctx, /* Used by blk_insert_cloned_request() to issue request directly */ blk_status_t blk_mq_request_issue_directly(struct request *rq); -void blk_mq_try_issue_list_directly(struct blk_mq_hw_ctx *hctx, - struct list_head *list); /* * CPU -> queue mappings -- 2.17.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" 2018-08-28 15:47 [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" Ian W MORRISON @ 2018-08-28 15:48 ` Jens Axboe 2018-08-28 16:07 ` Ian W MORRISON 0 siblings, 1 reply; 11+ messages in thread From: Jens Axboe @ 2018-08-28 15:48 UTC (permalink / raw) To: Ian W MORRISON Cc: linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei On 8/28/18 9:47 AM, Ian W MORRISON wrote: > Kernel oops when booting on Bay and Cherry Trail devices > such as Intel Compute Stick. Bisected as: > > commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't busy in case of 'none'") > > This patch reverts the above commit. Did I miss the posting of that oops? Just curious where this is going wrong. Not adverse to reverting, but I'd like to try to understand the issue first. -- Jens Axboe ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" 2018-08-28 15:48 ` Jens Axboe @ 2018-08-28 16:07 ` Ian W MORRISON 2018-08-28 16:09 ` Jens Axboe 0 siblings, 1 reply; 11+ messages in thread From: Ian W MORRISON @ 2018-08-28 16:07 UTC (permalink / raw) To: axboe Cc: linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei On Wed, 29 Aug 2018 at 01:48, Jens Axboe <axboe@kernel.dk> wrote: > > On 8/28/18 9:47 AM, Ian W MORRISON wrote: > > Kernel oops when booting on Bay and Cherry Trail devices > > such as Intel Compute Stick. Bisected as: > > > > commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't busy in case of 'none'") > > > > This patch reverts the above commit. > > Did I miss the posting of that oops? Just curious where this is > going wrong. Not adverse to reverting, but I'd like to try to > understand the issue first. > > -- > Jens Axboe > I've not been able to capture it however manually transcribing what is on the screen: mmc0: Got data interrupt 0x00000002 even though no data operation followed by: mmc0: sdhci: ============= SDHCI REGISTER DUMP ============== Do you want any specific register value or should I transcribe each (as I am working from an image taken at boot)? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" 2018-08-28 16:07 ` Ian W MORRISON @ 2018-08-28 16:09 ` Jens Axboe [not found] ` <CAFXWsS82zi7w81-=4ALwMiFm9iQd=NgF3sSBLfvNdU2czEzxwg@mail.gmail.com> 0 siblings, 1 reply; 11+ messages in thread From: Jens Axboe @ 2018-08-28 16:09 UTC (permalink / raw) To: Ian W MORRISON Cc: linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei On 8/28/18 10:07 AM, Ian W MORRISON wrote: > On Wed, 29 Aug 2018 at 01:48, Jens Axboe <axboe@kernel.dk> wrote: >> >> On 8/28/18 9:47 AM, Ian W MORRISON wrote: >>> Kernel oops when booting on Bay and Cherry Trail devices >>> such as Intel Compute Stick. Bisected as: >>> >>> commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't busy in case of 'none'") >>> >>> This patch reverts the above commit. >> >> Did I miss the posting of that oops? Just curious where this is >> going wrong. Not adverse to reverting, but I'd like to try to >> understand the issue first. >> >> -- >> Jens Axboe >> > > I've not been able to capture it however manually transcribing what is > on the screen: > > mmc0: Got data interrupt 0x00000002 even though no data operation > > followed by: > > mmc0: sdhci: ============= SDHCI REGISTER DUMP ============== > > Do you want any specific register value or should I transcribe each > (as I am working from an image taken at boot)? Just take a picture of the screen, that should be good enough. -- Jens Axboe ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <CAFXWsS82zi7w81-=4ALwMiFm9iQd=NgF3sSBLfvNdU2czEzxwg@mail.gmail.com>]
* Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" [not found] ` <CAFXWsS82zi7w81-=4ALwMiFm9iQd=NgF3sSBLfvNdU2czEzxwg@mail.gmail.com> @ 2018-08-28 16:13 ` Jens Axboe 2018-08-28 17:01 ` Ian W MORRISON 0 siblings, 1 reply; 11+ messages in thread From: Jens Axboe @ 2018-08-28 16:13 UTC (permalink / raw) To: Ian W MORRISON Cc: linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei On 8/28/18 10:10 AM, Ian W MORRISON wrote: > On Wed, 29 Aug 2018 at 02:09, Jens Axboe <axboe@kernel.dk> wrote: >> >> On 8/28/18 10:07 AM, Ian W MORRISON wrote: >>> On Wed, 29 Aug 2018 at 01:48, Jens Axboe <axboe@kernel.dk> wrote: >>>> >>>> On 8/28/18 9:47 AM, Ian W MORRISON wrote: >>>>> Kernel oops when booting on Bay and Cherry Trail devices >>>>> such as Intel Compute Stick. Bisected as: >>>>> >>>>> commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't busy in case of 'none'") >>>>> >>>>> This patch reverts the above commit. >>>> >>>> Did I miss the posting of that oops? Just curious where this is >>>> going wrong. Not adverse to reverting, but I'd like to try to >>>> understand the issue first. >>>> >>>> -- >>>> Jens Axboe >>>> >>> >>> I've not been able to capture it however manually transcribing what is >>> on the screen: >>> >>> mmc0: Got data interrupt 0x00000002 even though no data operation >>> >>> followed by: >>> >>> mmc0: sdhci: ============= SDHCI REGISTER DUMP ============== >>> >>> Do you want any specific register value or should I transcribe each >>> (as I am working from an image taken at boot)? >> >> Just take a picture of the screen, that should be good enough. >> >> -- >> Jens Axboe >> > > Attached as requested. Can you see if this patch helps? https://marc.info/?l=linux-mmc&m=153485326025301&w=2 -- Jens Axboe ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" 2018-08-28 16:13 ` Jens Axboe @ 2018-08-28 17:01 ` Ian W MORRISON 2018-08-28 17:12 ` Jens Axboe 0 siblings, 1 reply; 11+ messages in thread From: Ian W MORRISON @ 2018-08-28 17:01 UTC (permalink / raw) To: axboe Cc: linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei On Wed, 29 Aug 2018 at 02:13, Jens Axboe <axboe@kernel.dk> wrote: > > On 8/28/18 10:10 AM, Ian W MORRISON wrote: > > On Wed, 29 Aug 2018 at 02:09, Jens Axboe <axboe@kernel.dk> wrote: > >> > >> On 8/28/18 10:07 AM, Ian W MORRISON wrote: > >>> On Wed, 29 Aug 2018 at 01:48, Jens Axboe <axboe@kernel.dk> wrote: > >>>> > >>>> On 8/28/18 9:47 AM, Ian W MORRISON wrote: > >>>>> Kernel oops when booting on Bay and Cherry Trail devices > >>>>> such as Intel Compute Stick. Bisected as: > >>>>> > >>>>> commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't busy in case of 'none'") > >>>>> > >>>>> This patch reverts the above commit. > >>>> > >>>> Did I miss the posting of that oops? Just curious where this is > >>>> going wrong. Not adverse to reverting, but I'd like to try to > >>>> understand the issue first. > >>>> > >>>> -- > >>>> Jens Axboe > >>>> > >>> > >>> I've not been able to capture it however manually transcribing what is > >>> on the screen: > >>> > >>> mmc0: Got data interrupt 0x00000002 even though no data operation > >>> > >>> followed by: > >>> > >>> mmc0: sdhci: ============= SDHCI REGISTER DUMP ============== > >>> > >>> Do you want any specific register value or should I transcribe each > >>> (as I am working from an image taken at boot)? > >> > >> Just take a picture of the screen, that should be good enough. > >> > >> -- > >> Jens Axboe > >> > > > > Attached as requested. > > Can you see if this patch helps? > > https://marc.info/?l=linux-mmc&m=153485326025301&w=2 > > -- > Jens Axboe > I confirm that the above patch works with commit 6ce3dd6eec11 and removes the need for reverting it on eMMC based devices. Tested on Bay Trail, Cherry Trail (both now working) and Kaby Lake (not affected) devices. Many thanks, Ian ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" 2018-08-28 17:01 ` Ian W MORRISON @ 2018-08-28 17:12 ` Jens Axboe 2018-08-28 19:11 ` Hunter, Adrian 0 siblings, 1 reply; 11+ messages in thread From: Jens Axboe @ 2018-08-28 17:12 UTC (permalink / raw) To: Ian W MORRISON Cc: linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei, Adrian Hunter On 8/28/18 11:01 AM, Ian W MORRISON wrote: > On Wed, 29 Aug 2018 at 02:13, Jens Axboe <axboe@kernel.dk> wrote: >> >> On 8/28/18 10:10 AM, Ian W MORRISON wrote: >>> On Wed, 29 Aug 2018 at 02:09, Jens Axboe <axboe@kernel.dk> wrote: >>>> >>>> On 8/28/18 10:07 AM, Ian W MORRISON wrote: >>>>> On Wed, 29 Aug 2018 at 01:48, Jens Axboe <axboe@kernel.dk> wrote: >>>>>> >>>>>> On 8/28/18 9:47 AM, Ian W MORRISON wrote: >>>>>>> Kernel oops when booting on Bay and Cherry Trail devices >>>>>>> such as Intel Compute Stick. Bisected as: >>>>>>> >>>>>>> commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't busy in case of 'none'") >>>>>>> >>>>>>> This patch reverts the above commit. >>>>>> >>>>>> Did I miss the posting of that oops? Just curious where this is >>>>>> going wrong. Not adverse to reverting, but I'd like to try to >>>>>> understand the issue first. >>>>>> >>>>>> -- >>>>>> Jens Axboe >>>>>> >>>>> >>>>> I've not been able to capture it however manually transcribing what is >>>>> on the screen: >>>>> >>>>> mmc0: Got data interrupt 0x00000002 even though no data operation >>>>> >>>>> followed by: >>>>> >>>>> mmc0: sdhci: ============= SDHCI REGISTER DUMP ============== >>>>> >>>>> Do you want any specific register value or should I transcribe each >>>>> (as I am working from an image taken at boot)? >>>> >>>> Just take a picture of the screen, that should be good enough. >>>> >>>> -- >>>> Jens Axboe >>>> >>> >>> Attached as requested. >> >> Can you see if this patch helps? >> >> https://marc.info/?l=linux-mmc&m=153485326025301&w=2 >> >> -- >> Jens Axboe >> > > I confirm that the above patch works with commit 6ce3dd6eec11 > and removes the need for reverting it on eMMC based devices. > > Tested on Bay Trail, Cherry Trail (both now working) and Kaby Lake > (not affected) devices. Great, thanks for testing. Adrian, when is this going upstream? -- Jens Axboe ^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" 2018-08-28 17:12 ` Jens Axboe @ 2018-08-28 19:11 ` Hunter, Adrian 2018-08-29 6:15 ` Ulf Hansson 0 siblings, 1 reply; 11+ messages in thread From: Hunter, Adrian @ 2018-08-28 19:11 UTC (permalink / raw) To: Jens Axboe, Ian W MORRISON Cc: linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei, Ulf Hansson > -----Original Message----- > From: Jens Axboe [mailto:axboe@kernel.dk] > Sent: Tuesday, August 28, 2018 8:12 PM > To: Ian W MORRISON <ianwmorrison@gmail.com> > Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org; > kashyap.desai@broadcom.com; loberman@redhat.com; osandov@fb.com; > hch@lst.de; bart.vanassche@wdc.com; hare@suse.de; > ming.lei@redhat.com; Hunter, Adrian <adrian.hunter@intel.com> > Subject: Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in > case of 'none'" > > On 8/28/18 11:01 AM, Ian W MORRISON wrote: > > On Wed, 29 Aug 2018 at 02:13, Jens Axboe <axboe@kernel.dk> wrote: > >> > >> On 8/28/18 10:10 AM, Ian W MORRISON wrote: > >>> On Wed, 29 Aug 2018 at 02:09, Jens Axboe <axboe@kernel.dk> wrote: > >>>> > >>>> On 8/28/18 10:07 AM, Ian W MORRISON wrote: > >>>>> On Wed, 29 Aug 2018 at 01:48, Jens Axboe <axboe@kernel.dk> > wrote: > >>>>>> > >>>>>> On 8/28/18 9:47 AM, Ian W MORRISON wrote: > >>>>>>> Kernel oops when booting on Bay and Cherry Trail devices such as > >>>>>>> Intel Compute Stick. Bisected as: > >>>>>>> > >>>>>>> commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't > >>>>>>> busy in case of 'none'") > >>>>>>> > >>>>>>> This patch reverts the above commit. > >>>>>> > >>>>>> Did I miss the posting of that oops? Just curious where this is > >>>>>> going wrong. Not adverse to reverting, but I'd like to try to > >>>>>> understand the issue first. > >>>>>> > >>>>>> -- > >>>>>> Jens Axboe > >>>>>> > >>>>> > >>>>> I've not been able to capture it however manually transcribing > >>>>> what is on the screen: > >>>>> > >>>>> mmc0: Got data interrupt 0x00000002 even though no data operation > >>>>> > >>>>> followed by: > >>>>> > >>>>> mmc0: sdhci: ============= SDHCI REGISTER DUMP > ============== > >>>>> > >>>>> Do you want any specific register value or should I transcribe > >>>>> each (as I am working from an image taken at boot)? > >>>> > >>>> Just take a picture of the screen, that should be good enough. > >>>> > >>>> -- > >>>> Jens Axboe > >>>> > >>> > >>> Attached as requested. > >> > >> Can you see if this patch helps? > >> > >> https://marc.info/?l=linux-mmc&m=153485326025301&w=2 > >> > >> -- > >> Jens Axboe > >> > > > > I confirm that the above patch works with commit 6ce3dd6eec11 and > > removes the need for reverting it on eMMC based devices. > > > > Tested on Bay Trail, Cherry Trail (both now working) and Kaby Lake > > (not affected) devices. > > Great, thanks for testing. Adrian, when is this going upstream? It is in Ulf's fixes branch, so most likely v4.19-rc2 . Then to stable in due course. https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/commit/?h=fixes&id=26caddf274cf1e89fd4ce44ab2b8dbc7a7f97681 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" 2018-08-28 19:11 ` Hunter, Adrian @ 2018-08-29 6:15 ` Ulf Hansson 2018-08-29 14:01 ` Jens Axboe 0 siblings, 1 reply; 11+ messages in thread From: Ulf Hansson @ 2018-08-29 6:15 UTC (permalink / raw) To: Hunter, Adrian, Jens Axboe Cc: Ian W MORRISON, linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei On 28 August 2018 at 21:11, Hunter, Adrian <adrian.hunter@intel.com> wrote: >> -----Original Message----- >> From: Jens Axboe [mailto:axboe@kernel.dk] >> Sent: Tuesday, August 28, 2018 8:12 PM >> To: Ian W MORRISON <ianwmorrison@gmail.com> >> Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org; >> kashyap.desai@broadcom.com; loberman@redhat.com; osandov@fb.com; >> hch@lst.de; bart.vanassche@wdc.com; hare@suse.de; >> ming.lei@redhat.com; Hunter, Adrian <adrian.hunter@intel.com> >> Subject: Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in >> case of 'none'" >> >> On 8/28/18 11:01 AM, Ian W MORRISON wrote: >> > On Wed, 29 Aug 2018 at 02:13, Jens Axboe <axboe@kernel.dk> wrote: >> >> >> >> On 8/28/18 10:10 AM, Ian W MORRISON wrote: >> >>> On Wed, 29 Aug 2018 at 02:09, Jens Axboe <axboe@kernel.dk> wrote: >> >>>> >> >>>> On 8/28/18 10:07 AM, Ian W MORRISON wrote: >> >>>>> On Wed, 29 Aug 2018 at 01:48, Jens Axboe <axboe@kernel.dk> >> wrote: >> >>>>>> >> >>>>>> On 8/28/18 9:47 AM, Ian W MORRISON wrote: >> >>>>>>> Kernel oops when booting on Bay and Cherry Trail devices such as >> >>>>>>> Intel Compute Stick. Bisected as: >> >>>>>>> >> >>>>>>> commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't >> >>>>>>> busy in case of 'none'") >> >>>>>>> >> >>>>>>> This patch reverts the above commit. >> >>>>>> >> >>>>>> Did I miss the posting of that oops? Just curious where this is >> >>>>>> going wrong. Not adverse to reverting, but I'd like to try to >> >>>>>> understand the issue first. >> >>>>>> >> >>>>>> -- >> >>>>>> Jens Axboe >> >>>>>> >> >>>>> >> >>>>> I've not been able to capture it however manually transcribing >> >>>>> what is on the screen: >> >>>>> >> >>>>> mmc0: Got data interrupt 0x00000002 even though no data operation >> >>>>> >> >>>>> followed by: >> >>>>> >> >>>>> mmc0: sdhci: ============= SDHCI REGISTER DUMP >> ============== >> >>>>> >> >>>>> Do you want any specific register value or should I transcribe >> >>>>> each (as I am working from an image taken at boot)? >> >>>> >> >>>> Just take a picture of the screen, that should be good enough. >> >>>> >> >>>> -- >> >>>> Jens Axboe >> >>>> >> >>> >> >>> Attached as requested. >> >> >> >> Can you see if this patch helps? >> >> >> >> https://marc.info/?l=linux-mmc&m=153485326025301&w=2 >> >> >> >> -- >> >> Jens Axboe >> >> >> > >> > I confirm that the above patch works with commit 6ce3dd6eec11 and >> > removes the need for reverting it on eMMC based devices. >> > >> > Tested on Bay Trail, Cherry Trail (both now working) and Kaby Lake >> > (not affected) devices. >> >> Great, thanks for testing. Adrian, when is this going upstream? > > It is in Ulf's fixes branch, so most likely v4.19-rc2 . Then to stable in due course. > > https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/commit/?h=fixes&id=26caddf274cf1e89fd4ce44ab2b8dbc7a7f97681 Yep, correct! As I told someone before, I am deliberately holding on to fixes a little longer that before, to extend the test coverage a bit. If someone wants to test the latest rc with fixes, one could instead try the pending-fixes branch in Stephen Rothwell's linux-next tree. Kind regards Uffe ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" 2018-08-29 6:15 ` Ulf Hansson @ 2018-08-29 14:01 ` Jens Axboe 2018-08-30 12:05 ` Ulf Hansson 0 siblings, 1 reply; 11+ messages in thread From: Jens Axboe @ 2018-08-29 14:01 UTC (permalink / raw) To: Ulf Hansson, Hunter, Adrian Cc: Ian W MORRISON, linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei On 8/29/18 12:15 AM, Ulf Hansson wrote: > On 28 August 2018 at 21:11, Hunter, Adrian <adrian.hunter@intel.com> wrote: >>> -----Original Message----- >>> From: Jens Axboe [mailto:axboe@kernel.dk] >>> Sent: Tuesday, August 28, 2018 8:12 PM >>> To: Ian W MORRISON <ianwmorrison@gmail.com> >>> Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org; >>> kashyap.desai@broadcom.com; loberman@redhat.com; osandov@fb.com; >>> hch@lst.de; bart.vanassche@wdc.com; hare@suse.de; >>> ming.lei@redhat.com; Hunter, Adrian <adrian.hunter@intel.com> >>> Subject: Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in >>> case of 'none'" >>> >>> On 8/28/18 11:01 AM, Ian W MORRISON wrote: >>>> On Wed, 29 Aug 2018 at 02:13, Jens Axboe <axboe@kernel.dk> wrote: >>>>> >>>>> On 8/28/18 10:10 AM, Ian W MORRISON wrote: >>>>>> On Wed, 29 Aug 2018 at 02:09, Jens Axboe <axboe@kernel.dk> wrote: >>>>>>> >>>>>>> On 8/28/18 10:07 AM, Ian W MORRISON wrote: >>>>>>>> On Wed, 29 Aug 2018 at 01:48, Jens Axboe <axboe@kernel.dk> >>> wrote: >>>>>>>>> >>>>>>>>> On 8/28/18 9:47 AM, Ian W MORRISON wrote: >>>>>>>>>> Kernel oops when booting on Bay and Cherry Trail devices such as >>>>>>>>>> Intel Compute Stick. Bisected as: >>>>>>>>>> >>>>>>>>>> commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't >>>>>>>>>> busy in case of 'none'") >>>>>>>>>> >>>>>>>>>> This patch reverts the above commit. >>>>>>>>> >>>>>>>>> Did I miss the posting of that oops? Just curious where this is >>>>>>>>> going wrong. Not adverse to reverting, but I'd like to try to >>>>>>>>> understand the issue first. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Jens Axboe >>>>>>>>> >>>>>>>> >>>>>>>> I've not been able to capture it however manually transcribing >>>>>>>> what is on the screen: >>>>>>>> >>>>>>>> mmc0: Got data interrupt 0x00000002 even though no data operation >>>>>>>> >>>>>>>> followed by: >>>>>>>> >>>>>>>> mmc0: sdhci: ============= SDHCI REGISTER DUMP >>> ============== >>>>>>>> >>>>>>>> Do you want any specific register value or should I transcribe >>>>>>>> each (as I am working from an image taken at boot)? >>>>>>> >>>>>>> Just take a picture of the screen, that should be good enough. >>>>>>> >>>>>>> -- >>>>>>> Jens Axboe >>>>>>> >>>>>> >>>>>> Attached as requested. >>>>> >>>>> Can you see if this patch helps? >>>>> >>>>> https://marc.info/?l=linux-mmc&m=153485326025301&w=2 >>>>> >>>>> -- >>>>> Jens Axboe >>>>> >>>> >>>> I confirm that the above patch works with commit 6ce3dd6eec11 and >>>> removes the need for reverting it on eMMC based devices. >>>> >>>> Tested on Bay Trail, Cherry Trail (both now working) and Kaby Lake >>>> (not affected) devices. >>> >>> Great, thanks for testing. Adrian, when is this going upstream? >> >> It is in Ulf's fixes branch, so most likely v4.19-rc2 . Then to stable in due course. >> >> https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/commit/?h=fixes&id=26caddf274cf1e89fd4ce44ab2b8dbc7a7f97681 > > Yep, correct! > > As I told someone before, I am deliberately holding on to fixes a > little longer that before, to extend the test coverage a bit. > > If someone wants to test the latest rc with fixes, one could instead > try the pending-fixes branch in Stephen Rothwell's linux-next tree. With all due respect, you should expedite this one so we're not wasting peoples time bisecting it again and again. I didn't even know about a pending-fixes branch in the linux-next tree, so I doubt most users will. -- Jens Axboe ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" 2018-08-29 14:01 ` Jens Axboe @ 2018-08-30 12:05 ` Ulf Hansson 0 siblings, 0 replies; 11+ messages in thread From: Ulf Hansson @ 2018-08-30 12:05 UTC (permalink / raw) To: Jens Axboe Cc: Hunter, Adrian, Ian W MORRISON, linux-block, linux-kernel, kashyap.desai, loberman, osandov, hch, bart.vanassche, hare, ming.lei On 29 August 2018 at 16:01, Jens Axboe <axboe@kernel.dk> wrote: > On 8/29/18 12:15 AM, Ulf Hansson wrote: >> On 28 August 2018 at 21:11, Hunter, Adrian <adrian.hunter@intel.com> wrote: >>>> -----Original Message----- >>>> From: Jens Axboe [mailto:axboe@kernel.dk] >>>> Sent: Tuesday, August 28, 2018 8:12 PM >>>> To: Ian W MORRISON <ianwmorrison@gmail.com> >>>> Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org; >>>> kashyap.desai@broadcom.com; loberman@redhat.com; osandov@fb.com; >>>> hch@lst.de; bart.vanassche@wdc.com; hare@suse.de; >>>> ming.lei@redhat.com; Hunter, Adrian <adrian.hunter@intel.com> >>>> Subject: Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in >>>> case of 'none'" >>>> >>>> On 8/28/18 11:01 AM, Ian W MORRISON wrote: >>>>> On Wed, 29 Aug 2018 at 02:13, Jens Axboe <axboe@kernel.dk> wrote: >>>>>> >>>>>> On 8/28/18 10:10 AM, Ian W MORRISON wrote: >>>>>>> On Wed, 29 Aug 2018 at 02:09, Jens Axboe <axboe@kernel.dk> wrote: >>>>>>>> >>>>>>>> On 8/28/18 10:07 AM, Ian W MORRISON wrote: >>>>>>>>> On Wed, 29 Aug 2018 at 01:48, Jens Axboe <axboe@kernel.dk> >>>> wrote: >>>>>>>>>> >>>>>>>>>> On 8/28/18 9:47 AM, Ian W MORRISON wrote: >>>>>>>>>>> Kernel oops when booting on Bay and Cherry Trail devices such as >>>>>>>>>>> Intel Compute Stick. Bisected as: >>>>>>>>>>> >>>>>>>>>>> commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't >>>>>>>>>>> busy in case of 'none'") >>>>>>>>>>> >>>>>>>>>>> This patch reverts the above commit. >>>>>>>>>> >>>>>>>>>> Did I miss the posting of that oops? Just curious where this is >>>>>>>>>> going wrong. Not adverse to reverting, but I'd like to try to >>>>>>>>>> understand the issue first. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Jens Axboe >>>>>>>>>> >>>>>>>>> >>>>>>>>> I've not been able to capture it however manually transcribing >>>>>>>>> what is on the screen: >>>>>>>>> >>>>>>>>> mmc0: Got data interrupt 0x00000002 even though no data operation >>>>>>>>> >>>>>>>>> followed by: >>>>>>>>> >>>>>>>>> mmc0: sdhci: ============= SDHCI REGISTER DUMP >>>> ============== >>>>>>>>> >>>>>>>>> Do you want any specific register value or should I transcribe >>>>>>>>> each (as I am working from an image taken at boot)? >>>>>>>> >>>>>>>> Just take a picture of the screen, that should be good enough. >>>>>>>> >>>>>>>> -- >>>>>>>> Jens Axboe >>>>>>>> >>>>>>> >>>>>>> Attached as requested. >>>>>> >>>>>> Can you see if this patch helps? >>>>>> >>>>>> https://marc.info/?l=linux-mmc&m=153485326025301&w=2 >>>>>> >>>>>> -- >>>>>> Jens Axboe >>>>>> >>>>> >>>>> I confirm that the above patch works with commit 6ce3dd6eec11 and >>>>> removes the need for reverting it on eMMC based devices. >>>>> >>>>> Tested on Bay Trail, Cherry Trail (both now working) and Kaby Lake >>>>> (not affected) devices. >>>> >>>> Great, thanks for testing. Adrian, when is this going upstream? >>> >>> It is in Ulf's fixes branch, so most likely v4.19-rc2 . Then to stable in due course. >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/commit/?h=fixes&id=26caddf274cf1e89fd4ce44ab2b8dbc7a7f97681 >> >> Yep, correct! >> >> As I told someone before, I am deliberately holding on to fixes a >> little longer that before, to extend the test coverage a bit. >> >> If someone wants to test the latest rc with fixes, one could instead >> try the pending-fixes branch in Stephen Rothwell's linux-next tree. > > With all due respect, you should expedite this one so we're not > wasting peoples time bisecting it again and again. I didn't even > know about a pending-fixes branch in the linux-next tree, so I > doubt most users will. I guess it takes some time before people gets aware of the pending-fixes branch. At least I managed to highlight its presence in this thread. :-) PR about to be created, I keep the folkz in this thread on cc once I post it. Kind regards Uffe ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-08-30 12:05 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-08-28 15:47 [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" Ian W MORRISON 2018-08-28 15:48 ` Jens Axboe 2018-08-28 16:07 ` Ian W MORRISON 2018-08-28 16:09 ` Jens Axboe [not found] ` <CAFXWsS82zi7w81-=4ALwMiFm9iQd=NgF3sSBLfvNdU2czEzxwg@mail.gmail.com> 2018-08-28 16:13 ` Jens Axboe 2018-08-28 17:01 ` Ian W MORRISON 2018-08-28 17:12 ` Jens Axboe 2018-08-28 19:11 ` Hunter, Adrian 2018-08-29 6:15 ` Ulf Hansson 2018-08-29 14:01 ` Jens Axboe 2018-08-30 12:05 ` Ulf Hansson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).