From: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
To: Marco Elver <elver@google.com>
Cc: Nicholas Tang <nicholas.tang@mediatek.com>,
Andrew Yang <andrew.yang@mediatek.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
"Andrey Ryabinin" <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Chinwen Chang <chinwen.chang@mediatek.com>,
Andrew Morton <akpm@linux-foundation.org>,
<kasan-dev@googlegroups.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Kuan-Ying.Lee@mediatek.com>
Subject: Re: [PATCH 2/2] kasan, mm: reset tag for hex dump address
Date: Tue, 27 Jul 2021 16:54:26 +0800 [thread overview]
Message-ID: <77ecf897408ab1022bd7fd879b8708e99c479cd9.camel@mediatek.com> (raw)
In-Reply-To: <CANpmjNNOkCspsf4=gPLLw=29vtv4qEDaErB1i1sz-p+bzLxNKg@mail.gmail.com>
On Tue, 2021-07-27 at 09:20 +0200, Marco Elver wrote:
> On Tue, 27 Jul 2021 at 06:00, Kuan-Ying Lee <
> Kuan-Ying.Lee@mediatek.com> wrote:
> >
> > Text is a string. We need to move this kasan_reset_tag()
> > to address but text.
> >
> > Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
>
> This patch also makes sense (I think), thanks for sending. But it's
> unclear what the problem is. The fact that when the address is
> printed
> it still includes the tag? Or a false positive?
> It'd be good to clarify in the commit message.
Yes, printed address includes the tag, so when we access the
metadata, we will encounter tag mismatch with HW tag-based kasan
enabled.
>
> Here I'd also use a more descriptive patch title, something like
> "kasan, slub: reset tag when printing address".
>
> Also, I think this patch requires a:
>
> Fixes: aa1ef4d7b3f6 ("kasan, mm: reset tags when accessing
> metadata")
>
> So that stable kernels can pick this up if appropriate.
Thank you, Marco.
I will refine commit message in the v2.
>
> > ---
> > mm/slub.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/slub.c b/mm/slub.c
> > index 6dad2b6fda6f..d20674f839ba 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -576,8 +576,8 @@ static void print_section(char *level, char
> > *text, u8 *addr,
> > unsigned int length)
> > {
> > metadata_access_enable();
> > - print_hex_dump(level, kasan_reset_tag(text),
> > DUMP_PREFIX_ADDRESS,
> > - 16, 1, addr, length, 1);
> > + print_hex_dump(level, text, DUMP_PREFIX_ADDRESS,
> > + 16, 1, kasan_reset_tag((void *)addr),
> > length, 1);
> > metadata_access_disable();
> > }
> >
> > --
> > 2.18.0
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "kasan-dev" group.
> > To unsubscribe from this group and stop receiving emails from it,
> > send an email to kasan-dev+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit
> > https://urldefense.com/v3/__https://groups.google.com/d/msgid/kasan-dev/20210727040021.21371-3-Kuan-Ying.Lee*40mediatek.com__;JQ!!CTRNKA9wMg0ARbw!13XOuYbzPQrBvIDMNbrT7vm8RGc56Oqr402PDfQRDmHrrBsujrZUr7O9q24JeDJ_3NlWSQ$
> > .
prev parent reply other threads:[~2021-07-27 8:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 4:00 [PATCH 0/2] kasan, mm: reset tag when access metadata Kuan-Ying Lee
2021-07-27 4:00 ` [PATCH 1/2] " Kuan-Ying Lee
2021-07-27 7:10 ` Marco Elver
2021-07-27 8:32 ` Kuan-Ying Lee
2021-07-27 9:34 ` Marco Elver
2021-07-27 19:22 ` Catalin Marinas
2021-07-28 11:05 ` Kuan-Ying Lee
2021-07-28 12:43 ` Marco Elver
2021-07-30 14:57 ` Andrey Konovalov
2021-07-30 15:24 ` Catalin Marinas
2021-07-27 4:00 ` [PATCH 2/2] kasan, mm: reset tag for hex dump address Kuan-Ying Lee
2021-07-27 7:20 ` Marco Elver
2021-07-27 8:54 ` Kuan-Ying Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77ecf897408ab1022bd7fd879b8708e99c479cd9.camel@mediatek.com \
--to=kuan-ying.lee@mediatek.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.yang@mediatek.com \
--cc=andreyknvl@gmail.com \
--cc=chinwen.chang@mediatek.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=nicholas.tang@mediatek.com \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).