linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: macb: Correct the MID field length value
@ 2015-03-05 14:02 Michal Simek
  2015-03-06  3:19 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2015-03-05 14:02 UTC (permalink / raw)
  To: linux-kernel, monstr
  Cc: Zach Pfeffer, Punnaiah Choudary Kalluri, Nicolas Ferre, netdev

From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>

The latest spec "I-IPA01-0266-USR Rev 10" limit the MID field length to 12 bit
value. For previous versions it is 16 bit value.

This change will not break the backward compatibility as the latest ID value is
7 and with in the 12 bit value limit.

Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/net/ethernet/cadence/macb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
index 57f0a1a7415d..6cfff0b04d05 100644
--- a/drivers/net/ethernet/cadence/macb.h
+++ b/drivers/net/ethernet/cadence/macb.h
@@ -352,7 +352,7 @@
 
 /* Bitfields in MID */
 #define MACB_IDNUM_OFFSET			16
-#define MACB_IDNUM_SIZE				16
+#define MACB_IDNUM_SIZE				12
 #define MACB_REV_OFFSET				0
 #define MACB_REV_SIZE				16
 
-- 
1.8.2.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: macb: Correct the MID field length value
  2015-03-05 14:02 [PATCH] net: macb: Correct the MID field length value Michal Simek
@ 2015-03-06  3:19 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-03-06  3:19 UTC (permalink / raw)
  To: michal.simek
  Cc: linux-kernel, monstr, zachp, punnaiah.choudary.kalluri,
	nicolas.ferre, netdev

From: Michal Simek <michal.simek@xilinx.com>
Date: Thu,  5 Mar 2015 15:02:10 +0100

> From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>
> 
> The latest spec "I-IPA01-0266-USR Rev 10" limit the MID field length to 12 bit
> value. For previous versions it is 16 bit value.
> 
> This change will not break the backward compatibility as the latest ID value is
> 7 and with in the 12 bit value limit.
> 
> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-06  3:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05 14:02 [PATCH] net: macb: Correct the MID field length value Michal Simek
2015-03-06  3:19 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).