* [PATCH] drm/amd/display: fix a compile warning
@ 2018-08-17 3:09 Wen Yang
2018-08-17 18:46 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Wen Yang @ 2018-08-17 3:09 UTC (permalink / raw)
To: airlied
Cc: alexander.deucher, christian.koenig, David1.Zhou, amd-gfx,
dri-devel, linux-kernel, wen.yang99, jiang.biao2, zhong.weidong
Fix comile warning like,
CC [M] drivers/gpu/drm/i915/gvt/execlist.o
CC [M] drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.o
CC [M] drivers/gpu/drm/radeon/btc_dpm.o
CC [M] drivers/isdn/hisax/avm_a1p.o
CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_dpp.o
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function ‘dcn10_update_mpcc’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1903:9: warning: missing braces around initializer [-Wmissing-braces]
struct mpcc_blnd_cfg blnd_cfg = {0};
^
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1903:9: warning: (near initialization for ‘blnd_cfg.black_color’) [-Wmissing-braces]
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index cfcc54f..a06a035 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -1900,7 +1900,7 @@ static void update_dpp(struct dpp *dpp, struct dc_plane_state *plane_state)
static void dcn10_update_mpcc(struct dc *dc, struct pipe_ctx *pipe_ctx)
{
struct hubp *hubp = pipe_ctx->plane_res.hubp;
- struct mpcc_blnd_cfg blnd_cfg = {0};
+ struct mpcc_blnd_cfg blnd_cfg = {{0}};
bool per_pixel_alpha = pipe_ctx->plane_state->per_pixel_alpha && pipe_ctx->bottom_pipe;
int mpcc_id;
struct mpcc *new_mpcc;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: fix a compile warning
2018-08-17 3:09 [PATCH] drm/amd/display: fix a compile warning Wen Yang
@ 2018-08-17 18:46 ` Randy Dunlap
2018-08-21 18:03 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2018-08-17 18:46 UTC (permalink / raw)
To: Wen Yang, airlied
Cc: alexander.deucher, christian.koenig, David1.Zhou, amd-gfx,
dri-devel, linux-kernel, jiang.biao2, zhong.weidong
On 08/16/2018 08:09 PM, Wen Yang wrote:
> Fix comile warning like,
> CC [M] drivers/gpu/drm/i915/gvt/execlist.o
> CC [M] drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.o
> CC [M] drivers/gpu/drm/radeon/btc_dpm.o
> CC [M] drivers/isdn/hisax/avm_a1p.o
> CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_dpp.o
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function ‘dcn10_update_mpcc’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1903:9: warning: missing braces around initializer [-Wmissing-braces]
> struct mpcc_blnd_cfg blnd_cfg = {0};
> ^
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1903:9: warning: (near initialization for ‘blnd_cfg.black_color’) [-Wmissing-braces]
>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index cfcc54f..a06a035 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -1900,7 +1900,7 @@ static void update_dpp(struct dpp *dpp, struct dc_plane_state *plane_state)
> static void dcn10_update_mpcc(struct dc *dc, struct pipe_ctx *pipe_ctx)
> {
> struct hubp *hubp = pipe_ctx->plane_res.hubp;
> - struct mpcc_blnd_cfg blnd_cfg = {0};
> + struct mpcc_blnd_cfg blnd_cfg = {{0}};
> bool per_pixel_alpha = pipe_ctx->plane_state->per_pixel_alpha && pipe_ctx->bottom_pipe;
> int mpcc_id;
> struct mpcc *new_mpcc;
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: fix a compile warning
2018-08-17 18:46 ` Randy Dunlap
@ 2018-08-21 18:03 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2018-08-21 18:03 UTC (permalink / raw)
To: Randy Dunlap
Cc: wen.yang99, Dave Airlie, Chunming Zhou, zhong.weidong, LKML,
Maling list - DRI developers, amd-gfx list, Deucher, Alexander,
jiang.biao2, Christian Koenig
On Fri, Aug 17, 2018 at 3:01 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 08/16/2018 08:09 PM, Wen Yang wrote:
> > Fix comile warning like,
> > CC [M] drivers/gpu/drm/i915/gvt/execlist.o
> > CC [M] drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.o
> > CC [M] drivers/gpu/drm/radeon/btc_dpm.o
> > CC [M] drivers/isdn/hisax/avm_a1p.o
> > CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_dpp.o
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function ‘dcn10_update_mpcc’:
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1903:9: warning: missing braces around initializer [-Wmissing-braces]
> > struct mpcc_blnd_cfg blnd_cfg = {0};
> > ^
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1903:9: warning: (near initialization for ‘blnd_cfg.black_color’) [-Wmissing-braces]
> >
> > Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> > Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
>
> works for me. Thanks.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
Applied. thanks!
Alex
>
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > index cfcc54f..a06a035 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > @@ -1900,7 +1900,7 @@ static void update_dpp(struct dpp *dpp, struct dc_plane_state *plane_state)
> > static void dcn10_update_mpcc(struct dc *dc, struct pipe_ctx *pipe_ctx)
> > {
> > struct hubp *hubp = pipe_ctx->plane_res.hubp;
> > - struct mpcc_blnd_cfg blnd_cfg = {0};
> > + struct mpcc_blnd_cfg blnd_cfg = {{0}};
> > bool per_pixel_alpha = pipe_ctx->plane_state->per_pixel_alpha && pipe_ctx->bottom_pipe;
> > int mpcc_id;
> > struct mpcc *new_mpcc;
> >
>
>
> --
> ~Randy
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-21 18:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-17 3:09 [PATCH] drm/amd/display: fix a compile warning Wen Yang
2018-08-17 18:46 ` Randy Dunlap
2018-08-21 18:03 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).