* Re: [PATCH v2] media: coda: Fix runtime PM imbalance in coda_probe()
@ 2020-05-25 15:15 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-25 15:15 UTC (permalink / raw)
To: Dinghao Liu, linux-media
Cc: linux-kernel, Kangjie Lu, Mauro Carvalho Chehab, Philipp Zabel
> When coda_firmware_request() returns an error code,
> a pairing runtime PM usage counter decrement is needed
> to keep the counter balanced.
* I suggest to add an imperative wording.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=9cb1fd0efd195590b828b9b865421ad345a4a145#n151
* Would you like to add the tag “Fixes” to the commit message?
> Changelog:
I propose to omit this line.
> ---
> drivers/media/platform/coda/coda-common.c | 2 ++
I find it nicer to replace the triple dashes before this diffstat
by a blank line.
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-25 15:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25 15:15 [PATCH v2] media: coda: Fix runtime PM imbalance in coda_probe() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).