linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/slub: remove duplicate flag in allocate_slab()
@ 2022-04-09 15:05 Jiyoup Kim
  2022-04-10  7:42 ` Hyeonggon Yoo
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Jiyoup Kim @ 2022-04-09 15:05 UTC (permalink / raw)
  To: Christoph Lameter, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Andrew Morton, Vlastimil Babka
  Cc: Ohhoon Kwon, JaeSang Yoo, Wonhyuk Yang, Jiyoup Kim,
	Donghyeok Kim, linux-mm, linux-kernel

In allocate_slab(), __GFP_NOFAIL flag is removed twice when trying
higher-order allocation. Remove it.

Signed-off-by: Jiyoup Kim <lakroforce@gmail.com>
---
 mm/slub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slub.c b/mm/slub.c
index 74d92aa4a3a2..a0e605ab3036 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1939,7 +1939,7 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
 	 */
 	alloc_gfp = (flags | __GFP_NOWARN | __GFP_NORETRY) & ~__GFP_NOFAIL;
 	if ((alloc_gfp & __GFP_DIRECT_RECLAIM) && oo_order(oo) > oo_order(s->min))
-		alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~(__GFP_RECLAIM|__GFP_NOFAIL);
+		alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~__GFP_RECLAIM;
 
 	slab = alloc_slab_page(alloc_gfp, node, oo);
 	if (unlikely(!slab)) {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] mm/slub: remove duplicate flag in allocate_slab()
  2022-04-09 15:05 [PATCH] mm/slub: remove duplicate flag in allocate_slab() Jiyoup Kim
@ 2022-04-10  7:42 ` Hyeonggon Yoo
  2022-04-11  4:00 ` Muchun Song
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Hyeonggon Yoo @ 2022-04-10  7:42 UTC (permalink / raw)
  To: Jiyoup Kim
  Cc: Christoph Lameter, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Andrew Morton, Vlastimil Babka, Ohhoon Kwon, JaeSang Yoo,
	Wonhyuk Yang, Donghyeok Kim, linux-mm, linux-kernel

On Sun, Apr 10, 2022 at 12:05:37AM +0900, Jiyoup Kim wrote:
> In allocate_slab(), __GFP_NOFAIL flag is removed twice when trying
> higher-order allocation. Remove it.
> 
> Signed-off-by: Jiyoup Kim <lakroforce@gmail.com>
> ---
>  mm/slub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 74d92aa4a3a2..a0e605ab3036 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1939,7 +1939,7 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
>  	 */
>  	alloc_gfp = (flags | __GFP_NOWARN | __GFP_NORETRY) & ~__GFP_NOFAIL;
>  	if ((alloc_gfp & __GFP_DIRECT_RECLAIM) && oo_order(oo) > oo_order(s->min))
> -		alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~(__GFP_RECLAIM|__GFP_NOFAIL);
> +		alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~__GFP_RECLAIM;
>  
>  	slab = alloc_slab_page(alloc_gfp, node, oo);
>  	if (unlikely(!slab)) {

Looks good to me.

Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>

Thanks!

> -- 
> 2.25.1
> 
> 

-- 
Thanks,
Hyeonggon

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] mm/slub: remove duplicate flag in allocate_slab()
  2022-04-09 15:05 [PATCH] mm/slub: remove duplicate flag in allocate_slab() Jiyoup Kim
  2022-04-10  7:42 ` Hyeonggon Yoo
@ 2022-04-11  4:00 ` Muchun Song
  2022-04-11 10:32 ` Vlastimil Babka
  2022-04-12 23:36 ` David Rientjes
  3 siblings, 0 replies; 5+ messages in thread
From: Muchun Song @ 2022-04-11  4:00 UTC (permalink / raw)
  To: Jiyoup Kim
  Cc: Christoph Lameter, Pekka Enberg, David Rientjes, Joonsoo Kim,
	Andrew Morton, Vlastimil Babka, Ohhoon Kwon, JaeSang Yoo,
	Wonhyuk Yang, Donghyeok Kim, linux-mm, linux-kernel

On Sun, Apr 10, 2022 at 12:05:37AM +0900, Jiyoup Kim wrote:
> In allocate_slab(), __GFP_NOFAIL flag is removed twice when trying
> higher-order allocation. Remove it.
> 
> Signed-off-by: Jiyoup Kim <lakroforce@gmail.com>

LGTM.

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] mm/slub: remove duplicate flag in allocate_slab()
  2022-04-09 15:05 [PATCH] mm/slub: remove duplicate flag in allocate_slab() Jiyoup Kim
  2022-04-10  7:42 ` Hyeonggon Yoo
  2022-04-11  4:00 ` Muchun Song
@ 2022-04-11 10:32 ` Vlastimil Babka
  2022-04-12 23:36 ` David Rientjes
  3 siblings, 0 replies; 5+ messages in thread
From: Vlastimil Babka @ 2022-04-11 10:32 UTC (permalink / raw)
  To: Jiyoup Kim, Christoph Lameter, Pekka Enberg, David Rientjes,
	Joonsoo Kim, Andrew Morton
  Cc: Ohhoon Kwon, JaeSang Yoo, Wonhyuk Yang, Donghyeok Kim, linux-mm,
	linux-kernel

On 4/9/22 17:05, Jiyoup Kim wrote:
> In allocate_slab(), __GFP_NOFAIL flag is removed twice when trying
> higher-order allocation. Remove it.
> 
> Signed-off-by: Jiyoup Kim <lakroforce@gmail.com>

Thanks, added.

> ---
>  mm/slub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 74d92aa4a3a2..a0e605ab3036 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1939,7 +1939,7 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
>  	 */
>  	alloc_gfp = (flags | __GFP_NOWARN | __GFP_NORETRY) & ~__GFP_NOFAIL;
>  	if ((alloc_gfp & __GFP_DIRECT_RECLAIM) && oo_order(oo) > oo_order(s->min))
> -		alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~(__GFP_RECLAIM|__GFP_NOFAIL);
> +		alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~__GFP_RECLAIM;
>  
>  	slab = alloc_slab_page(alloc_gfp, node, oo);
>  	if (unlikely(!slab)) {


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] mm/slub: remove duplicate flag in allocate_slab()
  2022-04-09 15:05 [PATCH] mm/slub: remove duplicate flag in allocate_slab() Jiyoup Kim
                   ` (2 preceding siblings ...)
  2022-04-11 10:32 ` Vlastimil Babka
@ 2022-04-12 23:36 ` David Rientjes
  3 siblings, 0 replies; 5+ messages in thread
From: David Rientjes @ 2022-04-12 23:36 UTC (permalink / raw)
  To: Jiyoup Kim
  Cc: Christoph Lameter, Pekka Enberg, Joonsoo Kim, Andrew Morton,
	Vlastimil Babka, Ohhoon Kwon, JaeSang Yoo, Wonhyuk Yang,
	Donghyeok Kim, linux-mm, linux-kernel

On Sun, 10 Apr 2022, Jiyoup Kim wrote:

> In allocate_slab(), __GFP_NOFAIL flag is removed twice when trying
> higher-order allocation. Remove it.
> 
> Signed-off-by: Jiyoup Kim <lakroforce@gmail.com>

Acked-by: David Rientjes <rientjes@google.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-12 23:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-09 15:05 [PATCH] mm/slub: remove duplicate flag in allocate_slab() Jiyoup Kim
2022-04-10  7:42 ` Hyeonggon Yoo
2022-04-11  4:00 ` Muchun Song
2022-04-11 10:32 ` Vlastimil Babka
2022-04-12 23:36 ` David Rientjes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).