* [PATCH] gpio: mcp23s08: Use seq_putc() in mcp23s08_dbg_show()
@ 2017-05-08 10:50 SF Markus Elfring
2017-05-11 14:33 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-05-08 10:50 UTC (permalink / raw)
To: linux-gpio, Alexandre Courbot, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 12:44:36 +0200
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpio/gpio-mcp23s08.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
index 2a57d024481d..51dff7e95a9e 100644
--- a/drivers/gpio/gpio-mcp23s08.c
+++ b/drivers/gpio/gpio-mcp23s08.c
@@ -519,7 +519,7 @@ static void mcp23s08_dbg_show(struct seq_file *s, struct gpio_chip *chip)
(mcp->cache[MCP_GPIO] & mask) ? "hi" : "lo",
(mcp->cache[MCP_GPPU] & mask) ? "up" : " ");
/* NOTE: ignoring the irq-related registers */
- seq_puts(s, "\n");
+ seq_putc(s, '\n');
}
done:
mutex_unlock(&mcp->lock);
--
2.12.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: mcp23s08: Use seq_putc() in mcp23s08_dbg_show()
2017-05-08 10:50 [PATCH] gpio: mcp23s08: Use seq_putc() in mcp23s08_dbg_show() SF Markus Elfring
@ 2017-05-11 14:33 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2017-05-11 14:33 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, Alexandre Courbot, LKML, kernel-janitors
On Mon, May 8, 2017 at 12:50 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 8 May 2017 12:44:36 +0200
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
I can't change stuff around this driver right now as it is being
rewritten.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-11 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-08 10:50 [PATCH] gpio: mcp23s08: Use seq_putc() in mcp23s08_dbg_show() SF Markus Elfring
2017-05-11 14:33 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).