* [PATCH] usb: remove redundant 'default n' from Kconfig-s
[not found] <CGME20190520141434eucas1p266520a2ef8db42b3deee004e1cba3a1f@eucas1p2.samsung.com>
@ 2019-05-20 14:14 ` Bartlomiej Zolnierkiewicz
2019-06-18 7:29 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-05-20 14:14 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Felipe Balbi, Minas Harutyunyan, linux-kernel, linux-usb
'default n' is the default value for any bool or tristate Kconfig
setting so there is no need to write it explicitly.
Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
is not set' for visible symbols") the Kconfig behavior is the same
regardless of 'default n' being present or not:
...
One side effect of (and the main motivation for) this change is making
the following two definitions behave exactly the same:
config FOO
bool
config FOO
bool
default n
With this change, neither of these will generate a
'# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
That might make it clearer to people that a bare 'default n' is
redundant.
...
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/usb/atm/Kconfig | 1 -
drivers/usb/core/Kconfig | 1 -
drivers/usb/dwc2/Kconfig | 1 -
drivers/usb/gadget/legacy/Kconfig | 2 --
drivers/usb/host/Kconfig | 5 -----
drivers/usb/renesas_usbhs/Kconfig | 1 -
6 files changed, 11 deletions(-)
Index: b/drivers/usb/atm/Kconfig
===================================================================
--- a/drivers/usb/atm/Kconfig
+++ b/drivers/usb/atm/Kconfig
@@ -7,7 +7,6 @@ menuconfig USB_ATM
tristate "USB DSL modem support"
depends on ATM
select CRC32
- default n
help
Say Y here if you want to connect a USB Digital Subscriber Line (DSL)
modem to your computer's USB port. You will then need to choose your
Index: b/drivers/usb/core/Kconfig
===================================================================
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -45,7 +45,6 @@ config USB_DYNAMIC_MINORS
config USB_OTG
bool "OTG support"
depends on PM
- default n
help
The most notable feature of USB OTG is support for a
"Dual-Role" device, which can act as either a device
Index: b/drivers/usb/dwc2/Kconfig
===================================================================
--- a/drivers/usb/dwc2/Kconfig
+++ b/drivers/usb/dwc2/Kconfig
@@ -58,7 +58,6 @@ config USB_DWC2_PCI
tristate "DWC2 PCI"
depends on USB_PCI
depends on USB_GADGET || !USB_GADGET
- default n
select NOP_USB_XCEIV
help
The Designware USB2.0 PCI interface module for controllers
Index: b/drivers/usb/gadget/legacy/Kconfig
===================================================================
--- a/drivers/usb/gadget/legacy/Kconfig
+++ b/drivers/usb/gadget/legacy/Kconfig
@@ -153,7 +153,6 @@ config USB_ETH_EEM
depends on USB_ETH
select USB_LIBCOMPOSITE
select USB_F_EEM
- default n
help
CDC EEM is a newer USB standard that is somewhat simpler than CDC ECM
and therefore can be supported by more hardware. Technically ECM and
@@ -419,7 +418,6 @@ config USB_G_MULTI_RNDIS
config USB_G_MULTI_CDC
bool "CDC Ethernet + CDC Serial + Storage configuration"
depends on USB_G_MULTI
- default n
select USB_F_ECM
help
This option enables a configuration with CDC Ethernet (ECM), CDC
Index: b/drivers/usb/host/Kconfig
===================================================================
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -161,7 +161,6 @@ config USB_EHCI_PCI
config USB_EHCI_HCD_PMC_MSP
tristate "EHCI support for on-chip PMC MSP71xx USB controller"
depends on MSP_HAS_USB
- default n
select USB_EHCI_BIG_ENDIAN_DESC
select USB_EHCI_BIG_ENDIAN_MMIO
---help---
@@ -308,7 +307,6 @@ config USB_CNS3XXX_EHCI
config USB_EHCI_HCD_PLATFORM
tristate "Generic EHCI driver for a platform device"
- default n
---help---
Adds an EHCI host driver for a generic platform device, which
provides a memory space and an irq.
@@ -318,7 +316,6 @@ config USB_EHCI_HCD_PLATFORM
config USB_OCTEON_EHCI
bool "Octeon on-chip EHCI support (DEPRECATED)"
depends on CAVIUM_OCTEON_SOC
- default n
select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
select USB_EHCI_HCD_PLATFORM
help
@@ -526,7 +523,6 @@ config USB_OHCI_HCD_SSB
depends on (SSB = y || SSB = USB_OHCI_HCD)
select USB_HCD_SSB
select USB_OHCI_HCD_PLATFORM
- default n
---help---
This option is deprecated now and the driver was removed, use
USB_HCD_SSB and USB_OHCI_HCD_PLATFORM instead.
@@ -569,7 +565,6 @@ config USB_CNS3XXX_OHCI
config USB_OHCI_HCD_PLATFORM
tristate "Generic OHCI driver for a platform device"
- default n
---help---
Adds an OHCI host driver for a generic platform device, which
provides a memory space and an irq.
Index: b/drivers/usb/renesas_usbhs/Kconfig
===================================================================
--- a/drivers/usb/renesas_usbhs/Kconfig
+++ b/drivers/usb/renesas_usbhs/Kconfig
@@ -8,7 +8,6 @@ config USB_RENESAS_USBHS
depends on USB_GADGET
depends on ARCH_RENESAS || SUPERH || COMPILE_TEST
depends on EXTCON || !EXTCON # if EXTCON=m, USBHS cannot be built-in
- default n
help
Renesas USBHS is a discrete USB host and peripheral controller chip
that supports both full and high speed USB 2.0 data transfers.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: remove redundant 'default n' from Kconfig-s
2019-05-20 14:14 ` [PATCH] usb: remove redundant 'default n' from Kconfig-s Bartlomiej Zolnierkiewicz
@ 2019-06-18 7:29 ` Felipe Balbi
2019-06-20 12:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2019-06-18 7:29 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Greg Kroah-Hartman
Cc: Minas Harutyunyan, linux-kernel, linux-usb
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> writes:
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
>
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
>
> ...
> One side effect of (and the main motivation for) this change is making
> the following two definitions behave exactly the same:
>
> config FOO
> bool
>
> config FOO
> bool
> default n
>
> With this change, neither of these will generate a
> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> That might make it clearer to people that a bare 'default n' is
> redundant.
> ...
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Fine by me. Greg if you want to take this directly (since it touches
things all over the place):
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
If you prefer that I put this in my pull request to you, just let me know.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: remove redundant 'default n' from Kconfig-s
2019-06-18 7:29 ` Felipe Balbi
@ 2019-06-20 12:08 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-20 12:08 UTC (permalink / raw)
To: Felipe Balbi
Cc: Bartlomiej Zolnierkiewicz, Minas Harutyunyan, linux-kernel, linux-usb
On Tue, Jun 18, 2019 at 10:29:58AM +0300, Felipe Balbi wrote:
> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> writes:
>
> > 'default n' is the default value for any bool or tristate Kconfig
> > setting so there is no need to write it explicitly.
> >
> > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> > is not set' for visible symbols") the Kconfig behavior is the same
> > regardless of 'default n' being present or not:
> >
> > ...
> > One side effect of (and the main motivation for) this change is making
> > the following two definitions behave exactly the same:
> >
> > config FOO
> > bool
> >
> > config FOO
> > bool
> > default n
> >
> > With this change, neither of these will generate a
> > '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> > That might make it clearer to people that a bare 'default n' is
> > redundant.
> > ...
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> Fine by me. Greg if you want to take this directly (since it touches
> things all over the place):
>
> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>
> If you prefer that I put this in my pull request to you, just let me know.
I think I already took this :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-20 12:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190520141434eucas1p266520a2ef8db42b3deee004e1cba3a1f@eucas1p2.samsung.com>
2019-05-20 14:14 ` [PATCH] usb: remove redundant 'default n' from Kconfig-s Bartlomiej Zolnierkiewicz
2019-06-18 7:29 ` Felipe Balbi
2019-06-20 12:08 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).