Re: [PATCH] ubifs: limit the number of pages in shrink_liability

* Re: [PATCH] ubifs: limit the number of pages in shrink_liability
       [not found] <20190806142140.33013-1-fishland@aliyun.com>
@ 2019-08-06 14:31 ` Richard Weinberger
  0 siblings, 0 replies; only message in thread
From: Richard Weinberger @ 2019-08-06 14:31 UTC (permalink / raw)
  To: Liu Song
  Cc: Artem Bityutskiy, Adrian Hunter, linux-mtd, linux-kernel, liu song11

----- Ursprüngliche Mail -----
> Von: "Liu Song" <fishland@aliyun.com>
> An: "richard" <richard@nod.at>, "Artem Bityutskiy" <dedekind1@gmail.com>, "Adrian Hunter" <adrian.hunter@intel.com>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "liu song11"
> <liu.song11@zte.com.cn>
> Gesendet: Dienstag, 6. August 2019 16:21:40
> Betreff: [PATCH] ubifs: limit the number of pages in shrink_liability

> From: Liu Song <liu.song11@zte.com.cn>
> 
> If the number of dirty pages to be written back is large,
> then writeback_inodes_sb will block waiting for a long time,
> causing hung task detection alarm. Therefore, we should limit
> the maximum number of pages written back this time, which let
> the budget be completed faster. The remaining dirty pages
> tend to rely on the writeback mechanism to complete the
> synchronization.

On which kind of system do you hit this?
Your fix makes sense but I'd like to have more background information.

UBIFS acts that way for almost a decade, see:
b6e51316daed ("writeback: separate starting of sync vs opportunistic writeback")

Thanks,
//richard

^ permalink raw reply	[flat|nested] only message in thread