From: David Hildenbrand <david@redhat.com>
To: Zou Wei <zou_wei@huawei.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mm, page_alloc: Fix old-style function definition
Date: Fri, 30 Oct 2020 12:39:21 +0100 [thread overview]
Message-ID: <79d7b9ee-6e0a-182c-bb44-d00382c2d5d0@redhat.com> (raw)
In-Reply-To: <1603870368-104763-1-git-send-email-zou_wei@huawei.com>
On 28.10.20 08:32, Zou Wei wrote:
> Fix warning:
>
> mm/page_alloc.c:763:6: warning: old-style function definition [-Wold-style-definition]
> void init_mem_debugging()
> ^~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index f80dc59..470b18d 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -760,7 +760,7 @@ static inline void clear_page_guard(struct zone *zone, struct page *page,
> * order of appearance. So we need to first gather the full picture of what was
> * enabled, and then make decisions.
> */
> -void init_mem_debugging()
> +void init_mem_debugging(void)
> {
> if (_init_on_alloc_enabled_early) {
> if (page_poisoning_enabled()) {
>
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2020-10-30 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 7:32 [PATCH -next] mm, page_alloc: Fix old-style function definition Zou Wei
2020-10-30 11:39 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79d7b9ee-6e0a-182c-bb44-d00382c2d5d0@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).