* [PATCH -next] mm, page_alloc: Fix old-style function definition
@ 2020-10-28 7:32 Zou Wei
2020-10-30 11:39 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2020-10-28 7:32 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, Zou Wei
Fix warning:
mm/page_alloc.c:763:6: warning: old-style function definition [-Wold-style-definition]
void init_mem_debugging()
^~~~~~~~~~~~~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index f80dc59..470b18d 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -760,7 +760,7 @@ static inline void clear_page_guard(struct zone *zone, struct page *page,
* order of appearance. So we need to first gather the full picture of what was
* enabled, and then make decisions.
*/
-void init_mem_debugging()
+void init_mem_debugging(void)
{
if (_init_on_alloc_enabled_early) {
if (page_poisoning_enabled()) {
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mm, page_alloc: Fix old-style function definition
2020-10-28 7:32 [PATCH -next] mm, page_alloc: Fix old-style function definition Zou Wei
@ 2020-10-30 11:39 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2020-10-30 11:39 UTC (permalink / raw)
To: Zou Wei, akpm; +Cc: linux-mm, linux-kernel
On 28.10.20 08:32, Zou Wei wrote:
> Fix warning:
>
> mm/page_alloc.c:763:6: warning: old-style function definition [-Wold-style-definition]
> void init_mem_debugging()
> ^~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index f80dc59..470b18d 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -760,7 +760,7 @@ static inline void clear_page_guard(struct zone *zone, struct page *page,
> * order of appearance. So we need to first gather the full picture of what was
> * enabled, and then make decisions.
> */
> -void init_mem_debugging()
> +void init_mem_debugging(void)
> {
> if (_init_on_alloc_enabled_early) {
> if (page_poisoning_enabled()) {
>
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-30 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 7:32 [PATCH -next] mm, page_alloc: Fix old-style function definition Zou Wei
2020-10-30 11:39 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).