From: Bean Huo <huobean@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: rric@kernel.org, Linus Walleij <linus.walleij@linaro.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Bean Huo (beanhuo)" <beanhuo@micron.com>,
"# 4.0+" <stable@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] mmc: cavium: Remove redundant if-statement checkup
Date: Fri, 19 Mar 2021 16:42:37 +0100 [thread overview]
Message-ID: <79ec60974875d4ac17589ea4575e36ec1204f881.camel@gmail.com> (raw)
In-Reply-To: <CAPDyKFrU591aeH5GyuuQW8tPeNc9wav=t8wqF1EdTBbCc9xheg@mail.gmail.com>
On Fri, 2021-03-19 at 15:09 +0100, Ulf Hansson wrote:
> On Fri, 19 Mar 2021 at 13:14, Bean Huo <huobean@gmail.com> wrote:
>
> > From: Bean Huo <beanhuo@micron.com>
> > Currently, we have two ways to issue multiple-block read/write the
> > command to the eMMC. One is by normal IO request path fs->block-
> > >mmc.
> > Another one is that we can issue multiple-block read/write through
> > MMC ioctl interface. For the first path, mrq->stop, and mrq->stop-
> > >opcode
> > will be initialized in mmc_blk_data_prep(). However, for the second
> > IO
> > path, mrq->stop is not initialized since it is a pre-defined
> > multiple
> > blocks read/write.
>
>
> As a matter of fact this way is also supported for the regular block
>
> I/O path. To make the mmc block driver to use it, mmc host drivers
>
> need to announce that it's supported by setting MMC_CAP_CMD23.
>
>
>
> It looks like that is what your patch should be targeted towards, can
>
> you have a look at this instead?
>
>
Hi Ulf,
Thanks for your comments. I will look at that as your suggestion.
The patch [1/2] is accepted, so I will just update this patch to
the next version.
Kind regards,
Bean
>
> Kind regards
>
> Uffe
next prev parent reply other threads:[~2021-03-19 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 12:13 [PATCH v1 0/2] wo minor changes for Cavium MMC host driver Bean Huo
2021-03-19 12:13 ` [PATCH v1 1/2] mmc: cavium: Use '"%s...", __func__' to print function name Bean Huo
2021-03-19 14:12 ` Ulf Hansson
2021-03-19 12:13 ` [PATCH v1 2/2] mmc: cavium: Remove redundant if-statement checkup Bean Huo
2021-03-19 14:09 ` Ulf Hansson
2021-03-19 15:42 ` Bean Huo [this message]
2021-04-29 20:30 ` Bean Huo
2021-05-10 14:01 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79ec60974875d4ac17589ea4575e36ec1204f881.camel@gmail.com \
--to=huobean@gmail.com \
--cc=beanhuo@micron.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rric@kernel.org \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).