From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 5/5] perf report: Show branch type in callchain entry
Date: Wed, 19 Apr 2017 08:32:27 +0800 [thread overview]
Message-ID: <79f0c49a-5f63-5ed7-bb37-fe5f0c0af1e1@linux.intel.com> (raw)
In-Reply-To: <20170418185323.GB15584@krava>
On 4/19/2017 2:53 AM, Jiri Olsa wrote:
> On Wed, Apr 12, 2017 at 06:21:06AM +0800, Jin Yao wrote:
>
> SNIP
>
>> static int counts_str_build(char *bf, int bfsize,
>> u64 branch_count, u64 predicted_count,
>> u64 abort_count, u64 cycles_count,
>> - u64 iter_count, u64 samples_count)
>> + u64 iter_count, u64 samples_count,
>> + struct branch_type_stat *brtype_stat)
>> {
>> - double predicted_percent = 0.0;
>> - const char *null_str = "";
>> - char iter_str[32];
>> - char cycle_str[32];
>> - char *istr, *cstr;
>> u64 cycles;
>> + int printed, i = 0;
>>
>> if (branch_count == 0)
>> return scnprintf(bf, bfsize, " (calltrace)");
>>
>> + printed = branch_type_str(brtype_stat, bf, bfsize);
>> + if (printed)
>> + i++;
>> +
>> cycles = cycles_count / branch_count;
>> + if (cycles) {
>> + if (i++)
>> + printed += scnprintf(bf + printed, bfsize - printed,
>> + " cycles:%" PRId64 "", cycles);
>> + else
>> + printed += scnprintf(bf + printed, bfsize - printed,
>> + " (cycles:%" PRId64 "", cycles);
>> + }
>>
>> if (iter_count && samples_count) {
>> - if (cycles > 0)
>> - scnprintf(iter_str, sizeof(iter_str),
>> - " iterations:%" PRId64 "",
>> - iter_count / samples_count);
>> + if (i++)
>> + printed += scnprintf(bf + printed, bfsize - printed,
>> + " iterations:%" PRId64 "",
>> + iter_count / samples_count);
>> else
>> - scnprintf(iter_str, sizeof(iter_str),
>> - "iterations:%" PRId64 "",
>> - iter_count / samples_count);
>> - istr = iter_str;
> could you please put the change from using iter_str
> to bf into separate patch before the actual branch
> display change?
>
> it's hard to see if anything is broken ;-)
>
> thanks,
> jirka
Got it, I will separate the patches.
Thanks
Jin Yao
next prev parent reply other threads:[~2017-04-19 0:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 22:21 [PATCH v4 0/5] perf report: Show branch type Jin Yao
2017-04-11 22:21 ` [PATCH v4 1/5] perf/core: Define the common branch type classification Jin Yao
2017-04-11 22:21 ` [PATCH v4 2/5] perf/x86/intel: Record branch type Jin Yao
2017-04-11 22:21 ` [PATCH v4 3/5] perf record: Create a new option save_type in --branch-filter Jin Yao
2017-04-11 22:21 ` [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode Jin Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:53 ` Jin, Yao
2017-04-19 4:11 ` Jin, Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:41 ` Jin, Yao
2017-04-11 22:21 ` [PATCH v4 5/5] perf report: Show branch type in callchain entry Jin Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:33 ` Jin, Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:32 ` Jin, Yao [this message]
2017-04-12 10:58 ` [PATCH v4 0/5] perf report: Show branch type Jiri Olsa
2017-04-12 12:25 ` Jin, Yao
2017-04-12 14:26 ` Jiri Olsa
2017-04-12 15:42 ` Jin, Yao
2017-04-12 15:46 ` Jiri Olsa
2017-04-13 2:00 ` Jin, Yao
2017-04-13 3:25 ` Jin, Yao
2017-04-13 8:26 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79f0c49a-5f63-5ed7-bb37-fe5f0c0af1e1@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).