From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 5/5] perf report: Show branch type in callchain entry
Date: Wed, 19 Apr 2017 08:33:56 +0800 [thread overview]
Message-ID: <c26d35d6-cfa9-3735-363c-05e5be981082@linux.intel.com> (raw)
In-Reply-To: <20170418185314.GA15584@krava>
On 4/19/2017 2:53 AM, Jiri Olsa wrote:
> On Wed, Apr 12, 2017 at 06:21:06AM +0800, Jin Yao wrote:
>
> SNIP
>
>> +static int branch_type_str(struct branch_type_stat *stat,
>> + char *bf, int bfsize)
>> +{
>> + int i, j = 0, printed = 0;
>> + u64 total = 0;
>> +
>> + for (i = 0; i < PERF_BR_MAX; i++)
>> + total += stat->counts[i];
>> +
>> + if (total == 0)
>> + return 0;
>> +
>> + printed += scnprintf(bf + printed, bfsize - printed, " (");
>> +
>> + if (stat->jcc_fwd > 0) {
>> + j++;
>> + printed += scnprintf(bf + printed, bfsize - printed,
>> + "JCC forward");
>> + }
>> +
>> + if (stat->jcc_bwd > 0) {
>> + if (j++)
>> + printed += scnprintf(bf + printed, bfsize - printed,
>> + " JCC backward");
>> + else
>> + printed += scnprintf(bf + printed, bfsize - printed,
>> + "JCC backward");
>> + }
>> +
>> + if (stat->cross_4k > 0) {
>> + if (j++)
>> + printed += scnprintf(bf + printed, bfsize - printed,
>> + " CROSS_4K");
>> + else
>> + printed += scnprintf(bf + printed, bfsize - printed,
>> + "CROSS_4K");
>> + }
> could that 2 legs if be shortened to just one scnprintf like (untested):
>
> printed += scnprintf(bf + printed, bfsize - printed, "%s%s", j++ ? " " : "", "CROSS_4K");
>
> I'd also probably use some kind of macro or function
> with all that similar code, but I dont insist ;-)
>
> thanks,
> jirka
Thanks for this suggestion. I will use this kind of code. Of course, I
will test. :)
Thanks
Jin Yao
next prev parent reply other threads:[~2017-04-19 0:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 22:21 [PATCH v4 0/5] perf report: Show branch type Jin Yao
2017-04-11 22:21 ` [PATCH v4 1/5] perf/core: Define the common branch type classification Jin Yao
2017-04-11 22:21 ` [PATCH v4 2/5] perf/x86/intel: Record branch type Jin Yao
2017-04-11 22:21 ` [PATCH v4 3/5] perf record: Create a new option save_type in --branch-filter Jin Yao
2017-04-11 22:21 ` [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode Jin Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:53 ` Jin, Yao
2017-04-19 4:11 ` Jin, Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:41 ` Jin, Yao
2017-04-11 22:21 ` [PATCH v4 5/5] perf report: Show branch type in callchain entry Jin Yao
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:33 ` Jin, Yao [this message]
2017-04-18 18:53 ` Jiri Olsa
2017-04-19 0:32 ` Jin, Yao
2017-04-12 10:58 ` [PATCH v4 0/5] perf report: Show branch type Jiri Olsa
2017-04-12 12:25 ` Jin, Yao
2017-04-12 14:26 ` Jiri Olsa
2017-04-12 15:42 ` Jin, Yao
2017-04-12 15:46 ` Jiri Olsa
2017-04-13 2:00 ` Jin, Yao
2017-04-13 3:25 ` Jin, Yao
2017-04-13 8:26 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c26d35d6-cfa9-3735-363c-05e5be981082@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).