From: Joe Perches <joe@perches.com>
To: Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
darren@stevens-zone.net, christophe.leroy@c-s.fr,
geoff@infradead.org
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/powerpc: Use dma_zalloc_coherent
Date: Thu, 15 Nov 2018 11:25:07 -0800 [thread overview]
Message-ID: <7a3922bc5089dfe0978e07a809606360c74c940c.camel@perches.com> (raw)
In-Reply-To: <CAJr6mf1nOouU31WF_xb_46wDebPQ-7+NTCiSKBjLyQta2mny6w@mail.gmail.com>
On Thu, 2018-11-15 at 23:29 +0530, Sabyasachi Gupta wrote:
> On Mon, Nov 5, 2018 at 8:58 AM Sabyasachi Gupta
> <sabyasachi.linux@gmail.com> wrote:
> > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
>
> Any comment on this patch?
It's obviously correct.
You might realign the arguments on the next lines
to the open parenthesis.
Perhaps there should be new function calls
added for symmetry to the other alloc functions
for multiplication overflow protection.
Perhaps:
void *dma_alloc_array_coherent()
void *dma_calloc_coherent()
Something like
---
include/linux/dma-mapping.h | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 15bd41447025..95bebf8883b1 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -565,6 +565,25 @@ static inline void *dma_alloc_coherent(struct device *dev, size_t size,
(gfp & __GFP_NOWARN) ? DMA_ATTR_NO_WARN : 0);
}
+static inline void *dma_alloc_array_coherent(struct device *dev,
+ size_t n, size_t size,
+ dma_addr_t *dma_handle, gfp_t gfp)
+{
+ size_t bytes;
+
+ if (unlikely(check_mul_overflow(n, size, &bytes)))
+ return NULL;
+ return dma_alloc_coherent(dev, bytes, dma_handle, gfp);
+}
+
+static inline void *dma_calloc_coherent(struct device *dev,
+ size_t n, size_t size,
+ dma_addr_t *dma_handle, gfp_t gfp)
+{
+ return dma_alloc_array_coherent(dev, n, size, dma_handle,
+ gfp | __GFP_ZERO);
+}
+
static inline void dma_free_coherent(struct device *dev, size_t size,
void *cpu_addr, dma_addr_t dma_handle)
{
---
> > diff --git a/arch/powerpc/platforms/pasemi/dma_lib.c b/arch/powerpc/platforms/pasemi/dma_lib.c
[]
> > @@ -255,15 +255,13 @@ int pasemi_dma_alloc_ring(struct pasemi_dmachan *chan, int ring_size)
> >
> > chan->ring_size = ring_size;
> >
> > - chan->ring_virt = dma_alloc_coherent(&dma_pdev->dev,
> > + chan->ring_virt = dma_zalloc_coherent(&dma_pdev->dev,
> > ring_size * sizeof(u64),
> > &chan->ring_dma, GFP_KERNEL);
> > en
> > if (!chan->ring_virt)
> > return -ENOMEM;
> >
> > - memset(chan->ring_virt, 0, ring_size * sizeof(u64));
> > -
> > return 0;
> > }
> > EXPORT_SYMBOL(pasemi_dma_alloc_ring);
next prev parent reply other threads:[~2018-11-15 19:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 3:28 [PATCH] arch/powerpc: Use dma_zalloc_coherent Sabyasachi Gupta
2018-11-15 17:59 ` Sabyasachi Gupta
2018-11-15 19:25 ` Joe Perches [this message]
2018-11-17 7:10 ` Souptick Joarder
2018-11-17 8:24 ` Joe Perches
2018-11-16 10:06 ` Michael Ellerman
2018-11-27 9:22 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2018-11-05 2:22 [PATCH] " Sabyasachi Gupta
2018-11-15 17:56 ` Sabyasachi Gupta
2018-12-22 1:56 ` Scott Wood
2018-12-05 4:41 ` Sabyasachi Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a3922bc5089dfe0978e07a809606360c74c940c.camel@perches.com \
--to=joe@perches.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=darren@stevens-zone.net \
--cc=geoff@infradead.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sabyasachi.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).