From: Michael Ellerman <mpe@ellerman.id.au>
To: Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
benh@kernel.crashing.org, paulus@samba.org, joe@perches.com,
darren@stevens-zone.net, christophe.leroy@c-s.fr,
geoff@infradead.org
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/powerpc: Use dma_zalloc_coherent
Date: Fri, 16 Nov 2018 21:06:32 +1100 [thread overview]
Message-ID: <87sh012v6f.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <CAJr6mf1nOouU31WF_xb_46wDebPQ-7+NTCiSKBjLyQta2mny6w@mail.gmail.com>
Sabyasachi Gupta <sabyasachi.linux@gmail.com> writes:
> On Mon, Nov 5, 2018 at 8:58 AM Sabyasachi Gupta
> <sabyasachi.linux@gmail.com> wrote:
>>
>> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>>
>> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
>
> Any comment on this patch?
Wait longer :)
I'm still chasing bugs in 4.20-rc2, I haven't started merging many
patches for 4.21 yet.
Your patches are tracked in patchwork here:
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=75253
If they're still in "new" state around rc5 then feel free to ping me
again.
cheers
>> diff --git a/arch/powerpc/platforms/pasemi/dma_lib.c b/arch/powerpc/platforms/pasemi/dma_lib.c
>> index 53384eb..d18d164 100644
>> --- a/arch/powerpc/platforms/pasemi/dma_lib.c
>> +++ b/arch/powerpc/platforms/pasemi/dma_lib.c
>> @@ -255,15 +255,13 @@ int pasemi_dma_alloc_ring(struct pasemi_dmachan *chan, int ring_size)
>>
>> chan->ring_size = ring_size;
>>
>> - chan->ring_virt = dma_alloc_coherent(&dma_pdev->dev,
>> + chan->ring_virt = dma_zalloc_coherent(&dma_pdev->dev,
>> ring_size * sizeof(u64),
>> &chan->ring_dma, GFP_KERNEL);
>>
>> if (!chan->ring_virt)
>> return -ENOMEM;
>>
>> - memset(chan->ring_virt, 0, ring_size * sizeof(u64));
>> -
>> return 0;
>> }
>> EXPORT_SYMBOL(pasemi_dma_alloc_ring);
>> --
>> 2.7.4
>>
next prev parent reply other threads:[~2018-11-16 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 3:28 [PATCH] arch/powerpc: Use dma_zalloc_coherent Sabyasachi Gupta
2018-11-15 17:59 ` Sabyasachi Gupta
2018-11-15 19:25 ` Joe Perches
2018-11-17 7:10 ` Souptick Joarder
2018-11-17 8:24 ` Joe Perches
2018-11-16 10:06 ` Michael Ellerman [this message]
2018-11-27 9:22 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2018-11-05 2:22 [PATCH] " Sabyasachi Gupta
2018-11-15 17:56 ` Sabyasachi Gupta
2018-12-22 1:56 ` Scott Wood
2018-12-05 4:41 ` Sabyasachi Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh012v6f.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=darren@stevens-zone.net \
--cc=geoff@infradead.org \
--cc=joe@perches.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sabyasachi.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).