From: Russ Weight <russell.h.weight@intel.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>, <linux-doc@vger.kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Luis Chamberlain <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register()
Date: Mon, 2 May 2022 09:28:51 -0700 [thread overview]
Message-ID: <7a6906b8-6ff4-c44c-000d-5f7110d19df5@intel.com> (raw)
In-Reply-To: <20220502051456.30741-1-bagasdotme@gmail.com>
On 5/1/22 22:14, Bagas Sanjaya wrote:
> Stephen Rothwell reported kernel-doc warning:
>
> drivers/base/firmware_loader/sysfs_upload.c:285: warning: Function parameter or member 'module' not described in 'firmware_upload_register'
>
> Fix the warning by describing the 'module' parameter.
>
> Fixes: 97730bbb242cde ("firmware_loader: Add firmware-upload support")
> Link: https://lore.kernel.org/linux-next/20220502083658.266d55f8@canb.auug.org.au/
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Russ Weight <russell.h.weight@intel.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> This patch is based on driver-core-next tree.
>
> drivers/base/firmware_loader/sysfs_upload.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/firmware_loader/sysfs_upload.c
> index 8cdcf3516c7e94..87044d52322aa2 100644
> --- a/drivers/base/firmware_loader/sysfs_upload.c
> +++ b/drivers/base/firmware_loader/sysfs_upload.c
> @@ -266,6 +266,7 @@ int fw_upload_start(struct fw_sysfs *fw_sysfs)
>
> /**
> * firmware_upload_register() - register for the firmware upload sysfs API
> + * @module: kernel module of this device
> * @parent: parent device instantiating firmware upload
> * @name: firmware name to be associated with this device
> * @ops: pointer to structure of firmware upload ops
>
> base-commit: f8ae07f4b8bfde0f33761e1a1aaee45a4e85e9d6
next prev parent reply other threads:[~2022-05-02 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 5:14 [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register() Bagas Sanjaya
2022-05-02 16:28 ` Russ Weight [this message]
2022-05-03 12:12 ` Greg Kroah-Hartman
2022-05-03 20:05 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a6906b8-6ff4-c44c-000d-5f7110d19df5@intel.com \
--to=russell.h.weight@intel.com \
--cc=bagasdotme@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).