From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-api@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH 1/3] v4l: Add Qualcomm custom compressed pixel formats
Date: Wed, 2 Jun 2021 16:29:08 +0300 [thread overview]
Message-ID: <7a8a3b86-0c0a-f190-b6e7-d83d7d6b6433@linaro.org> (raw)
In-Reply-To: <b58061ff-aeb1-c48b-ea53-2366997bd825@xs4all.nl>
On 6/2/21 12:56 PM, Hans Verkuil wrote:
> On 29/04/2021 12:58, Stanimir Varbanov wrote:
>> Here we add custom Qualcomm raw compressed pixel formats. They are
>> used in Qualcomm SoCs to optimaize the interconnect bandwidth.
>
> optimize
>
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> ---
>> .../userspace-api/media/v4l/pixfmt-reserved.rst | 12 ++++++++++++
>> drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++
>> include/uapi/linux/videodev2.h | 2 ++
>> 3 files changed, 16 insertions(+)
>>
>> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst b/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst
>> index 0b879c0da713..30b9cef4cbf0 100644
>> --- a/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst
>> +++ b/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst
>> @@ -260,6 +260,18 @@ please make a proposal on the linux-media mailing list.
>> of tiles, resulting in 32-aligned resolutions for the luminance plane
>> and 16-aligned resolutions for the chrominance plane (with 2x2
>> subsampling).
>> + * .. _V4L2-PIX-FMT-QC8C:
>> +
>> + - ``V4L2_PIX_FMT_QC8C``
>> + - 'QC8C'
>> + - Compressed Macro-tile 8Bit YUV420 format used by Qualcomm platforms.
>
> 8Bit -> 8-bit
>
>> + The compression is lossless. It contains four planes.
>> + * .. _V4L2-PIX-FMT-QC10C:
>> +
>> + - ``V4L2_PIX_FMT_QC10C``
>> + - 'QC10C'
>> + - Compressed Macro-tile 10Bit YUV420 format used by Qualcomm platforms.
>
> 10Bit -> 10-bit
>
>> + The compression is lossless. It contains four planes.
>
> What is not clear from this description is if these formats are opaque, i.e. the
> only way to decompress is through hardware, or if they can be decompressed in
> software. If so, a reference to Qualcomm documentation would be useful. See e.g.
> the V4L2_PIX_FMT_MT21C description (that's an opaque format).
Yes, the formats are opaque and can be decompressed by hardware blocks
only. I'll clear that in v2. Thanks for the review.
--
regards,
Stan
next prev parent reply other threads:[~2021-06-02 13:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 10:58 [PATCH 0/3] Qualcomm custom compressed pixfmt Stanimir Varbanov
2021-04-29 10:58 ` [PATCH 1/3] v4l: Add Qualcomm custom compressed pixel formats Stanimir Varbanov
2021-04-29 19:10 ` Nicolas Dufresne
2021-05-17 15:13 ` Stanimir Varbanov
2021-06-02 9:56 ` Hans Verkuil
2021-06-02 13:29 ` Stanimir Varbanov [this message]
2021-04-29 10:58 ` [PATCH 2/3] venus: Add a handling of QC8C compressed format Stanimir Varbanov
2021-06-02 9:59 ` Hans Verkuil
2021-04-29 10:58 ` [PATCH 3/3] venus: Add a handling of QC10C " Stanimir Varbanov
2021-06-02 10:01 ` Hans Verkuil
2021-06-02 13:30 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a8a3b86-0c0a-f190-b6e7-d83d7d6b6433@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).