From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-api@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH 2/3] venus: Add a handling of QC8C compressed format
Date: Wed, 2 Jun 2021 11:59:37 +0200 [thread overview]
Message-ID: <d2960304-f119-aff2-3be7-9b50ad67a650@xs4all.nl> (raw)
In-Reply-To: <20210429105815.2790770-3-stanimir.varbanov@linaro.org>
On 29/04/2021 12:58, Stanimir Varbanov wrote:
> This adds QC8C compressed pixel format in the Venus driver, and
> make it enumeratable from v4l2 clients.
enumeratable -> possible to discover
(or possibly 'enumerable', but I prefer the phrase suggested above)
Regards,
Hans
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> ---
> drivers/media/platform/qcom/venus/helpers.c | 2 ++
> drivers/media/platform/qcom/venus/vdec.c | 12 +++++++++++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index 9b8ff76e3c43..3a0b07d237a5 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -561,6 +561,8 @@ static u32 to_hfi_raw_fmt(u32 v4l2_fmt)
> return HFI_COLOR_FORMAT_NV12;
> case V4L2_PIX_FMT_NV21:
> return HFI_COLOR_FORMAT_NV21;
> + case V4L2_PIX_FMT_QC8C:
> + return HFI_COLOR_FORMAT_NV12_UBWC;
> default:
> break;
> }
> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
> index 5e5584fc21e9..d4cc51fc019c 100644
> --- a/drivers/media/platform/qcom/venus/vdec.c
> +++ b/drivers/media/platform/qcom/venus/vdec.c
> @@ -31,6 +31,10 @@
> */
> static const struct venus_format vdec_formats[] = {
> {
> + .pixfmt = V4L2_PIX_FMT_QC8C,
> + .num_planes = 1,
> + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> + }, {
> .pixfmt = V4L2_PIX_FMT_NV12,
> .num_planes = 1,
> .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> @@ -696,7 +700,13 @@ static int vdec_output_conf(struct venus_inst *inst)
> inst->output2_buf_size =
> venus_helper_get_framesz_raw(out2_fmt, width, height);
>
> - if (is_ubwc_fmt(out_fmt)) {
> + if (is_ubwc_fmt(out_fmt) && is_ubwc_fmt(out2_fmt)) {
> + inst->output2_buf_size = 0;
> + inst->opb_buftype = HFI_BUFFER_OUTPUT;
> + inst->opb_fmt = out_fmt;
> + inst->dpb_buftype = 0;
> + inst->dpb_fmt = 0;
> + } else if (is_ubwc_fmt(out_fmt)) {
> inst->opb_buftype = HFI_BUFFER_OUTPUT2;
> inst->opb_fmt = out2_fmt;
> inst->dpb_buftype = HFI_BUFFER_OUTPUT;
>
next prev parent reply other threads:[~2021-06-02 9:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 10:58 [PATCH 0/3] Qualcomm custom compressed pixfmt Stanimir Varbanov
2021-04-29 10:58 ` [PATCH 1/3] v4l: Add Qualcomm custom compressed pixel formats Stanimir Varbanov
2021-04-29 19:10 ` Nicolas Dufresne
2021-05-17 15:13 ` Stanimir Varbanov
2021-06-02 9:56 ` Hans Verkuil
2021-06-02 13:29 ` Stanimir Varbanov
2021-04-29 10:58 ` [PATCH 2/3] venus: Add a handling of QC8C compressed format Stanimir Varbanov
2021-06-02 9:59 ` Hans Verkuil [this message]
2021-04-29 10:58 ` [PATCH 3/3] venus: Add a handling of QC10C " Stanimir Varbanov
2021-06-02 10:01 ` Hans Verkuil
2021-06-02 13:30 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2960304-f119-aff2-3be7-9b50ad67a650@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).