From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Kalle Valo <kvalo@kernel.org>, Philippe Schenker <dev@pschenker.ch>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
"David S. Miller" <davem@davemloft.net>,
Deren Wu <deren.wu@mediatek.com>,
Jakub Kicinski <kuba@kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
YN Chen <YN.Chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
netdev@vger.kernel.org,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
Date: Tue, 12 Apr 2022 11:55:13 +0200 [thread overview]
Message-ID: <7aa0bbd0-5498-ba74-ad6d-6dacbade8a3d@leemhuis.info> (raw)
In-Reply-To: <87y20aod5d.fsf@kernel.org>
On 12.04.22 11:37, Kalle Valo wrote:
> Philippe Schenker <dev@pschenker.ch> writes:
>
>> This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
>>
>> This commit introduces a regression on some systems where the kernel is
>> crashing in different locations after a reboot was issued.
>>
>> This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest firmware.
>>
>> Link: https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/
>> Signed-off-by: Philippe Schenker <dev@pschenker.ch>
>
> Can I take this to wireless tree? Felix, ack?
>
> I'll also add:
>
> Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
Sorry, stupid questions from the regression tracker: wouldn't this cause
a regression for users of kernel versions post-bf3747ae2e25, as the
power consumption is likely to increase for them? Without having dug
into the backstory much: would disabling ASPM for this particular
machine using a quirk be the better approach? Or are we assuming a lot
of machines are affected?
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
P.S.: As the Linux kernel's regression tracker I'm getting a lot of
reports on my table. I can only look briefly into most of them and lack
knowledge about most of the areas they concern. I thus unfortunately
will sometimes get things wrong or miss something important. I hope
that's not the case here; if you think it is, don't hesitate to tell me
in a public reply, it's in everyone's interest to set the public record
straight.
next prev parent reply other threads:[~2022-04-12 11:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 9:04 [PATCH] Revert "mt76: mt7921: enable aspm by default" Philippe Schenker
2022-04-12 9:37 ` Kalle Valo
2022-04-12 9:55 ` Thorsten Leemhuis [this message]
2022-04-12 10:33 ` Kalle Valo
2022-04-12 10:36 ` Kalle Valo
2022-04-27 7:32 ` Thorsten Leemhuis
2022-04-12 11:06 ` Deren Wu
2022-04-12 12:30 ` Philippe Schenker
2022-04-12 12:45 ` Kalle Valo
2022-06-01 8:28 ` Philippe Schenker
2022-06-01 8:58 ` Kalle Valo
2022-06-01 16:55 ` Deren Wu
2022-06-02 10:00 ` Philippe Schenker
[not found] <e93aef5c9f8a97efe23cfb5892f78f919ce328e7.camel@pschenker.ch--annotate>
2022-06-01 22:23 ` sean.wang
2022-06-02 8:44 ` Philippe Schenker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aa0bbd0-5498-ba74-ad6d-6dacbade8a3d@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=YN.Chen@mediatek.com \
--cc=davem@davemloft.net \
--cc=deren.wu@mediatek.com \
--cc=dev@pschenker.ch \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=regressions@lists.linux.dev \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).