Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"

From: Kalle Valo <kvalo@kernel.org>
To: Philippe Schenker <dev@pschenker.ch>
Cc: Deren Wu <deren.wu@mediatek.com>,
	linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
	linux@leemhuis.info, "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	YN Chen <YN.Chen@mediatek.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	netdev@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
Date: Wed, 01 Jun 2022 11:58:25 +0300	[thread overview]
Message-ID: <87mtewoj4e.fsf@kernel.org> (raw)
In-Reply-To: <e93aef5c9f8a97efe23cfb5892f78f919ce328e7.camel@pschenker.ch> (Philippe Schenker's message of "Wed, 01 Jun 2022 10:28:27 +0200")

Philippe Schenker <dev@pschenker.ch> writes:

> On Tue, 2022-04-12 at 19:06 +0800, Deren Wu wrote:
>> On Tue, 2022-04-12 at 12:37 +0300, Kalle Valo wrote:
>> > Philippe Schenker <dev@pschenker.ch> writes:
>> > 
>> > > This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
>> > > 
>> > > This commit introduces a regression on some systems where the
>> > > kernel is
>> > > crashing in different locations after a reboot was issued.
>> > > 
>> > > This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest
>> > > firmware.
>> > > 
>> > > Link: 
>> > > https://urldefense.com/v3/__https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/__;!!CTRNKA9wMg0ARbw!09tjyaQlMci3fVI3yiNiDJKUW_qwNA_CbVhoAraeIX96B99Q14J4iDycWA9cq36Y$
>> > >  
>> > > Signed-off-by: Philippe Schenker <dev@pschenker.ch>
>> > 
>> > Can I take this to wireless tree? Felix, ack?
>> > 
>> > I'll also add:
>> > 
>> > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
>> > 
>> 
>> Hi Kalle,
>> 
>> We have a patch for a similar problem. Can you wait for the
>> verification by Philippe?
>> Commit 602cc0c9618a81 ("mt76: mt7921e: fix possible probe failure
>> after
>> reboot")
>> Link: 
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/mediatek/mt76?id=602cc0c9618a819ab00ea3c9400742a0ca318380
>> 
>> I can reproduce the problem in my v5.16-rc5 desktop. And the issue can
>> be fixed when the patch applied.
>> 
>> 
>> Hi Philippe,
>> 
>> Can you please help to check the patch in your platform?
>
> Hi Kalle and Deren,
>
> I just noticed on my system and mainline v5.18 reboots do now work
> however Bluetooth is no longer accessible after a reboot.
>
> Reverting commit bf3747ae2e25dda6a9e6c464a717c66118c588c8 on top of
> v5.18 solves this problem for me.
>
> @Deren are you aware of this bug?
> @Kalle Is there a bugtracker somewhere I can submit this?

For regressions the best is to submit it to the regressions list, CCed
it now.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches