From: jckuo <jckuo@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] phy: tegra: xusb: Skip single function lane programming
Date: Mon, 28 Jan 2019 15:06:51 +0800 [thread overview]
Message-ID: <7afb7753-39d2-69b9-3666-e159d3e85ae0@nvidia.com> (raw)
In-Reply-To: <20190125112525.10697-2-thierry.reding@gmail.com>
Reviewed-by: JC Kuo <jckuo@nvidia.com>
On 1/25/19 7:25 PM, Thierry Reding wrote:
> From: JC Kuo <jckuo@nvidia.com>
>
> Tegra186 USB2 pads and USB3 pads do not have hardware mux for changing
> the pad function. For such "lanes", we can skip the lane mux register
> programming.
>
> Signed-off-by: JC Kuo <jckuo@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/phy/tegra/xusb.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index 5b3b8863363e..e3bc60cfe6a1 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2014-2015, NVIDIA CORPORATION. All rights reserved.
> + * Copyright (c) 2014-2016, NVIDIA CORPORATION. All rights reserved.
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms and conditions of the GNU General Public License,
> @@ -313,6 +313,10 @@ static void tegra_xusb_lane_program(struct tegra_xusb_lane *lane)
> const struct tegra_xusb_lane_soc *soc = lane->soc;
> u32 value;
>
> + /* skip single function lanes */
> + if (soc->num_funcs < 2)
> + return;
> +
> /* choose function */
> value = padctl_readl(padctl, soc->offset);
> value &= ~(soc->mask << soc->shift);
next prev parent reply other threads:[~2019-01-28 7:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 11:25 [PATCH 1/5] dt-bindings: phy: tegra: Add Tegra186 support Thierry Reding
2019-01-25 11:25 ` [PATCH 2/5] phy: tegra: xusb: Skip single function lane programming Thierry Reding
2019-01-28 7:06 ` jckuo [this message]
2019-01-25 11:25 ` [PATCH 3/5] phy: tegra: xusb: Parse dual-role mode property Thierry Reding
2019-01-28 7:08 ` jckuo
2019-01-25 11:25 ` [PATCH 4/5] phy: tegra: xusb: Add support for power supplies Thierry Reding
2019-01-28 7:22 ` jckuo
2019-01-28 8:00 ` Thierry Reding
2019-01-29 6:50 ` jckuo
2019-02-05 12:55 ` Kishon Vijay Abraham I
2019-02-07 11:11 ` Thierry Reding
2019-01-25 11:25 ` [PATCH 5/5] phy: tegra: xusb: Add Tegra186 support Thierry Reding
2019-01-28 7:45 ` jckuo
2019-02-07 11:47 ` Kishon Vijay Abraham I
2019-02-07 12:17 ` Thierry Reding
2019-01-28 7:04 ` [PATCH 1/5] dt-bindings: phy: tegra: " jckuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7afb7753-39d2-69b9-3666-e159d3e85ae0@nvidia.com \
--to=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).