* [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs
@ 2016-06-13 13:04 Arnd Bergmann
2016-06-13 13:19 ` Ilya Dryomov
2016-08-26 12:40 ` Michal Marek
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-06-13 13:04 UTC (permalink / raw)
To: Sage Weil
Cc: Arnd Bergmann, Jan Beulich, Michal Marek, Ilya Dryomov, Yan,
Zheng, Alex Elder, ceph-devel, linux-kernel
The genksyms helper in the kernel cannot parse a type definition
like "typeof(((type *)0)->keyfld)" that is used in the DEFINE_RB_FUNCS
helper, causing the following EXPORT_SYMBOL() statement to be ignored
when computing the crcs, and triggering a warning about this:
WARNING: "ceph_monc_do_statfs" [fs/ceph/ceph.ko] has no CRC
To work around the problem, we can rewrite the type to reference
an undefined 'extern' symbol instead of a NULL pointer. This is
evidently ok for genksyms, and it no longer complains about the
line when calling it with 'genksyms -w'.
I've looked briefly into extending genksyms instead, but it seems
really hard to do. Jan Beulich introduced basic support for 'typeof'
a while ago in dc53324060f3 ("genksyms: fix typeof() handling"),
but that is not sufficient for the expression we have here.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: fcd00b68bbe2 ("libceph: DEFINE_RB_FUNCS macro")
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Michal Marek <mmarek@suse.cz>
---
include/linux/ceph/libceph.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h
index 690985daad1c..6b79a6ba39ca 100644
--- a/include/linux/ceph/libceph.h
+++ b/include/linux/ceph/libceph.h
@@ -214,8 +214,9 @@ static void erase_##name(struct rb_root *root, type *t) \
}
#define DEFINE_RB_LOOKUP_FUNC(name, type, keyfld, nodefld) \
+extern type __lookup_##name##_key; \
static type *lookup_##name(struct rb_root *root, \
- typeof(((type *)0)->keyfld) key) \
+ typeof(__lookup_##name##_key.keyfld) key) \
{ \
struct rb_node *n = root->rb_node; \
\
--
2.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs
2016-06-13 13:04 [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs Arnd Bergmann
@ 2016-06-13 13:19 ` Ilya Dryomov
2016-06-13 14:59 ` Arnd Bergmann
2016-08-26 12:40 ` Michal Marek
1 sibling, 1 reply; 4+ messages in thread
From: Ilya Dryomov @ 2016-06-13 13:19 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sage Weil, Jan Beulich, Michal Marek, Yan, Zheng, Alex Elder,
Ceph Development, linux-kernel
On Mon, Jun 13, 2016 at 3:04 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The genksyms helper in the kernel cannot parse a type definition
> like "typeof(((type *)0)->keyfld)" that is used in the DEFINE_RB_FUNCS
> helper, causing the following EXPORT_SYMBOL() statement to be ignored
> when computing the crcs, and triggering a warning about this:
>
> WARNING: "ceph_monc_do_statfs" [fs/ceph/ceph.ko] has no CRC
>
> To work around the problem, we can rewrite the type to reference
> an undefined 'extern' symbol instead of a NULL pointer. This is
> evidently ok for genksyms, and it no longer complains about the
> line when calling it with 'genksyms -w'.
>
> I've looked briefly into extending genksyms instead, but it seems
> really hard to do. Jan Beulich introduced basic support for 'typeof'
> a while ago in dc53324060f3 ("genksyms: fix typeof() handling"),
> but that is not sufficient for the expression we have here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: fcd00b68bbe2 ("libceph: DEFINE_RB_FUNCS macro")
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Michal Marek <mmarek@suse.cz>
> ---
> include/linux/ceph/libceph.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h
> index 690985daad1c..6b79a6ba39ca 100644
> --- a/include/linux/ceph/libceph.h
> +++ b/include/linux/ceph/libceph.h
> @@ -214,8 +214,9 @@ static void erase_##name(struct rb_root *root, type *t) \
> }
>
> #define DEFINE_RB_LOOKUP_FUNC(name, type, keyfld, nodefld) \
> +extern type __lookup_##name##_key; \
> static type *lookup_##name(struct rb_root *root, \
> - typeof(((type *)0)->keyfld) key) \
> + typeof(__lookup_##name##_key.keyfld) key) \
> { \
> struct rb_node *n = root->rb_node; \
> \
Out of curiosity, did you figure out why is it that only
ceph_monc_do_statfs() is affected and not the other exports in
net/ceph/osd_client.c?
Thanks,
Ilya
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs
2016-06-13 13:19 ` Ilya Dryomov
@ 2016-06-13 14:59 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-06-13 14:59 UTC (permalink / raw)
To: Ilya Dryomov
Cc: Sage Weil, Jan Beulich, Michal Marek, Yan, Zheng, Alex Elder,
Ceph Development, linux-kernel
On Monday, June 13, 2016 3:19:12 PM CEST Ilya Dryomov wrote:
> > diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h
> > index 690985daad1c..6b79a6ba39ca 100644
> > --- a/include/linux/ceph/libceph.h
> > +++ b/include/linux/ceph/libceph.h
> > @@ -214,8 +214,9 @@ static void erase_##name(struct rb_root *root, type *t) \
> > }
> >
> > #define DEFINE_RB_LOOKUP_FUNC(name, type, keyfld, nodefld) \
> > +extern type __lookup_##name##_key; \
> > static type *lookup_##name(struct rb_root *root, \
> > - typeof(((type *)0)->keyfld) key) \
> > + typeof(__lookup_##name##_key.keyfld) key) \
> > { \
> > struct rb_node *n = root->rb_node; \
> > \
>
> Out of curiosity, did you figure out why is it that only
> ceph_monc_do_statfs() is affected and not the other exports in
> net/ceph/osd_client.c?
No, I did not investigate it further at that point. My guess is that
something resets the state of the genksyms parser when it encounters
some tokens (like the semicolon I added earlier, or an EXPORT_SYMBOL
statement), and that this happens in one file but not the other.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs
2016-06-13 13:04 [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs Arnd Bergmann
2016-06-13 13:19 ` Ilya Dryomov
@ 2016-08-26 12:40 ` Michal Marek
1 sibling, 0 replies; 4+ messages in thread
From: Michal Marek @ 2016-08-26 12:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sage Weil, Jan Beulich, Ilya Dryomov, Yan, Zheng, Alex Elder,
ceph-devel, linux-kernel
On 2016-06-13 15:04, Arnd Bergmann wrote:
> The genksyms helper in the kernel cannot parse a type definition
> like "typeof(((type *)0)->keyfld)" that is used in the DEFINE_RB_FUNCS
> helper, causing the following EXPORT_SYMBOL() statement to be ignored
> when computing the crcs, and triggering a warning about this:
>
> WARNING: "ceph_monc_do_statfs" [fs/ceph/ceph.ko] has no CRC
FYI, Nick fixed the genksyms state machine to cope with this syntax. See
commits
5c6f3225d00d kbuild: Regenerate genksyms lexer
4fab91605a6b kbuild: genksyms fix for typeof handling
in today's linux-next. So the workaround can eventually be reverted.
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-26 12:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-13 13:04 [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs Arnd Bergmann
2016-06-13 13:19 ` Ilya Dryomov
2016-06-13 14:59 ` Arnd Bergmann
2016-08-26 12:40 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).