From: Tom Rix <trix@redhat.com>
To: Joe Perches <joe@perches.com>,
apw@canonical.com, nickhu@andestech.com, green.hu@gmail.com,
deanbo422@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix
Date: Sat, 28 Nov 2020 08:56:59 -0800 [thread overview]
Message-ID: <7d1474bf-ae4f-0ca0-d282-ca12071f353b@redhat.com> (raw)
In-Reply-To: <1e0ffe90dc73d45e3e2c3bdd8686aa8e9afa8b23.camel@perches.com>
On 11/28/20 8:44 AM, Joe Perches wrote:
> On Sat, 2020-11-28 at 08:30 -0800, Tom Rix wrote:
>> On 11/28/20 8:00 AM, Joe Perches wrote:
>>> On Sat, 2020-11-28 at 07:36 -0800, Tom Rix wrote:
>>>> On 11/27/20 2:10 PM, Joe Perches wrote:
>>> []
>>>>> I think an exception mechanism would be better than a specific
>>>>> mechanism added to various entries.
>>>> Can you give an example of what you mean ?
>>> Inherit the parent prefix then add the basename(dirname) as a default.
>>>
>>> For instance, changes to any subsystem of drivers/staging starts as
>>> "staging: " and with "$basename(path): " appended.
>> Ah, this is quite a bit different.
>>
>> As far as I can tell there is no default.
> The idea is to avoid adding a D: entry to each subsystem section.
Yeah, having looked at 2000+ on my initial populating of D's, it was not great
>
>> MAINTAINERS would only have the exceptions, obviously needing drivers/foo to be 'foo:'
>>
>> Without the full prefix, the user would be need to use get_maintainer.pl to figure it out.
> True. Or some other script.
I am ok with another script, maybe get_subsystem.py
>
>> Are the ""'s in the D value necessary ?
> Maybe not. I did that for clarity with the space after colon.
> My recollection is some systems used "[subsystem]" separators
> and other use / without space and not colons, but I'm for
> whatever approriate changes that support standarization
>
> I think most developer/maintainers don't care one way or
> another about patch commit prefixes, but those that do care
> seem to care a lot.
>
>
Yes, i agree.
Tom
next prev parent reply other threads:[~2020-11-28 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 21:43 [PATCH] MAINTAINERS add D: tag for subsystem commit prefix trix
2020-11-27 22:10 ` Joe Perches
2020-11-28 15:36 ` Tom Rix
2020-11-28 16:00 ` Joe Perches
2020-11-28 16:30 ` Tom Rix
2020-11-28 16:44 ` Joe Perches
2020-11-28 16:56 ` Tom Rix [this message]
2020-11-27 22:43 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d1474bf-ae4f-0ca0-d282-ca12071f353b@redhat.com \
--to=trix@redhat.com \
--cc=apw@canonical.com \
--cc=deanbo422@gmail.com \
--cc=green.hu@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickhu@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).