linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Rix <trix@redhat.com>
To: Joe Perches <joe@perches.com>,
	apw@canonical.com, nickhu@andestech.com, green.hu@gmail.com,
	deanbo422@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix
Date: Sat, 28 Nov 2020 07:36:17 -0800	[thread overview]
Message-ID: <f96ff56c-7c39-2fed-dd8b-11971f8965bf@redhat.com> (raw)
In-Reply-To: <a4e796f8c0bfdb2c0a2816fa706d13cc0ae06d40.camel@perches.com>


On 11/27/20 2:10 PM, Joe Perches wrote:
> On Fri, 2020-11-27 at 13:43 -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> From
>> RFC MAINTAINERS tag for cleanup robot
>> https://lkml.org/lkml/2020/11/21/190
> I think this should be RFC.
> It looks as as if it's only for subsystems through A

Yes only A, i wanted to show the direction in a subset.

>
>> The prefix used by subsystems in their commit log is arbitrary.
>> To elimitate the time and effort to manually find a reasonable
>> prefix, store the preferred prefix in the MAINTAINERS file.
>>
>> Populate with reasonable prefixes using this algorithm.
>> What did the maintainers use in their commits?
>> If there were no maintainers commits then what did everyone
>> else use in their commits.
> The algorithm used to produce these prefixes should also be published.
Ok.
>> The results were manually reviewed and about 25% were rejected.
> Because this isn't necessarily the best option.
>
> I think an exception mechanism would be better than a specific
> mechanism added to various entries.
Can you give an example of what you mean ?
>>  # check MAINTAINERS entries for the right ordering too
>> -			my $preferred_order = 'MRLSWQBCPTFXNK';
>> +			my $preferred_order = 'MRLSWQBCPTFXNKD';
>>  			if ($rawline =~ /^\+[A-Z]:/ &&
>>  			    $prevrawline =~ /^[\+ ][A-Z]:/) {
>>  				$rawline =~ /^\+([A-Z]):\s*(.*)/;
> I'd prefer to keep the file and keyword list last.
>
So change to

my $preferred_order = 'MRLSWQBCPTDFXNK'; 

?

>
>


  reply	other threads:[~2020-11-28 21:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27 21:43 [PATCH] MAINTAINERS add D: tag for subsystem commit prefix trix
2020-11-27 22:10 ` Joe Perches
2020-11-28 15:36   ` Tom Rix [this message]
2020-11-28 16:00     ` Joe Perches
2020-11-28 16:30       ` Tom Rix
2020-11-28 16:44         ` Joe Perches
2020-11-28 16:56           ` Tom Rix
2020-11-27 22:43 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f96ff56c-7c39-2fed-dd8b-11971f8965bf@redhat.com \
    --to=trix@redhat.com \
    --cc=apw@canonical.com \
    --cc=deanbo422@gmail.com \
    --cc=green.hu@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickhu@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).