From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Jinlong Mao <quic_jinlmao@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Hao Zhang <quic_hazha@quicinc.com>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths.
Date: Mon, 28 Mar 2022 09:33:10 +0100 [thread overview]
Message-ID: <7d571b9d-2066-8217-5485-da0e6ace65eb@arm.com> (raw)
In-Reply-To: <e78ff137-fc5e-ff00-0e57-91304288d860@quicinc.com>
On 24/03/2022 14:23, Jinlong Mao wrote:
> Hi Greg,
>
> Thanks for your review.
>
> On 3/24/2022 8:26 PM, Greg Kroah-Hartman wrote:
>> On Thu, Mar 24, 2022 at 08:17:25PM +0800, Mao Jinlong wrote:
>>> Use hash length of the source's device name to map to the pointer
>>> of the enabled path. Using IDR will be more efficient than using
>>> the list. And there could be other sources except STM and CPU etms
>>> in the new HWs. It is better to maintain all the paths together.
>>>
>>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>>> ---
>>> drivers/hwtracing/coresight/coresight-core.c | 75 +++++++-------------
>>> 1 file changed, 26 insertions(+), 49 deletions(-)
>> Your subject line is odd. Please put back the driver subsystem in the
>> subject line so that it makes more sense.
> I will update the subject in next version.
>>
>> And how have you measured "more efficient"?
>
> Using IDR would be better than doing a sequential search as there will
> be much more device in future.
Where do we use sequential search now ? For non-CPU bound sources, yes
we may need something. But CPU case is straight forward, and could be
retained as it is. i.e., per-cpu list of paths.
Cheers
Suzuki
>
>>
>> thanks,
>>
>> greg k-h
>
> Thanks
>
> Jinlong Mao
>
next prev parent reply other threads:[~2022-03-28 8:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 12:17 [PATCH v4 00/10] Coresight: Add support for TPDM and TPDA Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths Mao Jinlong
2022-03-24 12:26 ` Greg Kroah-Hartman
2022-03-24 14:23 ` Jinlong Mao
2022-03-24 17:06 ` Greg Kroah-Hartman
2022-03-29 13:47 ` Jinlong Mao
2022-03-28 8:33 ` Suzuki K Poulose [this message]
2022-03-29 13:56 ` Jinlong Mao
2022-03-29 14:36 ` Mathieu Poirier
[not found] ` <b4d4ca6f-13ae-8050-debe-57e6c8be6254@quicinc.com>
2022-03-30 9:05 ` Suzuki K Poulose
2022-04-11 2:55 ` Jinlong Mao
2022-03-24 12:17 ` [PATCH v4 02/10] Coresight: Add coresight TPDM source driver Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 03/10] dt-bindings: arm: Adds CoreSight TPDM hardware definitions Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 04/10] coresight-tpdm: Add DSB dataset support Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 05/10] coresight-tpdm: Add integration test support Mao Jinlong
2022-03-24 12:28 ` Greg Kroah-Hartman
2022-03-24 14:30 ` Jinlong Mao
2022-03-24 12:17 ` [PATCH v4 06/10] docs: sysfs: coresight: Add sysfs ABI documentation for TPDM Mao Jinlong
2022-03-24 12:26 ` Greg Kroah-Hartman
2022-03-24 14:24 ` Jinlong Mao
2022-03-24 12:17 ` [PATCH v4 07/10] Coresight: Add TPDA link driver Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 08/10] dt-bindings: arm: Adds CoreSight TPDA hardware definitions Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 09/10] ARM: dts: msm: Add coresight components for SM8250 Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 10/10] ARM: dts: msm: Add tpdm mm/prng for sm8250 Mao Jinlong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d571b9d-2066-8217-5485-da0e6ace65eb@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_hazha@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).