From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mao Jinlong <quic_jinlmao@quicinc.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Hao Zhang <quic_hazha@quicinc.com>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 05/10] coresight-tpdm: Add integration test support
Date: Thu, 24 Mar 2022 13:28:03 +0100 [thread overview]
Message-ID: <Yjxj02nl+hwoYb9C@kroah.com> (raw)
In-Reply-To: <20220324121734.21531-6-quic_jinlmao@quicinc.com>
On Thu, Mar 24, 2022 at 08:17:29PM +0800, Mao Jinlong wrote:
> Integration test for tpdm can help to generate the data for
> verification of the topology during TPDM software bring up.
>
> Sample:
> echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink
> echo 1 > /sys/bus/coresight/devices/tpdm1/enable_source
> echo 1 > /sys/bus/coresight/devices/tpdm1/integration_test
> echo 2 > /sys/bus/coresight/devices/tpdm1/integration_test
> cat /dev/tmc_etf0 > /data/etf-tpdm1.bin
>
> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
> drivers/hwtracing/coresight/Kconfig | 9 ++++
> drivers/hwtracing/coresight/coresight-tpdm.c | 56 +++++++++++++++++++-
> drivers/hwtracing/coresight/coresight-tpdm.h | 8 +++
> 3 files changed, 72 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig
> index 5c506a1cd08f..60248fef4089 100644
> --- a/drivers/hwtracing/coresight/Kconfig
> +++ b/drivers/hwtracing/coresight/Kconfig
> @@ -214,4 +214,13 @@ config CORESIGHT_TPDM
> To compile this driver as a module, choose M here: the module will be
> called coresight-tpdm.
>
> +config CORESIGHT_TPDM_INTEGRATION_TEST
> + bool "Enable CoreSight Integration Test For TPDM"
> + depends on CORESIGHT_TPDM
> + help
> + This option adds support for the CoreSight integration test on this
> + devie. Coresight architecture provides integration control modes of
> + operation to facilitate integration testing and software bringup
> + and/or to instrument topology discovery. The TPDM utilizes integration
> + mode to accomplish integration testing and software bringup.
Why is this a Kconfig option? Why would you never not want this?
> endif
> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c
> index a8d257a591f3..cddd398be0cd 100644
> --- a/drivers/hwtracing/coresight/coresight-tpdm.c
> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
> @@ -124,7 +124,60 @@ static void tpdm_init_default_data(struct tpdm_drvdata *drvdata)
> __set_bit(i, drvdata->datasets);
> }
> CS_LOCK(drvdata->base);
> - }
> +}
> +
> +#ifdef CONFIG_CORESIGHT_TPDM_INTEGRATION_TEST
Try to keep #ifdefs out of .c files please.
> +static ssize_t integration_test_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf,
> + size_t size)
> +{
> + int i, ret = 0;
> + unsigned long val;
> + struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
> +
> + ret = kstrtoul(buf, 10, &val);
> + if (ret)
> + return ret;
> +
> + if (val != 1 && val != 2)
> + return -EINVAL;
> +
> + if (!drvdata->enable)
> + return -EINVAL;
> +
> + if (val == 1)
> + val = ATBCNTRL_VAL_64;
> + else
> + val = ATBCNTRL_VAL_32;
> + CS_UNLOCK(drvdata->base);
> + writel_relaxed(0x1, drvdata->base + TPDM_ITCNTRL);
> +
> + for (i = 1; i < 5; i++)
> + writel_relaxed(val, drvdata->base + TPDM_ITATBCNTRL);
> +
> + writel_relaxed(0, drvdata->base + TPDM_ITCNTRL);
> + CS_LOCK(drvdata->base);
> + return size;
> +}
> +static DEVICE_ATTR_WO(integration_test);
> +#endif /* CORESIGHT_TPDM_INTEGRATION_TEST */
> +
> +static struct attribute *tpdm_attrs[] = {
> +#ifdef CONFIG_CORESIGHT_TPDM_INTEGRATION_TEST
> + &dev_attr_integration_test.attr,
> +#endif /* CORESIGHT_TPDM_INTEGRATION_TEST */
> + NULL,
> +};
> +
> +static struct attribute_group tpdm_attr_grp = {
> + .attrs = tpdm_attrs,
> +};
> +
> +static const struct attribute_group *tpdm_attr_grps[] = {
> + &tpdm_attr_grp,
> + NULL,
> +};
ATTRIBUTE_GROUPS()?
thanks,
greg k-h
next prev parent reply other threads:[~2022-03-24 12:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 12:17 [PATCH v4 00/10] Coresight: Add support for TPDM and TPDA Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths Mao Jinlong
2022-03-24 12:26 ` Greg Kroah-Hartman
2022-03-24 14:23 ` Jinlong Mao
2022-03-24 17:06 ` Greg Kroah-Hartman
2022-03-29 13:47 ` Jinlong Mao
2022-03-28 8:33 ` Suzuki K Poulose
2022-03-29 13:56 ` Jinlong Mao
2022-03-29 14:36 ` Mathieu Poirier
[not found] ` <b4d4ca6f-13ae-8050-debe-57e6c8be6254@quicinc.com>
2022-03-30 9:05 ` Suzuki K Poulose
2022-04-11 2:55 ` Jinlong Mao
2022-03-24 12:17 ` [PATCH v4 02/10] Coresight: Add coresight TPDM source driver Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 03/10] dt-bindings: arm: Adds CoreSight TPDM hardware definitions Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 04/10] coresight-tpdm: Add DSB dataset support Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 05/10] coresight-tpdm: Add integration test support Mao Jinlong
2022-03-24 12:28 ` Greg Kroah-Hartman [this message]
2022-03-24 14:30 ` Jinlong Mao
2022-03-24 12:17 ` [PATCH v4 06/10] docs: sysfs: coresight: Add sysfs ABI documentation for TPDM Mao Jinlong
2022-03-24 12:26 ` Greg Kroah-Hartman
2022-03-24 14:24 ` Jinlong Mao
2022-03-24 12:17 ` [PATCH v4 07/10] Coresight: Add TPDA link driver Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 08/10] dt-bindings: arm: Adds CoreSight TPDA hardware definitions Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 09/10] ARM: dts: msm: Add coresight components for SM8250 Mao Jinlong
2022-03-24 12:17 ` [PATCH v4 10/10] ARM: dts: msm: Add tpdm mm/prng for sm8250 Mao Jinlong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjxj02nl+hwoYb9C@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_hazha@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).