archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <>
To: Jason Wang <>,
Subject: Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON
Date: Thu, 24 Jun 2021 09:22:38 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 6/23/21 11:49 PM, Jason Wang wrote:
> The if condition followed by BUG can be replaced to BUG_ON which is
> more compact and formal in linux source.
> Signed-off-by: Jason Wang <>

Acked-by: Florian Fainelli <>

Although I would rather completely remove this BUG_ON() and replace it
with a WARN_ON() instead, no need to kill the machine for such a
problem, however unlikely it is to appear.

       reply	other threads:[~2021-06-24 16:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2021-06-24 16:22 ` Florian Fainelli [this message]
2021-07-23 15:47 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).