* [PATCH] ARM: dts: rockchip: fix MMC compatibles for rk3288
@ 2022-01-25 11:50 John Keeping
2022-01-25 12:14 ` Johan Jonker
0 siblings, 1 reply; 3+ messages in thread
From: John Keeping @ 2022-01-25 11:50 UTC (permalink / raw)
To: Heiko Stuebner
Cc: John Keeping, Rob Herring, linux-arm-kernel, linux-rockchip,
devicetree, linux-kernel
Prior to commit 4bac670aa5cb ("mmc: dw_mmc: rockchip: use common_caps")
the mshcN aliases were used in an unusual way by the dw_mmc driver and
affected behaviour. Now that this has been fixed, rename the mmc
aliases to use the standard form.
Signed-off-by: John Keeping <john@metanate.com>
---
arch/arm/boot/dts/rk3288.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index aaaa61875701..50fa0a4652b5 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -25,10 +25,10 @@ aliases {
i2c3 = &i2c3;
i2c4 = &i2c4;
i2c5 = &i2c5;
- mshc0 = &emmc;
- mshc1 = &sdmmc;
- mshc2 = &sdio0;
- mshc3 = &sdio1;
+ mmc0 = &emmc;
+ mmc1 = &sdmmc;
+ mmc2 = &sdio0;
+ mmc3 = &sdio1;
serial0 = &uart0;
serial1 = &uart1;
serial2 = &uart2;
--
2.35.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: fix MMC compatibles for rk3288
2022-01-25 11:50 [PATCH] ARM: dts: rockchip: fix MMC compatibles for rk3288 John Keeping
@ 2022-01-25 12:14 ` Johan Jonker
2022-01-26 11:17 ` John Keeping
0 siblings, 1 reply; 3+ messages in thread
From: Johan Jonker @ 2022-01-25 12:14 UTC (permalink / raw)
To: John Keeping, Heiko Stuebner
Cc: Rob Herring, linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
Hi John,
MMC aliases should go in the dts board files.
Sort on reg address, based on availability and without number gab.
(For rk3288 a lot of boards to change. That's why it wasn't done
yet...Could someone pick that up?)
Johan
On 1/25/22 12:50, John Keeping wrote:
> Prior to commit 4bac670aa5cb ("mmc: dw_mmc: rockchip: use common_caps")
> the mshcN aliases were used in an unusual way by the dw_mmc driver and
> affected behaviour. Now that this has been fixed, rename the mmc
> aliases to use the standard form.
>
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index aaaa61875701..50fa0a4652b5 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -25,10 +25,10 @@ aliases {
> i2c3 = &i2c3;
> i2c4 = &i2c4;
> i2c5 = &i2c5;
> - mshc0 = &emmc;
> - mshc1 = &sdmmc;
> - mshc2 = &sdio0;
> - mshc3 = &sdio1;
> + mmc0 = &emmc;
> + mmc1 = &sdmmc;
> + mmc2 = &sdio0;
> + mmc3 = &sdio1;
> serial0 = &uart0;
> serial1 = &uart1;
> serial2 = &uart2;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: fix MMC compatibles for rk3288
2022-01-25 12:14 ` Johan Jonker
@ 2022-01-26 11:17 ` John Keeping
0 siblings, 0 replies; 3+ messages in thread
From: John Keeping @ 2022-01-26 11:17 UTC (permalink / raw)
To: Johan Jonker
Cc: Heiko Stuebner, Rob Herring, linux-arm-kernel, linux-rockchip,
devicetree, linux-kernel
Hi Johan,
On Tue, Jan 25, 2022 at 01:14:21PM +0100, Johan Jonker wrote:
> MMC aliases should go in the dts board files.
> Sort on reg address, based on availability and without number gab.
> (For rk3288 a lot of boards to change. That's why it wasn't done
> yet...Could someone pick that up?)
Since there aren't any mmc aliases for rk3288 at the moment, I'll drop
this and send a patch adding them for the one board I have access to.
At some point the nonstandard mshc aliases should be removed, but it
may be best to keep them around for a while given that 5.17 will be the
first kernel that doesn't use these as a weird mechanism for per-port
settings.
> On 1/25/22 12:50, John Keeping wrote:
> > Prior to commit 4bac670aa5cb ("mmc: dw_mmc: rockchip: use common_caps")
> > the mshcN aliases were used in an unusual way by the dw_mmc driver and
> > affected behaviour. Now that this has been fixed, rename the mmc
> > aliases to use the standard form.
> >
> > Signed-off-by: John Keeping <john@metanate.com>
> > ---
> > arch/arm/boot/dts/rk3288.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> > index aaaa61875701..50fa0a4652b5 100644
> > --- a/arch/arm/boot/dts/rk3288.dtsi
> > +++ b/arch/arm/boot/dts/rk3288.dtsi
> > @@ -25,10 +25,10 @@ aliases {
> > i2c3 = &i2c3;
> > i2c4 = &i2c4;
> > i2c5 = &i2c5;
> > - mshc0 = &emmc;
> > - mshc1 = &sdmmc;
> > - mshc2 = &sdio0;
> > - mshc3 = &sdio1;
> > + mmc0 = &emmc;
> > + mmc1 = &sdmmc;
> > + mmc2 = &sdio0;
> > + mmc3 = &sdio1;
> > serial0 = &uart0;
> > serial1 = &uart1;
> > serial2 = &uart2;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-26 11:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 11:50 [PATCH] ARM: dts: rockchip: fix MMC compatibles for rk3288 John Keeping
2022-01-25 12:14 ` Johan Jonker
2022-01-26 11:17 ` John Keeping
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).