* [PATCH] phy: cpcap-usb: add MUSB dependency
@ 2017-06-09 10:16 Arnd Bergmann
2017-06-09 11:47 ` Sebastian Reichel
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2017-06-09 10:16 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Sebastian Reichel, Arnd Bergmann, Tony Lindgren, Rob Herring,
linux-kernel
When MUSB is a loadable module, we get a link error for a built-in
CPCAP driver:
drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
This adds a Kconfig dependency to prevent this broken configuration,
enforcing that CPCAP can only be a module when MUSB is also a module.
Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/motorola/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig
index 91a46cffd639..6bb7d6bdf1bf 100644
--- a/drivers/phy/motorola/Kconfig
+++ b/drivers/phy/motorola/Kconfig
@@ -4,6 +4,7 @@
config PHY_CPCAP_USB
tristate "CPCAP PMIC USB PHY driver"
depends on USB_SUPPORT && IIO
+ depends on USB_MUSB_HDRC || USB_MUSB_HDRC=n
select GENERIC_PHY
select USB_PHY
help
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: cpcap-usb: add MUSB dependency
2017-06-09 10:16 [PATCH] phy: cpcap-usb: add MUSB dependency Arnd Bergmann
@ 2017-06-09 11:47 ` Sebastian Reichel
2017-06-09 12:00 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Reichel @ 2017-06-09 11:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Kishon Vijay Abraham I, Tony Lindgren, Rob Herring, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
Hi,
On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote:
> When MUSB is a loadable module, we get a link error for a built-in
> CPCAP driver:
>
> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
>
> This adds a Kconfig dependency to prevent this broken configuration,
> enforcing that CPCAP can only be a module when MUSB is also a module.
>
> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
-- Sebastian
> ---
> drivers/phy/motorola/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig
> index 91a46cffd639..6bb7d6bdf1bf 100644
> --- a/drivers/phy/motorola/Kconfig
> +++ b/drivers/phy/motorola/Kconfig
> @@ -4,6 +4,7 @@
> config PHY_CPCAP_USB
> tristate "CPCAP PMIC USB PHY driver"
> depends on USB_SUPPORT && IIO
> + depends on USB_MUSB_HDRC || USB_MUSB_HDRC=n
> select GENERIC_PHY
> select USB_PHY
> help
> --
> 2.9.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: cpcap-usb: add MUSB dependency
2017-06-09 11:47 ` Sebastian Reichel
@ 2017-06-09 12:00 ` Kishon Vijay Abraham I
2017-06-12 8:09 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Kishon Vijay Abraham I @ 2017-06-09 12:00 UTC (permalink / raw)
To: Sebastian Reichel, Arnd Bergmann; +Cc: Tony Lindgren, Rob Herring, linux-kernel
On Friday 09 June 2017 05:17 PM, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote:
>> When MUSB is a loadable module, we get a link error for a built-in
>> CPCAP driver:
>>
>> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
>> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
>>
>> This adds a Kconfig dependency to prevent this broken configuration,
>> enforcing that CPCAP can only be a module when MUSB is also a module.
>>
>> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
merged, thanks!
-Kishon
>
> -- Sebastian
>
>> ---
>> drivers/phy/motorola/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig
>> index 91a46cffd639..6bb7d6bdf1bf 100644
>> --- a/drivers/phy/motorola/Kconfig
>> +++ b/drivers/phy/motorola/Kconfig
>> @@ -4,6 +4,7 @@
>> config PHY_CPCAP_USB
>> tristate "CPCAP PMIC USB PHY driver"
>> depends on USB_SUPPORT && IIO
>> + depends on USB_MUSB_HDRC || USB_MUSB_HDRC=n
>> select GENERIC_PHY
>> select USB_PHY
>> help
>> --
>> 2.9.0
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: cpcap-usb: add MUSB dependency
2017-06-09 12:00 ` Kishon Vijay Abraham I
@ 2017-06-12 8:09 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2017-06-12 8:09 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Sebastian Reichel, Arnd Bergmann, Rob Herring, linux-kernel
* Kishon Vijay Abraham I <kishon@ti.com> [170609 05:04]:
>
>
> On Friday 09 June 2017 05:17 PM, Sebastian Reichel wrote:
> > Hi,
> >
> > On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote:
> >> When MUSB is a loadable module, we get a link error for a built-in
> >> CPCAP driver:
> >>
> >> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
> >> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
> >>
> >> This adds a Kconfig dependency to prevent this broken configuration,
> >> enforcing that CPCAP can only be a module when MUSB is also a module.
> >>
> >> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>
> merged, thanks!
Yup thanks for fixing it.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-12 8:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-09 10:16 [PATCH] phy: cpcap-usb: add MUSB dependency Arnd Bergmann
2017-06-09 11:47 ` Sebastian Reichel
2017-06-09 12:00 ` Kishon Vijay Abraham I
2017-06-12 8:09 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).