From: Juergen Gross <jgross@suse.com>
To: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
linux-s390@vger.kernel.org, xen-devel@lists.xenproject.org,
kvm@vger.kernel.org
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
mingo@redhat.com, peterz@infradead.org,
paulmck@linux.vnet.ibm.com, will.deacon@arm.com,
kernellwp@gmail.com, pbonzini@redhat.com, bsingharora@gmail.com,
boqun.feng@gmail.com, borntraeger@de.ibm.com, rkrcmar@redhat.com,
David Vrabel <david.vrabel@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v5 7/9] x86, xen: support vcpu preempted check
Date: Fri, 21 Oct 2016 07:08:19 +0200 [thread overview]
Message-ID: <7ebcc196-e483-097c-41c8-070b46297c9d@suse.com> (raw)
In-Reply-To: <1476998874-2089-8-git-send-email-xinhui.pan@linux.vnet.ibm.com>
Corrected xen-devel mailing list address, added other Xen maintainers
On 20/10/16 23:27, Pan Xinhui wrote:
> From: Juergen Gross <jgross@suse.com>
>
> Support the vcpu_is_preempted() functionality under Xen. This will
> enhance lock performance on overcommitted hosts (more runnable vcpus
> than physical cpus in the system) as doing busy waits for preempted
> vcpus will hurt system performance far worse than early yielding.
>
> A quick test (4 vcpus on 1 physical cpu doing a parallel build job
> with "make -j 8") reduced system time by about 5% with this patch.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
> ---
> arch/x86/xen/spinlock.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c
> index 3d6e006..74756bb 100644
> --- a/arch/x86/xen/spinlock.c
> +++ b/arch/x86/xen/spinlock.c
> @@ -114,7 +114,6 @@ void xen_uninit_lock_cpu(int cpu)
> per_cpu(irq_name, cpu) = NULL;
> }
>
> -
> /*
> * Our init of PV spinlocks is split in two init functions due to us
> * using paravirt patching and jump labels patching and having to do
> @@ -137,6 +136,8 @@ void __init xen_init_spinlocks(void)
> pv_lock_ops.queued_spin_unlock = PV_CALLEE_SAVE(__pv_queued_spin_unlock);
> pv_lock_ops.wait = xen_qlock_wait;
> pv_lock_ops.kick = xen_qlock_kick;
> +
> + pv_lock_ops.vcpu_is_preempted = xen_vcpu_stolen;
> }
>
> /*
>
next prev parent reply other threads:[~2016-10-21 5:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 21:27 [PATCH v5 0/9] implement vcpu preempted check Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 1/9] kernel/sched: introduce vcpu preempted check interface Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 2/9] locking/osq: Drop the overload of osq_lock() Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 3/9] kernel/locking: Drop the overload of {mutex,rwsem}_spin_on_owner Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 4/9] powerpc/spinlock: support vcpu preempted check Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 5/9] x86, paravirt: Add interface to support kvm/xen " Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 6/9] x86, kvm: support " Pan Xinhui
2016-10-24 8:08 ` xinhui
2016-10-20 21:27 ` [PATCH v5 7/9] x86, xen: " Pan Xinhui
2016-10-21 5:08 ` Juergen Gross [this message]
2016-10-20 21:27 ` [PATCH v5 8/9] s390/spinlock: Provide vcpu_is_preempted Pan Xinhui
2016-10-20 21:27 ` [PATCH v5 9/9] Documentation: virtual: kvm: Support vcpu preempted check Pan Xinhui
2016-10-21 1:23 ` Boqun Feng
2016-10-21 11:27 ` David Laight
2016-10-21 18:39 ` rkrcmar
2016-10-24 2:46 ` xinhui
2016-10-24 14:42 ` Paolo Bonzini
2016-10-24 15:05 ` rkrcmar
2016-10-24 2:44 ` xinhui
2016-10-24 8:12 ` xinhui
2016-10-21 5:40 ` [PATCH v5 0/9] implement " Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ebcc196-e483-097c-41c8-070b46297c9d@suse.com \
--to=jgross@suse.com \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=borntraeger@de.ibm.com \
--cc=bsingharora@gmail.com \
--cc=david.vrabel@citrix.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xinhui.pan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).