From: "Rafał Miłecki" <zajec5@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [GIT PULL] vboxsf fixes for 5.14-1
Date: Wed, 14 Jul 2021 17:59:19 +0200 [thread overview]
Message-ID: <7f4a96bc-3912-dfb6-4a32-f0c6487d977b@gmail.com> (raw)
In-Reply-To: <YO755O8JnxG44YaT@kroah.com>
On 14.07.2021 16:51, Greg KH wrote:
> On Wed, Jul 14, 2021 at 12:50:08PM +0200, Rafał Miłecki wrote:
>> Hi Alexander,
>>
>> On 13.07.2021 22:14, Al Viro wrote:
>>> To elaborate a bit - there's one case when I want it to go through
>>> vfs.git, and that's when there's an interference between something
>>> going on in vfs.git and the work done in filesystem. Other than
>>> that, I'm perfectly fine with maintainer sending pull request directly
>>> to Linus (provided that I hadn't spotted something obviously wrong
>>> in the series, of course, but that's not "I want it to go through
>>> vfs.git" - that's "I don't want it in mainline until such and such
>>> bug is resolved").
>>
>> let me take this opportunity to ask about another filesystem.
>>
>> Would you advise to send pull req for the fs/ntfs3 directly to Linus?
>>
>> That is a pending filesystem that happens to be highly expected by many
>> Linux focused communities.
>>
>>
>> Paragon Software GmbH proved it's commitment by sending as many as 26
>> versions on it's patchset. The last set was send early April:
>>
>> [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
>> https://marc.info/?l=linux-fsdevel&m=161738417018673&q=mbox
>> https://patchwork.kernel.org/project/linux-fsdevel/list/?series=460291
>>
>>
>> I'd say there weren't any serious issues raised since then.
>>
>> One Tested-by, one maintenance question, one remainder, one clang-12
>> issue [0] [1].
>>
>> It seems this filesystem only needs:
>> 1. [Requirement] Adjusting to the meanwhile changed iov API [2]
>> 2. [Clean up] Using fs/iomap/ helpers [3]
>
> Why haven't those things been done and the patches resubmitted for
> review? Nothing we can do from our side when the developers don't want
> to submit a new series, right?
The real issue (broken compilation) has been pointed out 2 days ago and
is a result of a more recent commit. For months filesystem could be
pushed but it wasn't for unknown reason.
As for fs/iomap/ helpers it's unclear to me if that is really required
or could be worked on later as a clean up. Darrick joked his opinion on
using those helper is biased.
In short I'd say: missing feedback.
next prev parent reply other threads:[~2021-07-14 15:59 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 10:45 [GIT PULL] vboxsf fixes for 5.14-1 Hans de Goede
2021-07-13 19:15 ` Linus Torvalds
2021-07-13 20:14 ` Al Viro
2021-07-13 20:18 ` Al Viro
2021-07-13 20:24 ` Randy Dunlap
2021-07-13 20:32 ` Al Viro
2021-07-13 21:43 ` Randy Dunlap
2021-07-14 10:50 ` Rafał Miłecki
2021-07-14 14:13 ` Christoph Hellwig
2021-07-14 14:51 ` Greg KH
2021-07-14 15:59 ` Rafał Miłecki [this message]
2021-07-14 16:05 ` Matthew Wilcox
2021-07-14 16:18 ` Rafał Miłecki
2021-07-15 21:50 ` Neal Gompa
2021-07-16 11:46 ` Leonidas P. Papadakos
2021-07-16 18:07 ` Linus Torvalds
2021-07-30 15:55 ` Konstantin Komarov
2021-07-30 17:23 ` Paragon NTFSv3 (was Re: [GIT PULL] vboxsf fixes for 5.14-1) Linus Torvalds
2021-08-13 16:11 ` Konstantin Komarov
2021-08-15 20:32 ` Stephen Rothwell
2021-08-16 3:00 ` Kari Argillander
2021-09-02 21:55 ` Linus Torvalds
2021-08-03 22:48 ` [GIT PULL] vboxsf fixes for 5.14-1 Theodore Ts'o
2021-08-03 23:44 ` Matthew Wilcox
2021-08-04 0:04 ` Theodore Ts'o
2021-08-04 0:10 ` Linus Torvalds
2021-08-04 0:49 ` Theodore Ts'o
2021-08-04 1:03 ` Darrick J. Wong
2021-08-04 6:38 ` Kari Argillander
2021-08-04 16:30 ` Theodore Ts'o
2021-08-05 15:48 ` Konstantin Komarov
2021-08-10 7:02 ` Darrick J. Wong
2021-09-02 22:09 ` NTFS testing (was: " Szabolcs Szakacsits
2021-09-03 17:48 ` Eric Biggers
2021-09-03 21:17 ` Szabolcs Szakacsits
2021-07-17 16:47 ` Pali Rohár
2021-07-14 16:13 ` Darrick J. Wong
2021-07-14 16:18 ` Christoph Hellwig
2021-07-14 16:38 ` Gao Xiang
2021-07-14 20:03 ` Eric W. Biederman
2021-07-15 22:14 ` Darrick J. Wong
2021-07-13 19:17 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f4a96bc-3912-dfb6-4a32-f0c6487d977b@gmail.com \
--to=zajec5@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=djwong@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).