* [PATCH] staging: greybus: tools: Fix braces {} style
@ 2020-03-22 17:30 Simran Singhal
2020-03-22 18:34 ` [greybus-dev] " Alex Elder
0 siblings, 1 reply; 2+ messages in thread
From: Simran Singhal @ 2020-03-22 17:30 UTC (permalink / raw)
To: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev, devel,
linux-kernel, outreachy-kernel
This patch fixes the check reported by checkpatch.pl
for braces {} should be used on all arms of this statement.
Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
---
drivers/staging/greybus/tools/loopback_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
index ba6f905f26fa..d46721502897 100644
--- a/drivers/staging/greybus/tools/loopback_test.c
+++ b/drivers/staging/greybus/tools/loopback_test.c
@@ -801,8 +801,9 @@ static void prepare_devices(struct loopback_test *t)
write_sysfs_val(t->devices[i].sysfs_entry,
"outstanding_operations_max",
t->async_outstanding_operations);
- } else
+ } else {
write_sysfs_val(t->devices[i].sysfs_entry, "async", 0);
+ }
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [greybus-dev] [PATCH] staging: greybus: tools: Fix braces {} style
2020-03-22 17:30 [PATCH] staging: greybus: tools: Fix braces {} style Simran Singhal
@ 2020-03-22 18:34 ` Alex Elder
0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2020-03-22 18:34 UTC (permalink / raw)
To: Simran Singhal, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
greybus-dev, devel, linux-kernel, outreachy-kernel
On 3/22/20 12:30 PM, Simran Singhal wrote:
> This patch fixes the check reported by checkpatch.pl
> for braces {} should be used on all arms of this statement.
>
> Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
Looks fine to me. And I saw no other instances of this in the
Greybus code. Thanks for the patch.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/staging/greybus/tools/loopback_test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
> index ba6f905f26fa..d46721502897 100644
> --- a/drivers/staging/greybus/tools/loopback_test.c
> +++ b/drivers/staging/greybus/tools/loopback_test.c
> @@ -801,8 +801,9 @@ static void prepare_devices(struct loopback_test *t)
> write_sysfs_val(t->devices[i].sysfs_entry,
> "outstanding_operations_max",
> t->async_outstanding_operations);
> - } else
> + } else {
> write_sysfs_val(t->devices[i].sysfs_entry, "async", 0);
> + }
> }
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-22 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-22 17:30 [PATCH] staging: greybus: tools: Fix braces {} style Simran Singhal
2020-03-22 18:34 ` [greybus-dev] " Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).