From: Kevin Hilman <khilman@baylibre.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] mmc: meson-gx: drop of_match_ptr from of_device_id table
Date: Tue, 03 Nov 2020 09:03:08 -0800 [thread overview]
Message-ID: <7h4km6xtir.fsf@baylibre.com> (raw)
In-Reply-To: <20201103163046.14336-1-krzk@kernel.org>
Krzysztof Kozlowski <krzk@kernel.org> writes:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here). This fixes
> compile warning (!CONFIG_OF && !CONFIG_MODULES):
>
> drivers/mmc/host/meson-gx-mmc.c:1252:34: warning:
> ‘meson_mmc_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks for the fix.
Acked-by: Kevin Hilman <khilman@baylibre.com>
Kevin
next prev parent reply other threads:[~2020-11-03 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 16:30 [PATCH] mmc: meson-gx: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-11-03 17:03 ` Kevin Hilman [this message]
2020-11-05 12:59 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h4km6xtir.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).