* [PATCH] mmc: meson-gx: drop of_match_ptr from of_device_id table
@ 2020-11-03 16:30 Krzysztof Kozlowski
2020-11-03 17:03 ` Kevin Hilman
2020-11-05 12:59 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-03 16:30 UTC (permalink / raw)
To: Ulf Hansson, Kevin Hilman, Neil Armstrong, Jerome Brunet,
Martin Blumenstingl, linux-mmc, linux-arm-kernel, linux-amlogic,
linux-kernel
Cc: Krzysztof Kozlowski, kernel test robot
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it is not relevant here). This fixes
compile warning (!CONFIG_OF && !CONFIG_MODULES):
drivers/mmc/host/meson-gx-mmc.c:1252:34: warning:
‘meson_mmc_of_match’ defined but not used [-Wunused-const-variable=]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mmc/host/meson-gx-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 4ec41579940a..13f6a2c0ed04 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1265,7 +1265,7 @@ static struct platform_driver meson_mmc_driver = {
.driver = {
.name = DRIVER_NAME,
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
- .of_match_table = of_match_ptr(meson_mmc_of_match),
+ .of_match_table = meson_mmc_of_match,
},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: meson-gx: drop of_match_ptr from of_device_id table
2020-11-03 16:30 [PATCH] mmc: meson-gx: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
@ 2020-11-03 17:03 ` Kevin Hilman
2020-11-05 12:59 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2020-11-03 17:03 UTC (permalink / raw)
To: Krzysztof Kozlowski, Ulf Hansson, Neil Armstrong, Jerome Brunet,
Martin Blumenstingl, linux-mmc, linux-arm-kernel, linux-amlogic,
linux-kernel
Cc: Krzysztof Kozlowski, kernel test robot
Krzysztof Kozlowski <krzk@kernel.org> writes:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here). This fixes
> compile warning (!CONFIG_OF && !CONFIG_MODULES):
>
> drivers/mmc/host/meson-gx-mmc.c:1252:34: warning:
> ‘meson_mmc_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks for the fix.
Acked-by: Kevin Hilman <khilman@baylibre.com>
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: meson-gx: drop of_match_ptr from of_device_id table
2020-11-03 16:30 [PATCH] mmc: meson-gx: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-11-03 17:03 ` Kevin Hilman
@ 2020-11-05 12:59 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-11-05 12:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kevin Hilman, Neil Armstrong, Jerome Brunet, Martin Blumenstingl,
linux-mmc, Linux ARM, open list:ARM/Amlogic Meson...,
Linux Kernel Mailing List, kernel test robot
On Tue, 3 Nov 2020 at 17:30, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here). This fixes
> compile warning (!CONFIG_OF && !CONFIG_MODULES):
>
> drivers/mmc/host/meson-gx-mmc.c:1252:34: warning:
> ‘meson_mmc_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 4ec41579940a..13f6a2c0ed04 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1265,7 +1265,7 @@ static struct platform_driver meson_mmc_driver = {
> .driver = {
> .name = DRIVER_NAME,
> .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> - .of_match_table = of_match_ptr(meson_mmc_of_match),
> + .of_match_table = meson_mmc_of_match,
> },
> };
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-05 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03 16:30 [PATCH] mmc: meson-gx: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-11-03 17:03 ` Kevin Hilman
2020-11-05 12:59 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).