* [PATCH RESEND] dt-bindings: power: Fix dt_binding_check error
@ 2020-02-28 2:14 Jianxin Pan
2020-02-29 16:28 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Jianxin Pan @ 2020-02-28 2:14 UTC (permalink / raw)
To: Stephen Rothwell, Kevin Hilman, linux-amlogic
Cc: Jianxin Pan, Rob Herring, devicetree, Neil Armstrong,
Jerome Brunet, Martin Blumenstingl, linux-pm, linux-kernel,
linux-arm-kernel
Missing ';' in the end of secure-monitor example node.
Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings")
Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
index af32209..bc4e037 100644
--- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
+++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
@@ -36,5 +36,5 @@ examples:
compatible = "amlogic,meson-a1-pwrc";
#power-domain-cells = <1>;
};
- }
+ };
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] dt-bindings: power: Fix dt_binding_check error
2020-02-28 2:14 [PATCH RESEND] dt-bindings: power: Fix dt_binding_check error Jianxin Pan
@ 2020-02-29 16:28 ` Kevin Hilman
2020-03-02 15:58 ` Jianxin Pan
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2020-02-29 16:28 UTC (permalink / raw)
To: Jianxin Pan, Stephen Rothwell, linux-amlogic
Cc: Jianxin Pan, Rob Herring, devicetree, Neil Armstrong,
Jerome Brunet, Martin Blumenstingl, linux-pm, linux-kernel,
linux-arm-kernel
Hi Jianxin,
Jianxin Pan <jianxin.pan@amlogic.com> writes:
> Missing ';' in the end of secure-monitor example node.
>
> Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings")
Thanks for the fix, but where did this commit ID come from? I think
this is the right upstream commit:
Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
Also, when you resend, can you cc soc@kernel.org. The soc maintainers
are who queue my amlogic tree. I will ack and they can submit to Linus
for v5.7 so Stephen doesn't have to carry his local linux-next fix
anymore.
Thanks,
Kevin
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> index af32209..bc4e037 100644
> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> @@ -36,5 +36,5 @@ examples:
> compatible = "amlogic,meson-a1-pwrc";
> #power-domain-cells = <1>;
> };
> - }
> + };
>
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] dt-bindings: power: Fix dt_binding_check error
2020-02-29 16:28 ` Kevin Hilman
@ 2020-03-02 15:58 ` Jianxin Pan
0 siblings, 0 replies; 3+ messages in thread
From: Jianxin Pan @ 2020-03-02 15:58 UTC (permalink / raw)
To: Kevin Hilman, Stephen Rothwell, linux-amlogic
Cc: Rob Herring, devicetree, Neil Armstrong, Jerome Brunet,
Martin Blumenstingl, linux-pm, linux-kernel, linux-arm-kernel
Hi Kevin,
On 2020/3/1 0:28, Kevin Hilman wrote:
> Hi Jianxin,
>
> Jianxin Pan <jianxin.pan@amlogic.com> writes:
>
>> Missing ';' in the end of secure-monitor example node.
>>
>> Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings")
>
> Thanks for the fix, but where did this commit ID come from? I think
> this is the right upstream commit:
>
> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
>
> Also, when you resend, can you cc soc@kernel.org. The soc maintainers
> are who queue my amlogic tree. I will ack and they can submit to Linus
> for v5.7 so Stephen doesn't have to carry his local linux-next fix
> anymore.
>
> Thanks,
The commit id is not correct, it from my local branch.
I corrected it and added soc maintainers to the cc list.
Thanks for your time.
>
> Kevin
>
>> Reported-by: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
>> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> index af32209..bc4e037 100644
>> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> @@ -36,5 +36,5 @@ examples:
>> compatible = "amlogic,meson-a1-pwrc";
>> #power-domain-cells = <1>;
>> };
>> - }
>> + };
>>
>> --
>> 2.7.4
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-02 15:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 2:14 [PATCH RESEND] dt-bindings: power: Fix dt_binding_check error Jianxin Pan
2020-02-29 16:28 ` Kevin Hilman
2020-03-02 15:58 ` Jianxin Pan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).