* [PATCH 1/3] arm64: dts: meson-g12a: specify suspend OPP
2019-08-27 10:03 [PATCH 0/3] arm64: dts: meson-g12: specify suspend OPP Neil Armstrong
@ 2019-08-27 10:03 ` Neil Armstrong
2019-08-27 10:03 ` [PATCH 2/3] arm64: dts: meson-sm1: " Neil Armstrong
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2019-08-27 10:03 UTC (permalink / raw)
To: khilman; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
Tag the 1,2GHz OPP as suspend OPP to be set before going in suspend mode.
It has been reported that using various OPPs can lead to error or
resume with a different OPP from the ROM, thus use this safe OPP as
it is the default OPP used by the BL2 boot firmware.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi
index 733a9d46fc4b..57c880c06a07 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi
@@ -81,6 +81,7 @@
opp-1200000000 {
opp-hz = /bits/ 64 <1200000000>;
opp-microvolt = <731000>;
+ opp-suspend;
};
opp-1398000000 {
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] arm64: dts: meson-sm1: specify suspend OPP
2019-08-27 10:03 [PATCH 0/3] arm64: dts: meson-g12: specify suspend OPP Neil Armstrong
2019-08-27 10:03 ` [PATCH 1/3] arm64: dts: meson-g12a: " Neil Armstrong
@ 2019-08-27 10:03 ` Neil Armstrong
2019-08-27 10:03 ` [PATCH 3/3] arm64: dts: meson-g12b: " Neil Armstrong
2019-08-27 21:56 ` [PATCH 0/3] arm64: dts: meson-g12: " Kevin Hilman
3 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2019-08-27 10:03 UTC (permalink / raw)
To: khilman; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
Tag the 1,2GHz OPP as suspend OPP to be set before going in suspend mode.
It has been reported that using various OPPs can lead to error or
resume with a different OPP from the ROM, thus use this safe OPP as
it is the default OPP used by the BL2 boot firmware.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
index e4830cbf7ed5..32e2de2614b1 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
@@ -82,6 +82,7 @@
opp-1200000000 {
opp-hz = /bits/ 64 <1200000000>;
opp-microvolt = <780000>;
+ opp-suspend;
};
opp-1404000000 {
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/3] arm64: dts: meson-g12b: specify suspend OPP
2019-08-27 10:03 [PATCH 0/3] arm64: dts: meson-g12: specify suspend OPP Neil Armstrong
2019-08-27 10:03 ` [PATCH 1/3] arm64: dts: meson-g12a: " Neil Armstrong
2019-08-27 10:03 ` [PATCH 2/3] arm64: dts: meson-sm1: " Neil Armstrong
@ 2019-08-27 10:03 ` Neil Armstrong
2019-08-27 21:56 ` [PATCH 0/3] arm64: dts: meson-g12: " Kevin Hilman
3 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2019-08-27 10:03 UTC (permalink / raw)
To: khilman; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
Tag the 1,2GHz OPPs as suspend OPP to be set before going in suspend mode.
It has been reported that using various OPPs can lead to error or
resume with a different OPP from the ROM, thus use this safe OPP as
it is the default OPP used by the BL2 boot firmware on the 2 clusters.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi | 2 ++
arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi
index d61f43052a34..00ea181bc018 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi
@@ -39,6 +39,7 @@
opp-1200000000 {
opp-hz = /bits/ 64 <1200000000>;
opp-microvolt = <781000>;
+ opp-suspend;
};
opp-1398000000 {
@@ -99,6 +100,7 @@
opp-1200000000 {
opp-hz = /bits/ 64 <1200000000>;
opp-microvolt = <751000>;
+ opp-suspend;
};
opp-1398000000 {
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
index 046cc332d07f..d68323c6c780 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
@@ -39,6 +39,7 @@
opp-1200000000 {
opp-hz = /bits/ 64 <1200000000>;
opp-microvolt = <731000>;
+ opp-suspend;
};
opp-1398000000 {
@@ -99,6 +100,7 @@
opp-1200000000 {
opp-hz = /bits/ 64 <1200000000>;
opp-microvolt = <771000>;
+ opp-suspend;
};
opp-1398000000 {
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/3] arm64: dts: meson-g12: specify suspend OPP
2019-08-27 10:03 [PATCH 0/3] arm64: dts: meson-g12: specify suspend OPP Neil Armstrong
` (2 preceding siblings ...)
2019-08-27 10:03 ` [PATCH 3/3] arm64: dts: meson-g12b: " Neil Armstrong
@ 2019-08-27 21:56 ` Kevin Hilman
2019-08-29 18:32 ` Kevin Hilman
3 siblings, 1 reply; 6+ messages in thread
From: Kevin Hilman @ 2019-08-27 21:56 UTC (permalink / raw)
To: Neil Armstrong
Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
Neil Armstrong <narmstrong@baylibre.com> writes:
> Tag the 1,2GHz OPP as suspend OPP to be set before going in suspend mode,
> for the G12A, G12B and SM1 SoCs.
>
> It has been reported that using various OPPs can lead to error or
> resume with a different OPP from the ROM, thus use this safe OPP as
> it is the default OPP used by the BL2 boot firmware.
>
> Neil Armstrong (3):
> arm64: dts: meson-g12a: specify suspend OPP
> arm64: dts: meson-sm1: specify suspend OPP
> arm64: dts: meson-g12b: specify suspend OPP
Queued patches 1, 3 for v5.4.
The SM1 patch has a dependency on the SM1 DVFS series, which in turn has
a dependency on clock changes. Once I get a stable tag for the SM1
clock changes, I'll queue up the rest.
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/3] arm64: dts: meson-g12: specify suspend OPP
2019-08-27 21:56 ` [PATCH 0/3] arm64: dts: meson-g12: " Kevin Hilman
@ 2019-08-29 18:32 ` Kevin Hilman
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2019-08-29 18:32 UTC (permalink / raw)
To: Neil Armstrong
Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong
Kevin Hilman <khilman@baylibre.com> writes:
> Neil Armstrong <narmstrong@baylibre.com> writes:
>
>> Tag the 1,2GHz OPP as suspend OPP to be set before going in suspend mode,
>> for the G12A, G12B and SM1 SoCs.
>>
>> It has been reported that using various OPPs can lead to error or
>> resume with a different OPP from the ROM, thus use this safe OPP as
>> it is the default OPP used by the BL2 boot firmware.
>>
>> Neil Armstrong (3):
>> arm64: dts: meson-g12a: specify suspend OPP
>> arm64: dts: meson-sm1: specify suspend OPP
>> arm64: dts: meson-g12b: specify suspend OPP
>
> Queued patches 1, 3 for v5.4.
>
> The SM1 patch has a dependency on the SM1 DVFS series, which in turn has
> a dependency on clock changes. Once I get a stable tag for the SM1
> clock changes, I'll queue up the rest.
FYI... I decided not to queue these for v5.4.
I'm pretty sure we'll need these, but I I think we need to do a bit more
suspend/resume testing to be sure we have the right OPPs. here.
For now, this series is in my `v5.4/testing` branch, which is included
in `integ` so it can get a bit broader testing.
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread