* [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static
@ 2018-01-10 14:19 Wei Yongjun
2018-02-06 12:25 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2018-01-10 14:19 UTC (permalink / raw)
To: Carlo Caione, Kevin Hilman, Neil Armstrong, Arnaud Patard
Cc: Wei Yongjun, linux-arm-kernel, linux-amlogic, linux-kernel,
kernel-janitors
Fixes the following sparse warnings:
drivers/soc/amlogic/meson-gx-socinfo.c:100:12: warning:
symbol 'meson_gx_socinfo_init' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
index f2d8c3c..ea091f1 100644
--- a/drivers/soc/amlogic/meson-gx-socinfo.c
+++ b/drivers/soc/amlogic/meson-gx-socinfo.c
@@ -97,7 +97,7 @@ static const char *socinfo_to_soc_id(u32 socinfo)
return "Unknown";
}
-int __init meson_gx_socinfo_init(void)
+static int __init meson_gx_socinfo_init(void)
{
struct soc_device_attribute *soc_dev_attr;
struct soc_device *soc_dev;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static
2018-01-10 14:19 [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static Wei Yongjun
@ 2018-02-06 12:25 ` Neil Armstrong
2018-02-09 0:49 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2018-02-06 12:25 UTC (permalink / raw)
To: Wei Yongjun, Carlo Caione, Kevin Hilman, Arnaud Patard
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, kernel-janitors
On 10/01/2018 15:19, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> drivers/soc/amlogic/meson-gx-socinfo.c:100:12: warning:
> symbol 'meson_gx_socinfo_init' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
> index f2d8c3c..ea091f1 100644
> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
> @@ -97,7 +97,7 @@ static const char *socinfo_to_soc_id(u32 socinfo)
> return "Unknown";
> }
>
> -int __init meson_gx_socinfo_init(void)
> +static int __init meson_gx_socinfo_init(void)
> {
> struct soc_device_attribute *soc_dev_attr;
> struct soc_device *soc_dev;
>
>
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static
2018-02-06 12:25 ` Neil Armstrong
@ 2018-02-09 0:49 ` Kevin Hilman
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2018-02-09 0:49 UTC (permalink / raw)
To: Neil Armstrong
Cc: Wei Yongjun, Carlo Caione, Arnaud Patard, linux-arm-kernel,
linux-amlogic, linux-kernel, kernel-janitors
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 10/01/2018 15:19, Wei Yongjun wrote:
>> Fixes the following sparse warnings:
>>
>> drivers/soc/amlogic/meson-gx-socinfo.c:100:12: warning:
>> symbol 'meson_gx_socinfo_init' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
>> index f2d8c3c..ea091f1 100644
>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
>> @@ -97,7 +97,7 @@ static const char *socinfo_to_soc_id(u32 socinfo)
>> return "Unknown";
>> }
>>
>> -int __init meson_gx_socinfo_init(void)
>> +static int __init meson_gx_socinfo_init(void)
>> {
>> struct soc_device_attribute *soc_dev_attr;
>> struct soc_device *soc_dev;
>>
>>
>>
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Applied for v4.17, with Neil's ack.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-09 0:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10 14:19 [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static Wei Yongjun
2018-02-06 12:25 ` Neil Armstrong
2018-02-09 0:49 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).