* [PATCH v2] dt-bindings: media: adv7604: Fix slave map documentation
@ 2018-08-08 16:33 Kieran Bingham
2018-08-08 16:36 ` Laurent Pinchart
2018-08-13 19:16 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Kieran Bingham @ 2018-08-08 16:33 UTC (permalink / raw)
To: mchehab, Rob Herring, Mark Rutland, Hans Verkuil
Cc: Laurent Pinchart, linux-media, devicetree, linux-kernel,
Kieran Bingham, linux-renesas-soc, Michal Vokáč,
Kieran Bingham
The reg-names property in the documentation is missing an '='. Add it.
Fixes: 9feb786876c7 ("media: dt-bindings: media: adv7604: Extend
bindings to allow specifying slave map addresses")
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
v2:
- Commit title changed to prefix as "dt-bindings: media:"
If this is collected through a DT tree, I assume therefore this will be
fine, but if it is to go through the media-tree, please update as
necessaary to prevent the redundant dual "media:" tagging.
(I'll leave it to the maintainers to decide whose tree thise should go
through)
Thanks
Kieran
Documentation/devicetree/bindings/media/i2c/adv7604.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
index dcf57e7c60eb..b3e688b77a38 100644
--- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
+++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
@@ -66,7 +66,7 @@ Example:
* other maps will retain their default addresses.
*/
reg = <0x4c>, <0x66>;
- reg-names "main", "edid";
+ reg-names = "main", "edid";
reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>;
hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: media: adv7604: Fix slave map documentation
2018-08-08 16:33 [PATCH v2] dt-bindings: media: adv7604: Fix slave map documentation Kieran Bingham
@ 2018-08-08 16:36 ` Laurent Pinchart
2018-08-13 19:16 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2018-08-08 16:36 UTC (permalink / raw)
To: Kieran Bingham
Cc: mchehab, Rob Herring, Mark Rutland, Hans Verkuil, linux-media,
devicetree, linux-kernel, Kieran Bingham, linux-renesas-soc,
Michal Vokáč
Hi Kieran,
Thank you for the patch.
On Wednesday, 8 August 2018 19:33:51 EEST Kieran Bingham wrote:
> The reg-names property in the documentation is missing an '='. Add it.
>
> Fixes: 9feb786876c7 ("media: dt-bindings: media: adv7604: Extend
> bindings to allow specifying slave map addresses")
>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> v2:
> - Commit title changed to prefix as "dt-bindings: media:"
>
> If this is collected through a DT tree, I assume therefore this will be
> fine, but if it is to go through the media-tree, please update as
> necessaary to prevent the redundant dual "media:" tagging.
I assume Hans will take the patch in his tree and submit a pull request.
Mauro, this will then require special handling to avoid a rewrite of the
subject.
> (I'll leave it to the maintainers to decide whose tree thise should go
> through)
>
> Thanks
>
> Kieran
>
> Documentation/devicetree/bindings/media/i2c/adv7604.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> b/Documentation/devicetree/bindings/media/i2c/adv7604.txt index
> dcf57e7c60eb..b3e688b77a38 100644
> --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> @@ -66,7 +66,7 @@ Example:
> * other maps will retain their default addresses.
> */
> reg = <0x4c>, <0x66>;
> - reg-names "main", "edid";
> + reg-names = "main", "edid";
>
> reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>;
> hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: media: adv7604: Fix slave map documentation
2018-08-08 16:33 [PATCH v2] dt-bindings: media: adv7604: Fix slave map documentation Kieran Bingham
2018-08-08 16:36 ` Laurent Pinchart
@ 2018-08-13 19:16 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-08-13 19:16 UTC (permalink / raw)
To: Kieran Bingham
Cc: mchehab, Mark Rutland, Hans Verkuil, Laurent Pinchart,
linux-media, devicetree, linux-kernel, Kieran Bingham,
linux-renesas-soc, Michal Vokáč
On Wed, Aug 08, 2018 at 05:33:51PM +0100, Kieran Bingham wrote:
> The reg-names property in the documentation is missing an '='. Add it.
>
> Fixes: 9feb786876c7 ("media: dt-bindings: media: adv7604: Extend
> bindings to allow specifying slave map addresses")
>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> ---
> v2:
> - Commit title changed to prefix as "dt-bindings: media:"
>
> If this is collected through a DT tree, I assume therefore this will be
> fine, but if it is to go through the media-tree, please update as
> necessaary to prevent the redundant dual "media:" tagging.
>
> (I'll leave it to the maintainers to decide whose tree thise should go
> through)
>
> Thanks
>
> Kieran
>
> Documentation/devicetree/bindings/media/i2c/adv7604.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Rob Herring <robh@kernel.org>
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> index dcf57e7c60eb..b3e688b77a38 100644
> --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> @@ -66,7 +66,7 @@ Example:
> * other maps will retain their default addresses.
> */
> reg = <0x4c>, <0x66>;
> - reg-names "main", "edid";
> + reg-names = "main", "edid";
>
> reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>;
> hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-13 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-08 16:33 [PATCH v2] dt-bindings: media: adv7604: Fix slave map documentation Kieran Bingham
2018-08-08 16:36 ` Laurent Pinchart
2018-08-13 19:16 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).