* linux-next: build failure after merge of the nfs-anna tree
@ 2018-12-16 23:16 Stephen Rothwell
2018-12-17 11:18 ` Rasmus Villemoes
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2018-12-16 23:16 UTC (permalink / raw)
To: Anna Schumaker, Trond Myklebust, NFS Mailing List
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Rasmus Villemoes
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Hi all,
After merging the nfs-anna tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
/home/sfr/next/next/fs/nfs/nfsroot.c: In function 'root_nfs_data':
/home/sfr/next/next/fs/nfs/nfsroot.c:264:5: error: implicit declaration of function 'fmtcheck'; did you mean 'dst_check'? [-Werror=implicit-function-declaration]
fmtcheck(tmp, "%s", 0), utsname()->nodename);
^~~~~~~~
dst_check
Caused by commit
66ab6f062d96 ("nfs: use fmtcheck() in root_nfs_data")
For some reason this did not turn up until I was building the
hwmon-staging tree (maybe some Kconfig change casued it to be built now),
so I have just reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: build failure after merge of the nfs-anna tree
2018-12-16 23:16 linux-next: build failure after merge of the nfs-anna tree Stephen Rothwell
@ 2018-12-17 11:18 ` Rasmus Villemoes
2018-12-17 15:34 ` Anna Schumaker
0 siblings, 1 reply; 3+ messages in thread
From: Rasmus Villemoes @ 2018-12-17 11:18 UTC (permalink / raw)
To: Stephen Rothwell, Anna Schumaker, Trond Myklebust, NFS Mailing List
Cc: Linux Next Mailing List, Linux Kernel Mailing List
On 17/12/2018 00.16, Stephen Rothwell wrote:
> Hi all,
>
> After merging the nfs-anna tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> /home/sfr/next/next/fs/nfs/nfsroot.c: In function 'root_nfs_data':
> /home/sfr/next/next/fs/nfs/nfsroot.c:264:5: error: implicit declaration of function 'fmtcheck'; did you mean 'dst_check'? [-Werror=implicit-function-declaration]
> fmtcheck(tmp, "%s", 0), utsname()->nodename);
> ^~~~~~~~
> dst_check
>
> Caused by commit
>
> 66ab6f062d96 ("nfs: use fmtcheck() in root_nfs_data")
I didn't know anybody had picked that one up. It's completely safe to
just ignore that commit until the fmtcheck() utility is actually in.
Anna, can I take the fact that this was picked up as a sort-of implicit
ack, that I can use if and when I ever get around to resending the
fmtcheck() series? And for simplicitly, would you mind if the nfs patch
would just be routed along with the patches introducing fmtcheck()?
Rasmus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: build failure after merge of the nfs-anna tree
2018-12-17 11:18 ` Rasmus Villemoes
@ 2018-12-17 15:34 ` Anna Schumaker
0 siblings, 0 replies; 3+ messages in thread
From: Anna Schumaker @ 2018-12-17 15:34 UTC (permalink / raw)
To: Rasmus Villemoes, Stephen Rothwell, Trond Myklebust, NFS Mailing List
Cc: Linux Next Mailing List, Linux Kernel Mailing List
On Mon, 2018-12-17 at 12:18 +0100, Rasmus Villemoes wrote:
> On 17/12/2018 00.16, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the nfs-anna tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > /home/sfr/next/next/fs/nfs/nfsroot.c: In function 'root_nfs_data':
> > /home/sfr/next/next/fs/nfs/nfsroot.c:264:5: error: implicit declaration of
> > function 'fmtcheck'; did you mean 'dst_check'? [-Werror=implicit-function-
> > declaration]
> > fmtcheck(tmp, "%s", 0), utsname()->nodename);
> > ^~~~~~~~
> > dst_check
> >
> > Caused by commit
> >
> > 66ab6f062d96 ("nfs: use fmtcheck() in root_nfs_data")
>
> I didn't know anybody had picked that one up. It's completely safe to
> just ignore that commit until the fmtcheck() utility is actually in.
>
> Anna, can I take the fact that this was picked up as a sort-of implicit
> ack, that I can use if and when I ever get around to resending the
> fmtcheck() series? And for simplicitly, would you mind if the nfs patch
> would just be routed along with the patches introducing fmtcheck()?
Sure that sounds good. I'll remove it from my tree for now.
>
> Rasmus
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-17 15:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-16 23:16 linux-next: build failure after merge of the nfs-anna tree Stephen Rothwell
2018-12-17 11:18 ` Rasmus Villemoes
2018-12-17 15:34 ` Anna Schumaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).