* [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write()
@ 2016-11-08 9:16 Zhi Zhang
2016-11-08 13:48 ` Ilya Dryomov
2016-11-08 14:21 ` Yan, Zheng
0 siblings, 2 replies; 3+ messages in thread
From: Zhi Zhang @ 2016-11-08 9:16 UTC (permalink / raw)
To: Zheng Yan, Ilya Dryomov; +Cc: ceph-devel, linux-kernel
Fix printing wrong return variable for invalidate_inode_pages2_range
in ceph_direct_read_write().
Signed-off-by: Zhi Zhang <zhang.david2011@gmail.com>
---
fs/ceph/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 18630e8..0136195 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
pos >> PAGE_SHIFT,
(pos + count) >> PAGE_SHIFT);
if (ret2 < 0)
- dout("invalidate_inode_pages2_range returned
%d\n", ret);
+ dout("invalidate_inode_pages2_range returned
%d\n", ret2);
flags = CEPH_OSD_FLAG_ORDERSNAP |
CEPH_OSD_FLAG_ONDISK |
Regards,
Zhi Zhang (David)
Contact: zhang.david2011@gmail.com
zhangz.david@outlook.com
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write()
2016-11-08 9:16 [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write() Zhi Zhang
@ 2016-11-08 13:48 ` Ilya Dryomov
2016-11-08 14:21 ` Yan, Zheng
1 sibling, 0 replies; 3+ messages in thread
From: Ilya Dryomov @ 2016-11-08 13:48 UTC (permalink / raw)
To: Zhi Zhang; +Cc: Zheng Yan, ceph-devel, linux-kernel
On Tue, Nov 8, 2016 at 10:16 AM, Zhi Zhang <zhang.david2011@gmail.com> wrote:
> Fix printing wrong return variable for invalidate_inode_pages2_range
> in ceph_direct_read_write().
>
> Signed-off-by: Zhi Zhang <zhang.david2011@gmail.com>
> ---
> fs/ceph/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index 18630e8..0136195 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
> pos >> PAGE_SHIFT,
> (pos + count) >> PAGE_SHIFT);
> if (ret2 < 0)
> - dout("invalidate_inode_pages2_range returned
> %d\n", ret);
> + dout("invalidate_inode_pages2_range returned
> %d\n", ret2);
>
> flags = CEPH_OSD_FLAG_ORDERSNAP |
> CEPH_OSD_FLAG_ONDISK |
>
Applied.
(This is mangled, and had to be applied manually. Check out
Documentation/email-clients.txt in the kernel tree.)
Thanks,
Ilya
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write()
2016-11-08 9:16 [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write() Zhi Zhang
2016-11-08 13:48 ` Ilya Dryomov
@ 2016-11-08 14:21 ` Yan, Zheng
1 sibling, 0 replies; 3+ messages in thread
From: Yan, Zheng @ 2016-11-08 14:21 UTC (permalink / raw)
To: Zhi Zhang; +Cc: Ilya Dryomov, ceph-devel, linux-kernel
> On 8 Nov 2016, at 17:16, Zhi Zhang <zhang.david2011@gmail.com> wrote:
>
> Fix printing wrong return variable for invalidate_inode_pages2_range
> in ceph_direct_read_write().
>
> Signed-off-by: Zhi Zhang <zhang.david2011@gmail.com>
> ---
> fs/ceph/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index 18630e8..0136195 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
> pos >> PAGE_SHIFT,
> (pos + count) >> PAGE_SHIFT);
> if (ret2 < 0)
> - dout("invalidate_inode_pages2_range returned
> %d\n", ret);
> + dout("invalidate_inode_pages2_range returned
> %d\n", ret2);
>
> flags = CEPH_OSD_FLAG_ORDERSNAP |
> CEPH_OSD_FLAG_ONDISK |
>
>
Applied, Thanks
Yan, Zheng
> Regards,
> Zhi Zhang (David)
> Contact: zhang.david2011@gmail.com
> zhangz.david@outlook.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-08 14:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-08 9:16 [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write() Zhi Zhang
2016-11-08 13:48 ` Ilya Dryomov
2016-11-08 14:21 ` Yan, Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).