* [PATCH kvm-unit-tests] svm: Fix nmi hlt test to fail test correctly
@ 2020-04-28 18:41 Cathy Avery
2020-05-04 16:35 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Cathy Avery @ 2020-04-28 18:41 UTC (permalink / raw)
To: linux-kernel, kvm, pbonzini
The last test does not return vmmcall on fail resulting
in passing the entire test.
Signed-off-by: Cathy Avery <cavery@redhat.com>
---
x86/svm_tests.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/x86/svm_tests.c b/x86/svm_tests.c
index 2b84e4d..65008ba 100644
--- a/x86/svm_tests.c
+++ b/x86/svm_tests.c
@@ -1480,6 +1480,7 @@ static void nmi_hlt_test(struct svm_test *test)
if (!nmi_fired) {
report(nmi_fired, "intercepted pending NMI not dispatched");
set_test_stage(test, -1);
+ vmmcall();
}
set_test_stage(test, 3);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH kvm-unit-tests] svm: Fix nmi hlt test to fail test correctly
2020-04-28 18:41 [PATCH kvm-unit-tests] svm: Fix nmi hlt test to fail test correctly Cathy Avery
@ 2020-05-04 16:35 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-05-04 16:35 UTC (permalink / raw)
To: Cathy Avery, linux-kernel, kvm
On 28/04/20 20:41, Cathy Avery wrote:
> The last test does not return vmmcall on fail resulting
> in passing the entire test.
>
> Signed-off-by: Cathy Avery <cavery@redhat.com>
> ---
> x86/svm_tests.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/x86/svm_tests.c b/x86/svm_tests.c
> index 2b84e4d..65008ba 100644
> --- a/x86/svm_tests.c
> +++ b/x86/svm_tests.c
> @@ -1480,6 +1480,7 @@ static void nmi_hlt_test(struct svm_test *test)
> if (!nmi_fired) {
> report(nmi_fired, "intercepted pending NMI not dispatched");
> set_test_stage(test, -1);
> + vmmcall();
> }
>
> set_test_stage(test, 3);
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-04 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 18:41 [PATCH kvm-unit-tests] svm: Fix nmi hlt test to fail test correctly Cathy Avery
2020-05-04 16:35 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).