From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Pawel Laszczak <pawell@cadence.com>,
felipe.balbi@linux.intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, rogerq@ti.com,
linux-kernel@vger.kernel.org, jbergsagel@ti.com, nsekhar@ti.com,
nm@ti.com, sureshp@cadence.com, jpawar@cadence.com,
kurahul@cadence.com, aniljoy@cadence.com
Subject: Re: [PATCH v10 2/6] usb:common Separated decoding functions from dwc3 driver.
Date: Sun, 21 Jul 2019 13:54:35 -0700 [thread overview]
Message-ID: <817d0c88a2764ef07b4169bd0e2632f3e78c47d8.camel@perches.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1907211639390.9901-100000@netrider.rowland.org>
On Sun, 2019-07-21 at 16:45 -0400, Alan Stern wrote:
> On Sun, 21 Jul 2019, Joe Perches wrote:
>
> > On Sun, 2019-07-21 at 19:32 +0100, Pawel Laszczak wrote:
> > > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver
> > > to driver/usb/common/debug.c file. These moved functions include:
> > []
> > > diff --git a/drivers/usb/common/debug.c b/drivers/usb/common/debug.c
> > []
> > > +static void usb_decode_set_clear_feature(__u8 bRequestType, __u8 bRequest,
> > > + __u16 wValue, __u16 wIndex,
> > > + char *str, size_t size)
> >
> > It's probably not necessary to use Hungarian
> > when moving these functions into generic code.
>
> In fact, these are the well known and commonly accepted names for these
> data values, as given in the USB specification and used in many other
> places in the Linux USB stack. See for example the definition of
> struct usb_ctrlrequest in include/uapi/linux/usb/ch9.h.
>
> Changing them here would only make the code less readable.
Perhaps, but these have already been converted from
the __le types, so perhaps not. It might be more
sensible to convert the __u16 uses to u16 and avoid
the __le16 names.
cheers, Joe
next prev parent reply other threads:[~2019-07-21 20:54 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 18:32 [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2019-07-21 18:32 ` [PATCH v10 1/6] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2019-07-21 18:32 ` [PATCH v10 2/6] usb:common Separated decoding functions from dwc3 driver Pawel Laszczak
2019-07-21 19:05 ` Joe Perches
2019-07-21 20:45 ` Alan Stern
2019-07-21 20:54 ` Joe Perches [this message]
2019-07-22 10:06 ` Pawel Laszczak
2019-07-22 11:49 ` gregkh
2019-07-21 18:32 ` [PATCH v10 3/6] usb:common Patch simplify usb_decode_set_clear_feature function Pawel Laszczak
2019-07-21 19:07 ` Joe Perches
2019-07-22 10:12 ` Pawel Laszczak
2019-07-21 18:32 ` [PATCH v10 4/6] usb:common Simplify usb_decode_get_set_descriptor function Pawel Laszczak
2019-07-21 18:32 ` [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2019-07-31 3:36 ` Pawel Laszczak
2019-08-07 12:08 ` Roger Quadros
2019-08-11 11:59 ` Pawel Laszczak
2019-08-12 8:45 ` Roger Quadros
2019-08-12 9:43 ` Pawel Laszczak
2019-08-12 10:31 ` Heikki Krogerus
2019-08-12 11:05 ` Roger Quadros
2019-08-12 12:46 ` Felipe Balbi
2019-08-12 13:04 ` Roger Quadros
2019-08-13 5:15 ` Felipe Balbi
2019-08-13 7:30 ` Chunfeng Yun
2019-08-13 7:48 ` Roger Quadros
2019-08-13 8:50 ` Chunfeng Yun
2019-08-12 10:05 ` Roger Quadros
2019-08-12 11:10 ` Pawel Laszczak
2019-08-14 13:32 ` Roger Quadros
2019-08-15 6:10 ` Felipe Balbi
2019-08-19 8:20 ` Pawel Laszczak
2019-08-14 13:38 ` Roger Quadros
2019-08-14 14:30 ` Pawel Laszczak
2019-08-15 11:22 ` Roger Quadros
2019-08-19 10:30 ` Pawel Laszczak
2019-08-19 10:59 ` Roger Quadros
2019-08-23 8:53 ` Vignesh Raghavendra
2019-08-23 9:39 ` Pawel Laszczak
2019-08-26 2:16 ` Peter Chen
2019-08-26 7:53 ` Pawel Laszczak
2019-07-21 18:32 ` [PATCH v10 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer Pawel Laszczak
2019-07-21 19:03 ` [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver Pavel Machek
2019-07-22 9:58 ` Pawel Laszczak
2019-07-22 11:48 ` gregkh
2019-07-22 11:56 ` Pavel Machek
2019-07-22 12:11 ` gregkh
2019-07-22 12:11 ` Pawel Laszczak
2019-07-22 21:00 ` Pavel Machek
2019-07-23 4:32 ` Pawel Laszczak
2019-08-07 11:05 ` Roger Quadros
2019-08-08 4:12 ` Pawel Laszczak
2019-08-09 10:36 ` Roger Quadros
2019-08-09 10:44 ` Felipe Balbi
2019-08-13 8:22 ` Pavel Machek
2019-08-15 12:12 ` Roger Quadros
2019-08-15 14:39 ` Alan Stern
2019-08-19 12:08 ` Roger Quadros
2019-08-19 14:19 ` Alan Stern
2019-08-21 9:54 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=817d0c88a2764ef07b4169bd0e2632f3e78c47d8.camel@perches.com \
--to=joe@perches.com \
--cc=aniljoy@cadence.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbergsagel@ti.com \
--cc=jpawar@cadence.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).