* [PATCH][next] selftests/bpf: Fix spelling mistake "succesful" -> "successful"
@ 2022-08-17 8:34 Colin Ian King
2022-08-17 18:46 ` Mykola Lysenko
0 siblings, 1 reply; 3+ messages in thread
From: Colin Ian King @ 2022-08-17 8:34 UTC (permalink / raw)
To: Andrii Nakryiko, Mykola Lysenko, Daniel Borkmann,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Shuah Khan,
bpf, linux-kselftest
Cc: kernel-janitors, linux-kernel
There is a spelling mistake in an ASSERT_OK literal string. Fix it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
tools/testing/selftests/bpf/prog_tests/kfunc_call.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/kfunc_call.c b/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
index 351fafa006fb..eede7c304f86 100644
--- a/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
+++ b/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
@@ -109,7 +109,7 @@ static void test_destructive(void)
{
__u64 save_caps = 0;
- ASSERT_OK(test_destructive_open_and_load(), "succesful_load");
+ ASSERT_OK(test_destructive_open_and_load(), "successful_load");
if (!ASSERT_OK(cap_disable_effective(1ULL << CAP_SYS_BOOT, &save_caps), "drop_caps"))
return;
--
2.37.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] selftests/bpf: Fix spelling mistake "succesful" -> "successful"
2022-08-17 8:34 [PATCH][next] selftests/bpf: Fix spelling mistake "succesful" -> "successful" Colin Ian King
@ 2022-08-17 18:46 ` Mykola Lysenko
2022-08-17 19:00 ` Colin King (gmail)
0 siblings, 1 reply; 3+ messages in thread
From: Mykola Lysenko @ 2022-08-17 18:46 UTC (permalink / raw)
To: Colin Ian King
Cc: Mykola Lysenko, Andrii Nakryiko, Daniel Borkmann,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Shuah Khan,
bpf, linux-kselftest, kernel-janitors, linux-kernel
Hi Colin,
Thanks for your patch!
Can you change patch title to "[PATCH bpf-next] selftests/bpf: Fix spelling mistake "succesful” (kfunc_call.c)”?
Regards,
Mykola
> On Aug 17, 2022, at 1:34 AM, Colin Ian King <colin.i.king@gmail.com> wrote:
>
> !-------------------------------------------------------------------|
> This Message Is From an External Sender
>
> |-------------------------------------------------------------------!
>
> There is a spelling mistake in an ASSERT_OK literal string. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> tools/testing/selftests/bpf/prog_tests/kfunc_call.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/kfunc_call.c b/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
> index 351fafa006fb..eede7c304f86 100644
> --- a/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
> +++ b/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
> @@ -109,7 +109,7 @@ static void test_destructive(void)
> {
> __u64 save_caps = 0;
>
> - ASSERT_OK(test_destructive_open_and_load(), "succesful_load");
> + ASSERT_OK(test_destructive_open_and_load(), "successful_load");
>
> if (!ASSERT_OK(cap_disable_effective(1ULL << CAP_SYS_BOOT, &save_caps), "drop_caps"))
> return;
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] selftests/bpf: Fix spelling mistake "succesful" -> "successful"
2022-08-17 18:46 ` Mykola Lysenko
@ 2022-08-17 19:00 ` Colin King (gmail)
0 siblings, 0 replies; 3+ messages in thread
From: Colin King (gmail) @ 2022-08-17 19:00 UTC (permalink / raw)
On 17/08/2022 19:46, Mykola Lysenko wrote:
> Hi Colin,
>
> Thanks for your patch!
>
> Can you change patch title to "[PATCH bpf-next] selftests/bpf: Fix spelling mistake "succesful” (kfunc_call.c)”?
Personally I think the kfunc_call.c part in the title is extraneous,
it's clear it's patching that file from the diff and it's not the style
I've used of the 3,900+ patches I've had accepted in the kernel.
Colin
>
> Regards,
> Mykola
>
>> On Aug 17, 2022, at 1:34 AM, Colin Ian King <colin.i.king@gmail.com> wrote:
>>
>> !-------------------------------------------------------------------|
>> This Message Is From an External Sender
>>
>> |-------------------------------------------------------------------!
>>
>> There is a spelling mistake in an ASSERT_OK literal string. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>> tools/testing/selftests/bpf/prog_tests/kfunc_call.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/bpf/prog_tests/kfunc_call.c b/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
>> index 351fafa006fb..eede7c304f86 100644
>> --- a/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
>> +++ b/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
>> @@ -109,7 +109,7 @@ static void test_destructive(void)
>> {
>> __u64 save_caps = 0;
>>
>> - ASSERT_OK(test_destructive_open_and_load(), "succesful_load");
>> + ASSERT_OK(test_destructive_open_and_load(), "successful_load");
>>
>> if (!ASSERT_OK(cap_disable_effective(1ULL << CAP_SYS_BOOT, &save_caps), "drop_caps"))
>> return;
>> --
>> 2.37.1
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-17 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-17 8:34 [PATCH][next] selftests/bpf: Fix spelling mistake "succesful" -> "successful" Colin Ian King
2022-08-17 18:46 ` Mykola Lysenko
2022-08-17 19:00 ` Colin King (gmail)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).