linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] iio: mma8452: Add missed iio_device_unregister() call in mma8452_probe()
@ 2020-05-27 19:55 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-27 19:55 UTC (permalink / raw)
  To: Chuhong Yuan, linux-iio
  Cc: linux-kernel, Hartmut Knaack, Jonathan Cameron,
	Lars-Peter Clausen, Peter Meerwald-Stadler

> mma8452_probe() calls iio_device_register() but misses to call
> iio_device_unregister() when probe fails.
> Add the missed call in error handler to fix it.

How do you think about a wording variant like the following?

   Change description:
   The function “iio_device_register” was called here.
   But the function “iio_device_unregister” was not called after
   a call of the function “mma8452_set_freefall_mode” failed.
   Thus add the missed function call for one error case.


Would you like to add the tag “Fixes”?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-27 19:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 19:55 [PATCH] iio: mma8452: Add missed iio_device_unregister() call in mma8452_probe() Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).