From: Steev Klimaszewski <steev@kali.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, rjw@rjwysocki.net
Cc: lukasz.luba@arm.com, robh@kernel.org, heiko@sntech.de,
arnd@linaro.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, ulf.hansson@linaro.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v5 6/6] qcom/soc/drivers: Add DTPM description for sdm845
Date: Sun, 19 Dec 2021 12:44:26 -0600 [thread overview]
Message-ID: <818ed2a3-47d4-46d6-4bd3-ff2c7ff0192c@kali.org> (raw)
In-Reply-To: <79f91bbd-aa65-16d9-0fde-1f04c0690477@linaro.org>
Hi Daniel,
On 12/18/21 2:11 PM, Daniel Lezcano wrote:
> Hi Steev,
>
> thanks for taking the time to test the series.
My C630 is my daily driver and main computer, so I don't mind testing
things to improve its usage at all.
> <snip>
> Yes, the module is designed to be loaded only. I did not wanted to add
> more complexity in the driver as unloading it is not the priority ATM.
> We need this to be a module in order to load it after the other devices.
Makes sense, I just wasn't entirely sure if it was on purpose or not.
>>> + depends on DTPM
>>> + help
>>> + Describe the hierarchy for the Dynamic Thermal Power
>>> + Management tree on this platform. That will create all the
>>> + power capping capable devices.
>>> +
>>> endmenu
>>> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
>>> index 70d5de69fd7b..cf38496c3f61 100644
>>> --- a/drivers/soc/qcom/Makefile
>>> +++ b/drivers/soc/qcom/Makefile
>>> @@ -28,3 +28,4 @@ obj-$(CONFIG_QCOM_LLCC) += llcc-qcom.o
>>> obj-$(CONFIG_QCOM_RPMHPD) += rpmhpd.o
>>> obj-$(CONFIG_QCOM_RPMPD) += rpmpd.o
>>> obj-$(CONFIG_QCOM_KRYO_L2_ACCESSORS) += kryo-l2-accessors.o
>>> +obj-$(CONFIG_QCOM_DTPM) += dtpm.o
> [ ... ]
I noticed this as well, and was going to ask if it shouldn't be named
qcom_dtpm, but I don't think it matters since it would be in
/lib/modules/$kver/kernel/drivers/soc/qcom ?
>>> +static struct of_device_id __initdata sdm845_dtpm_match_table[] = {
>>> + { .compatible = "qcom,sdm845", .data = sdm845_hierarchy },
>>> + {},
>>> +};
>>> +
>>> +static int __init sdm845_dtpm_init(void)
>>> +{
>>> + return dtpm_create_hierarchy(sdm845_dtpm_match_table);
>>> +}
>>> +late_initcall(sdm845_dtpm_init);
>>> +
>>> +MODULE_DESCRIPTION("Qualcomm DTPM driver");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_ALIAS("platform:dtpm");
>>> +MODULE_AUTHOR("Daniel Lezcano <daniel.lezcano@kernel.org");
>>> +
>> It does seem to work aside from not being able to modprobe -r the
>> module. Although I do see
>>
>> [ 35.849622] dtpm: Registered dtpm node 'sdm845' / 0-0 uW,
>> [ 35.849652] dtpm: Registered dtpm node 'package' / 0-0 uW,
>> [ 35.849676] dtpm: Registered dtpm node 'cpu0-cpufreq' / 40000-436000 uW,
>> [ 35.849702] dtpm: Registered dtpm node 'cpu4-cpufreq' /
>> 520000-5828000 uW,
>> [ 35.849734] dtpm_devfreq: No energy model available for '5000000.gpu'
>> [ 35.849738] dtpm: Failed to setup '/soc@0/gpu@5000000': -22
>>
>> If the devfreq issue with the gpu isn't expected, are we missing
>> something for the c630?
> Yes, the energy model is missing for the GPU, very likely the
> 'dynamic-power-coefficient' property is missing in the gpu section.
>
> A quick test could be to add a value like 800. The resulting power
> numbers will be wrong but it should be possible to act on the
> performance by using these wrong power numbers.
>
> -- Daniel
>
So, I'm definitely not the greatest of kernel hackers, just enough
knowledge to be dangerous and I know how to apply patches properly....
I'm not able to actually get this working. I've tried adding it with a
few different numbers, and any time i try to add the d-p-c, I get
Dec 18 15:00:49 limitless kernel: [ 57.394503] adreno 5000000.gpu: EM:
invalid perf. state: -22
Dec 18 15:00:49 limitless kernel: [ 57.394515] dtpm_devfreq: No energy
model available for '5000000.gpu'
Dec 18 15:00:49 limitless kernel: [ 57.394519] dtpm: Failed to setup
'/soc@0/gpu@5000000': -22
-- steev
next prev parent reply other threads:[~2021-12-19 18:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 13:00 [PATCH v5 0/6] powercap/drivers/dtpm: Create the dtpm hierarchy Daniel Lezcano
2021-12-18 13:00 ` [PATCH v5 1/6] powercap/drivers/dtpm: Move dtpm table from init to data section Daniel Lezcano
2021-12-31 13:33 ` Ulf Hansson
2022-01-04 8:57 ` Daniel Lezcano
2022-01-07 13:15 ` Daniel Lezcano
2022-01-07 14:49 ` Ulf Hansson
2022-01-10 13:33 ` Daniel Lezcano
2021-12-18 13:00 ` [PATCH v5 2/6] powercap/drivers/dtpm: Add hierarchy creation Daniel Lezcano
2021-12-31 13:45 ` Ulf Hansson
2022-01-05 16:00 ` Daniel Lezcano
2022-01-07 15:54 ` Ulf Hansson
2022-01-10 15:55 ` Daniel Lezcano
2022-01-11 8:28 ` Ulf Hansson
2022-01-11 17:52 ` Daniel Lezcano
2022-01-12 12:00 ` Ulf Hansson
2022-01-14 19:15 ` Daniel Lezcano
2021-12-18 13:00 ` [PATCH v5 3/6] powercap/drivers/dtpm: Add CPU DT initialization support Daniel Lezcano
2021-12-31 13:46 ` Ulf Hansson
2021-12-18 13:00 ` [PATCH v5 4/6] powercap/drivers/dtpm: Add dtpm devfreq with energy model support Daniel Lezcano
2021-12-18 13:00 ` [PATCH v5 5/6] rockchip/soc/drivers: Add DTPM description for rk3399 Daniel Lezcano
2021-12-31 13:57 ` Ulf Hansson
2022-01-04 9:29 ` Geert Uytterhoeven
2022-01-05 9:21 ` Daniel Lezcano
2022-01-05 11:25 ` Daniel Lezcano
2021-12-18 13:00 ` [PATCH v5 6/6] qcom/soc/drivers: Add DTPM description for sdm845 Daniel Lezcano
2021-12-18 19:47 ` Steev Klimaszewski
2021-12-18 20:11 ` Daniel Lezcano
2021-12-19 18:44 ` Steev Klimaszewski [this message]
2021-12-19 20:27 ` Daniel Lezcano
2022-01-07 19:27 ` Bjorn Andersson
2022-01-07 22:07 ` Daniel Lezcano
2022-01-07 23:51 ` Bjorn Andersson
2021-12-23 13:20 ` [PATCH v5 0/6] powercap/drivers/dtpm: Create the dtpm hierarchy Daniel Lezcano
2021-12-23 13:32 ` Ulf Hansson
2021-12-23 13:42 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=818ed2a3-47d4-46d6-4bd3-ff2c7ff0192c@kali.org \
--to=steev@kali.org \
--cc=agross@kernel.org \
--cc=arnd@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=heiko@sntech.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).