From: Ulf Hansson <ulf.hansson@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rjw@rjwysocki.net, lukasz.luba@arm.com, robh@kernel.org,
heiko@sntech.de, arnd@linaro.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 0/6] powercap/drivers/dtpm: Create the dtpm hierarchy
Date: Thu, 23 Dec 2021 14:32:27 +0100 [thread overview]
Message-ID: <CAPDyKFpSeD5qqUMrBojga=3ecK_z4ad8PL7u+ZpyWXRpqHf94A@mail.gmail.com> (raw)
In-Reply-To: <3badc321-381d-a48c-8abd-7702639304bb@linaro.org>
On Thu, 23 Dec 2021 at 14:20, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> Hi all,
>
> any comments on this series. Is it fine if I merge it without patch 6/6?
>
> Heiko, is the description fine for you in the SoC specific code?
FYI, I intend to have a closer look at the series next week. Happy holidays!
Kind regards
Uffe
>
> Thanks
> -- Daniel
>
> On 18/12/2021 14:00, Daniel Lezcano wrote:
> > The DTPM hierarchy is the base to build on top of it a power budget
> > allocator. It reflects the power consumption of the group of devices
> > and allows to cap their power.
> >
> > The core code is there but there is no way to describe the desired
> > hierarchy yet.
> >
> > A first proposal introduced the description through configfs [1] but
> > was rejected [2].
> >
> > A second proposal based on the device tree with a binding similar to
> > the power domains [3] was proposed but finally rejected [4].
> >
> > This fifth version delegates the hierarchy creation to the SoC with a
> > specific and self-encapsulated code using an array to describe the tree. The
> > SoC DTPM driver defines an array of nodes pointing to their parents. The
> > hierarchy description can integrate a DT node and in the future a SCMI node,
> > that means the description can mix different type of nodes.
> >
> > In addition to the hierarchy creation, the devfreq dtpm support is also
> > integrated into this series.
> >
> > This series was tested on a rock960 (revision B - rk3399 based) and a
> > db845c (Qualcomm sdm845 based).
> >
> > [1] https://lore.kernel.org/all/20210401183654.27214-1-daniel.lezcano@linaro.org/
> > [2] https://lore.kernel.org/all/YGYg6ZeZ1181%2FpXk@kroah.com/
> > [3] https://lore.kernel.org/all/20211205231558.779698-1-daniel.lezcano@linaro.org/
> > [4] https://lore.kernel.org/all/YbfFapsmsjs4qnsg@robh.at.kernel.org/
> >
> > Changelog:
> > V5:
> > - Remove DT bindings
> > - Added description with an array
> > - Added simple description for rk3399 and sdm845
> > - Moved dtpm table to the data section
> >
> > V4:
> > - Added missing powerzone-cells
> > - Changed powerzone name to comply with the pattern property
> >
> > V3:
> > - Remove GPU section as no power is available (yet)
> > - Remove '#powerzone-cells' conforming to the bindings change
> > - Removed required property 'compatible'
> > - Removed powerzone-cells from the topmost node
> > - Removed powerzone-cells from cpus 'consumers' in example
> > - Set additionnal property to false
> >
> > V2:
> > - Added pattern properties and stick to powerzone-*
> > - Added required property compatible and powerzone-cells
> > - Added additionnal property
> > - Added compatible
> > - Renamed to 'powerzones'
> > - Added missing powerzone-cells to the topmost node
> > - Fixed errors reported by 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > - Move description in the SoC dtsi specific file
> > - Fixed missing prototype warning reported by lkp@
> >
> > V1: Initial post
> >
> > Daniel Lezcano (6):
> > powercap/drivers/dtpm: Move dtpm table from init to data section
> > powercap/drivers/dtpm: Add hierarchy creation
> > powercap/drivers/dtpm: Add CPU DT initialization support
> > powercap/drivers/dtpm: Add dtpm devfreq with energy model support
> > rockchip/soc/drivers: Add DTPM description for rk3399
> > qcom/soc/drivers: Add DTPM description for sdm845
> >
> > drivers/powercap/Kconfig | 8 ++
> > drivers/powercap/Makefile | 1 +
> > drivers/powercap/dtpm.c | 155 ++++++++++++++++++++++-
> > drivers/powercap/dtpm_cpu.c | 37 ++++--
> > drivers/powercap/dtpm_devfreq.c | 201 ++++++++++++++++++++++++++++++
> > drivers/soc/qcom/Kconfig | 9 ++
> > drivers/soc/qcom/Makefile | 1 +
> > drivers/soc/qcom/dtpm.c | 65 ++++++++++
> > drivers/soc/rockchip/Kconfig | 8 ++
> > drivers/soc/rockchip/Makefile | 1 +
> > drivers/soc/rockchip/dtpm.c | 56 +++++++++
> > include/asm-generic/vmlinux.lds.h | 4 +-
> > include/linux/dtpm.h | 21 +++-
> > 13 files changed, 551 insertions(+), 16 deletions(-)
> > create mode 100644 drivers/powercap/dtpm_devfreq.c
> > create mode 100644 drivers/soc/qcom/dtpm.c
> > create mode 100644 drivers/soc/rockchip/dtpm.c
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-12-23 13:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 13:00 [PATCH v5 0/6] powercap/drivers/dtpm: Create the dtpm hierarchy Daniel Lezcano
2021-12-18 13:00 ` [PATCH v5 1/6] powercap/drivers/dtpm: Move dtpm table from init to data section Daniel Lezcano
2021-12-31 13:33 ` Ulf Hansson
2022-01-04 8:57 ` Daniel Lezcano
2022-01-07 13:15 ` Daniel Lezcano
2022-01-07 14:49 ` Ulf Hansson
2022-01-10 13:33 ` Daniel Lezcano
2021-12-18 13:00 ` [PATCH v5 2/6] powercap/drivers/dtpm: Add hierarchy creation Daniel Lezcano
2021-12-31 13:45 ` Ulf Hansson
2022-01-05 16:00 ` Daniel Lezcano
2022-01-07 15:54 ` Ulf Hansson
2022-01-10 15:55 ` Daniel Lezcano
2022-01-11 8:28 ` Ulf Hansson
2022-01-11 17:52 ` Daniel Lezcano
2022-01-12 12:00 ` Ulf Hansson
2022-01-14 19:15 ` Daniel Lezcano
2021-12-18 13:00 ` [PATCH v5 3/6] powercap/drivers/dtpm: Add CPU DT initialization support Daniel Lezcano
2021-12-31 13:46 ` Ulf Hansson
2021-12-18 13:00 ` [PATCH v5 4/6] powercap/drivers/dtpm: Add dtpm devfreq with energy model support Daniel Lezcano
2021-12-18 13:00 ` [PATCH v5 5/6] rockchip/soc/drivers: Add DTPM description for rk3399 Daniel Lezcano
2021-12-31 13:57 ` Ulf Hansson
2022-01-04 9:29 ` Geert Uytterhoeven
2022-01-05 9:21 ` Daniel Lezcano
2022-01-05 11:25 ` Daniel Lezcano
2021-12-18 13:00 ` [PATCH v5 6/6] qcom/soc/drivers: Add DTPM description for sdm845 Daniel Lezcano
2021-12-18 19:47 ` Steev Klimaszewski
2021-12-18 20:11 ` Daniel Lezcano
2021-12-19 18:44 ` Steev Klimaszewski
2021-12-19 20:27 ` Daniel Lezcano
2022-01-07 19:27 ` Bjorn Andersson
2022-01-07 22:07 ` Daniel Lezcano
2022-01-07 23:51 ` Bjorn Andersson
2021-12-23 13:20 ` [PATCH v5 0/6] powercap/drivers/dtpm: Create the dtpm hierarchy Daniel Lezcano
2021-12-23 13:32 ` Ulf Hansson [this message]
2021-12-23 13:42 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpSeD5qqUMrBojga=3ecK_z4ad8PL7u+ZpyWXRpqHf94A@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=arnd@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).