* [PATCH] virtio-mem: Assign boolean values to a bool variable
@ 2021-01-20 7:50 Jiapeng Zhong
2021-01-20 9:40 ` David Hildenbrand
0 siblings, 1 reply; 8+ messages in thread
From: Jiapeng Zhong @ 2021-01-20 7:50 UTC (permalink / raw)
To: david; +Cc: mst, jasowang, virtualization, linux-kernel, Jiapeng Zhong
Fix the following coccicheck warnings:
./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
of 0/1 to bool variable.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
---
drivers/virtio/virtio_mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 9fc9ec4..85a272c 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
* actually in use (e.g., trying to reload the driver).
*/
if (vm->plugged_size) {
- vm->unplug_all_required = 1;
+ vm->unplug_all_required = true;
dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
2021-01-20 7:50 [PATCH] virtio-mem: Assign boolean values to a bool variable Jiapeng Zhong
@ 2021-01-20 9:40 ` David Hildenbrand
2021-01-20 9:57 ` Michael S. Tsirkin
0 siblings, 1 reply; 8+ messages in thread
From: David Hildenbrand @ 2021-01-20 9:40 UTC (permalink / raw)
To: Jiapeng Zhong, Michael S. Tsirkin
Cc: jasowang, virtualization, linux-kernel, Tian Tao
On 20.01.21 08:50, Jiapeng Zhong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
> of 0/1 to bool variable.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/virtio/virtio_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index 9fc9ec4..85a272c 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
> * actually in use (e.g., trying to reload the driver).
> */
> if (vm->plugged_size) {
> - vm->unplug_all_required = 1;
> + vm->unplug_all_required = true;
> dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
> }
>
>
Hi,
we already had a fix on the list for quite a while:
https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
However, looks like Michael queued your patch on the vhost tree instead.
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
2021-01-20 9:40 ` David Hildenbrand
@ 2021-01-20 9:57 ` Michael S. Tsirkin
2021-01-20 10:04 ` David Hildenbrand
0 siblings, 1 reply; 8+ messages in thread
From: Michael S. Tsirkin @ 2021-01-20 9:57 UTC (permalink / raw)
To: David Hildenbrand
Cc: Jiapeng Zhong, jasowang, virtualization, linux-kernel, Tian Tao
On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
> On 20.01.21 08:50, Jiapeng Zhong wrote:
> > Fix the following coccicheck warnings:
> >
> > ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
> > of 0/1 to bool variable.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> > ---
> > drivers/virtio/virtio_mem.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> > index 9fc9ec4..85a272c 100644
> > --- a/drivers/virtio/virtio_mem.c
> > +++ b/drivers/virtio/virtio_mem.c
> > @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
> > * actually in use (e.g., trying to reload the driver).
> > */
> > if (vm->plugged_size) {
> > - vm->unplug_all_required = 1;
> > + vm->unplug_all_required = true;
> > dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
> > }
> >
> >
>
> Hi,
>
> we already had a fix on the list for quite a while:
>
> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
Can't find that one.
> However, looks like Michael queued your patch on the vhost tree instead.
>
> --
> Thanks,
>
> David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
2021-01-20 9:57 ` Michael S. Tsirkin
@ 2021-01-20 10:04 ` David Hildenbrand
2021-01-20 11:03 ` Michael S. Tsirkin
0 siblings, 1 reply; 8+ messages in thread
From: David Hildenbrand @ 2021-01-20 10:04 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Jiapeng Zhong, jasowang, virtualization, linux-kernel, Tian Tao
On 20.01.21 10:57, Michael S. Tsirkin wrote:
> On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
>> On 20.01.21 08:50, Jiapeng Zhong wrote:
>>> Fix the following coccicheck warnings:
>>>
>>> ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
>>> of 0/1 to bool variable.
>>>
>>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>>> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
>>> ---
>>> drivers/virtio/virtio_mem.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
>>> index 9fc9ec4..85a272c 100644
>>> --- a/drivers/virtio/virtio_mem.c
>>> +++ b/drivers/virtio/virtio_mem.c
>>> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
>>> * actually in use (e.g., trying to reload the driver).
>>> */
>>> if (vm->plugged_size) {
>>> - vm->unplug_all_required = 1;
>>> + vm->unplug_all_required = true;
>>> dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
>>> }
>>>
>>>
>>
>> Hi,
>>
>> we already had a fix on the list for quite a while:
>>
>> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
>
> Can't find that one.
Looks like it was only on virtualization@ and a couple of people on cc.
https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html
Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use
boolean value when setting vm->unplug_all_required") in the mailing list
archives, even though it has virtualization@ on cc.
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
2021-01-20 10:04 ` David Hildenbrand
@ 2021-01-20 11:03 ` Michael S. Tsirkin
2021-01-20 11:14 ` David Hildenbrand
0 siblings, 1 reply; 8+ messages in thread
From: Michael S. Tsirkin @ 2021-01-20 11:03 UTC (permalink / raw)
To: David Hildenbrand
Cc: Jiapeng Zhong, jasowang, virtualization, linux-kernel, Tian Tao
On Wed, Jan 20, 2021 at 11:04:18AM +0100, David Hildenbrand wrote:
> On 20.01.21 10:57, Michael S. Tsirkin wrote:
> > On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
> >> On 20.01.21 08:50, Jiapeng Zhong wrote:
> >>> Fix the following coccicheck warnings:
> >>>
> >>> ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
> >>> of 0/1 to bool variable.
> >>>
> >>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> >>> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> >>> ---
> >>> drivers/virtio/virtio_mem.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> >>> index 9fc9ec4..85a272c 100644
> >>> --- a/drivers/virtio/virtio_mem.c
> >>> +++ b/drivers/virtio/virtio_mem.c
> >>> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
> >>> * actually in use (e.g., trying to reload the driver).
> >>> */
> >>> if (vm->plugged_size) {
> >>> - vm->unplug_all_required = 1;
> >>> + vm->unplug_all_required = true;
> >>> dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
> >>> }
> >>>
> >>>
> >>
> >> Hi,
> >>
> >> we already had a fix on the list for quite a while:
> >>
> >> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
> >
> > Can't find that one.
>
> Looks like it was only on virtualization@ and a couple of people on cc.
>
> https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html
>
> Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use
> boolean value when setting vm->unplug_all_required") in the mailing list
> archives, even though it has virtualization@ on cc.
Unsurprising that I didn't merge it then ;)
Want to send your ack on this one?
> --
> Thanks,
>
> David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
2021-01-20 11:03 ` Michael S. Tsirkin
@ 2021-01-20 11:14 ` David Hildenbrand
2021-01-20 11:33 ` Michael S. Tsirkin
0 siblings, 1 reply; 8+ messages in thread
From: David Hildenbrand @ 2021-01-20 11:14 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Jiapeng Zhong, jasowang, virtualization, linux-kernel, Tian Tao
On 20.01.21 12:03, Michael S. Tsirkin wrote:
> On Wed, Jan 20, 2021 at 11:04:18AM +0100, David Hildenbrand wrote:
>> On 20.01.21 10:57, Michael S. Tsirkin wrote:
>>> On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
>>>> On 20.01.21 08:50, Jiapeng Zhong wrote:
>>>>> Fix the following coccicheck warnings:
>>>>>
>>>>> ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
>>>>> of 0/1 to bool variable.
>>>>>
>>>>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>>>>> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
>>>>> ---
>>>>> drivers/virtio/virtio_mem.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
>>>>> index 9fc9ec4..85a272c 100644
>>>>> --- a/drivers/virtio/virtio_mem.c
>>>>> +++ b/drivers/virtio/virtio_mem.c
>>>>> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
>>>>> * actually in use (e.g., trying to reload the driver).
>>>>> */
>>>>> if (vm->plugged_size) {
>>>>> - vm->unplug_all_required = 1;
>>>>> + vm->unplug_all_required = true;
>>>>> dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
>>>>> }
>>>>>
>>>>>
>>>>
>>>> Hi,
>>>>
>>>> we already had a fix on the list for quite a while:
>>>>
>>>> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
>>>
>>> Can't find that one.
>>
>> Looks like it was only on virtualization@ and a couple of people on cc.
>>
>> https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html
>>
>> Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use
>> boolean value when setting vm->unplug_all_required") in the mailing list
>> archives, even though it has virtualization@ on cc.
>
>
> Unsurprising that I didn't merge it then ;)
Well, you were on cc ;)
> Want to send your ack on this one?
Sure
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
2021-01-20 11:14 ` David Hildenbrand
@ 2021-01-20 11:33 ` Michael S. Tsirkin
2021-01-20 11:33 ` David Hildenbrand
0 siblings, 1 reply; 8+ messages in thread
From: Michael S. Tsirkin @ 2021-01-20 11:33 UTC (permalink / raw)
To: David Hildenbrand
Cc: Jiapeng Zhong, jasowang, virtualization, linux-kernel, Tian Tao
On Wed, Jan 20, 2021 at 12:14:14PM +0100, David Hildenbrand wrote:
> On 20.01.21 12:03, Michael S. Tsirkin wrote:
> > On Wed, Jan 20, 2021 at 11:04:18AM +0100, David Hildenbrand wrote:
> >> On 20.01.21 10:57, Michael S. Tsirkin wrote:
> >>> On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
> >>>> On 20.01.21 08:50, Jiapeng Zhong wrote:
> >>>>> Fix the following coccicheck warnings:
> >>>>>
> >>>>> ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
> >>>>> of 0/1 to bool variable.
> >>>>>
> >>>>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> >>>>> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> >>>>> ---
> >>>>> drivers/virtio/virtio_mem.c | 2 +-
> >>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> >>>>> index 9fc9ec4..85a272c 100644
> >>>>> --- a/drivers/virtio/virtio_mem.c
> >>>>> +++ b/drivers/virtio/virtio_mem.c
> >>>>> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
> >>>>> * actually in use (e.g., trying to reload the driver).
> >>>>> */
> >>>>> if (vm->plugged_size) {
> >>>>> - vm->unplug_all_required = 1;
> >>>>> + vm->unplug_all_required = true;
> >>>>> dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
> >>>>> }
> >>>>>
> >>>>>
> >>>>
> >>>> Hi,
> >>>>
> >>>> we already had a fix on the list for quite a while:
> >>>>
> >>>> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
> >>>
> >>> Can't find that one.
> >>
> >> Looks like it was only on virtualization@ and a couple of people on cc.
> >>
> >> https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html
> >>
> >> Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use
> >> boolean value when setting vm->unplug_all_required") in the mailing list
> >> archives, even though it has virtualization@ on cc.
> >
> >
> > Unsurprising that I didn't merge it then ;)
>
> Well, you were on cc ;)
Hmm true. Found it now.
> > Want to send your ack on this one?
>
> Sure
>
> Acked-by: David Hildenbrand <david@redhat.com>
Added yours and the original Signed-off-by.
Thanks!
>
> --
> Thanks,
>
> David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
2021-01-20 11:33 ` Michael S. Tsirkin
@ 2021-01-20 11:33 ` David Hildenbrand
0 siblings, 0 replies; 8+ messages in thread
From: David Hildenbrand @ 2021-01-20 11:33 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Jiapeng Zhong, jasowang, virtualization, linux-kernel, Tian Tao
>>> Want to send your ack on this one?
>>
>> Sure
>>
>> Acked-by: David Hildenbrand <david@redhat.com>
>
>
> Added yours and the original Signed-off-by.
>
> Thanks!
Thanks Michael!
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-01-20 12:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 7:50 [PATCH] virtio-mem: Assign boolean values to a bool variable Jiapeng Zhong
2021-01-20 9:40 ` David Hildenbrand
2021-01-20 9:57 ` Michael S. Tsirkin
2021-01-20 10:04 ` David Hildenbrand
2021-01-20 11:03 ` Michael S. Tsirkin
2021-01-20 11:14 ` David Hildenbrand
2021-01-20 11:33 ` Michael S. Tsirkin
2021-01-20 11:33 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).