* [PATCH] xen/pvcalls: fix unsigned less than zero error check
@ 2017-11-03 8:42 Colin King
2017-11-03 9:01 ` Juergen Gross
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-11-03 8:42 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, xen-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The check on bedata->ref is never true because ref is an unsigned
integer. Fix this by assigning signed int ret to the return of the
call to gnttab_claim_grant_reference so the -ve return can be checked.
Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0")
Fixes: 219681909913 ("xen/pvcalls: connect to the backend")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/xen/pvcalls-front.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 0c1ec6894cc4..de8a470351a5 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -1186,11 +1186,10 @@ static int pvcalls_front_probe(struct xenbus_device *dev,
ret = gnttab_alloc_grant_references(1, &gref_head);
if (ret < 0)
goto error;
- bedata->ref = gnttab_claim_grant_reference(&gref_head);
- if (bedata->ref < 0) {
- ret = bedata->ref;
+ ret = gnttab_claim_grant_reference(&gref_head);
+ if (ret < 0)
goto error;
- }
+ bedata->ref = ret;
gnttab_grant_foreign_access_ref(bedata->ref, dev->otherend_id,
virt_to_gfn((void *)sring), 0);
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/pvcalls: fix unsigned less than zero error check
2017-11-03 8:42 [PATCH] xen/pvcalls: fix unsigned less than zero error check Colin King
@ 2017-11-03 9:01 ` Juergen Gross
2017-11-08 21:20 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2017-11-03 9:01 UTC (permalink / raw)
To: Colin King, Boris Ostrovsky, xen-devel; +Cc: kernel-janitors, linux-kernel
On 03/11/17 09:42, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check on bedata->ref is never true because ref is an unsigned
> integer. Fix this by assigning signed int ret to the return of the
> call to gnttab_claim_grant_reference so the -ve return can be checked.
>
> Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0")
>
> Fixes: 219681909913 ("xen/pvcalls: connect to the backend")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/pvcalls: fix unsigned less than zero error check
2017-11-03 9:01 ` Juergen Gross
@ 2017-11-08 21:20 ` Boris Ostrovsky
0 siblings, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2017-11-08 21:20 UTC (permalink / raw)
To: Juergen Gross, Colin King, xen-devel; +Cc: kernel-janitors, linux-kernel
On 11/03/2017 05:01 AM, Juergen Gross wrote:
> On 03/11/17 09:42, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The check on bedata->ref is never true because ref is an unsigned
>> integer. Fix this by assigning signed int ret to the return of the
>> call to gnttab_claim_grant_reference so the -ve return can be checked.
>>
>> Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0")
>>
>> Fixes: 219681909913 ("xen/pvcalls: connect to the backend")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Applied to for-linus-4.15.
-boris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-08 21:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 8:42 [PATCH] xen/pvcalls: fix unsigned less than zero error check Colin King
2017-11-03 9:01 ` Juergen Gross
2017-11-08 21:20 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).