* [PATCH] bcache: explicitly destory mutex while exiting
@ 2017-05-02 8:09 Liang Chen
2017-05-04 13:59 ` Coly Li
0 siblings, 1 reply; 2+ messages in thread
From: Liang Chen @ 2017-05-02 8:09 UTC (permalink / raw)
To: linux-bcache; +Cc: linux-kernel, colyli, bcache, Liang Chen
mutex_destroy does nothing most of time, but it's better to call
it to make the code future proof and it also has some meaning
for like mutex debug.
Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
---
drivers/md/bcache/super.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 85e3f21..406fe03 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -2083,6 +2083,7 @@ static void bcache_exit(void)
if (bcache_major)
unregister_blkdev(bcache_major, "bcache");
unregister_reboot_notifier(&reboot);
+ mutex_destroy(&bch_register_lock);
}
static int __init bcache_init(void)
@@ -2100,6 +2101,7 @@ static int __init bcache_init(void)
bcache_major = register_blkdev(0, "bcache");
if (bcache_major < 0) {
+ mutex_destroy(&bch_register_lock);
unregister_reboot_notifier(&reboot);
return bcache_major;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bcache: explicitly destory mutex while exiting
2017-05-02 8:09 [PATCH] bcache: explicitly destory mutex while exiting Liang Chen
@ 2017-05-04 13:59 ` Coly Li
0 siblings, 0 replies; 2+ messages in thread
From: Coly Li @ 2017-05-04 13:59 UTC (permalink / raw)
To: Liang Chen, linux-bcache; +Cc: linux-kernel, colyli, bcache
On 2017/5/2 下午4:09, Liang Chen wrote:
> mutex_destroy does nothing most of time, but it's better to call
> it to make the code future proof and it also has some meaning
> for like mutex debug.
>
Hi Liang,
Could you please explain a little bit more about how mutex_destroy()
helps to future proof of the code, and how it helps to mutex debug ?
Forgive me for not catching your point.
Thanks.
> Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
> ---
> drivers/md/bcache/super.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 85e3f21..406fe03 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -2083,6 +2083,7 @@ static void bcache_exit(void)
> if (bcache_major)
> unregister_blkdev(bcache_major, "bcache");
> unregister_reboot_notifier(&reboot);
> + mutex_destroy(&bch_register_lock);
> }
>
> static int __init bcache_init(void)
> @@ -2100,6 +2101,7 @@ static int __init bcache_init(void)
>
> bcache_major = register_blkdev(0, "bcache");
> if (bcache_major < 0) {
> + mutex_destroy(&bch_register_lock);
> unregister_reboot_notifier(&reboot);
> return bcache_major;
> }
>
--
Coly Li
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-04 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 8:09 [PATCH] bcache: explicitly destory mutex while exiting Liang Chen
2017-05-04 13:59 ` Coly Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).